From 804e7edc23ba17d679d8d85d4271e9b754d5566d Mon Sep 17 00:00:00 2001 From: maskpp Date: Fri, 2 Dec 2022 14:12:07 +0800 Subject: [PATCH] refactor: rename `NewTraceTransaction` to `NewTransactionData` (#190) rename NewTraceTransaction to NewTransactionData --- core/types/l2trace.go | 4 ++-- eth/tracers/api_blocktrace.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/types/l2trace.go b/core/types/l2trace.go index 7fa0890930..5981f06a89 100644 --- a/core/types/l2trace.go +++ b/core/types/l2trace.go @@ -165,9 +165,9 @@ type TransactionData struct { S *hexutil.Big `json:"s"` } -// NewTraceTransaction returns a transaction that will serialize to the trace +// NewTransactionData returns a transaction that will serialize to the trace // representation, with the given location metadata set (if available). -func NewTraceTransaction(tx *Transaction, blockNumber uint64, config *params.ChainConfig) *TransactionData { +func NewTransactionData(tx *Transaction, blockNumber uint64, config *params.ChainConfig) *TransactionData { signer := MakeSigner(config, big.NewInt(0).SetUint64(blockNumber)) from, _ := Sender(signer, tx) v, r, s := tx.RawSignatureValues() diff --git a/eth/tracers/api_blocktrace.go b/eth/tracers/api_blocktrace.go index c3959577a3..79f1f42345 100644 --- a/eth/tracers/api_blocktrace.go +++ b/eth/tracers/api_blocktrace.go @@ -334,7 +334,7 @@ func (api *API) fillBlockTrace(env *traceEnv, block *types.Block) (*types.BlockT txs := make([]*types.TransactionData, block.Transactions().Len()) for i, tx := range block.Transactions() { - txs[i] = types.NewTraceTransaction(tx, block.NumberU64(), api.backend.ChainConfig()) + txs[i] = types.NewTransactionData(tx, block.NumberU64(), api.backend.ChainConfig()) } blockTrace := &types.BlockTrace{