forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-17 01:13:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

discovery: allow bootstrap URLs to have a resolvable hostname.

Browse source
This commit is contained in:
VOLAT Matthieu 22923 2017-08-28 09:08:21 +02:00
parent ebf41d16a0
commit 8201b02ae5
No known key found for this signature in database
GPG key ID: 133B1C2578988521
4 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
p2p/discover/node.go
View file

@ -171,13 +171,15 @@ func parseComplete(rawurl string) (*Node, error) {
if id, err = HexID(u.User.String()); err != nil { if id, err = HexID(u.User.String()); err != nil {
return nil, fmt.Errorf("invalid node ID (%v)", err) return nil, fmt.Errorf("invalid node ID (%v)", err)
} }
// Parse the IP address. // Parse the host.
host, port, err := net.SplitHostPort(u.Host) host, port, err := net.SplitHostPort(u.Host)
if err != nil { if err != nil {
return nil, fmt.Errorf("invalid host: %v", err) return nil, fmt.Errorf("invalid host: %v", err)
} }
if ip = net.ParseIP(host); ip == nil { if addrs, err := net.LookupIP(host); err == nil {
return nil, errors.New("invalid IP address") ip = addrs[0] // Take first address
} else {
return nil, errors.New("could not resolve host")
} }
// Ensure the IP is 4 bytes long for IPv4 addresses. // Ensure the IP is 4 bytes long for IPv4 addresses.
if ipv4 := ip.To4(); ipv4 != nil { if ipv4 := ip.To4(); ipv4 != nil {

2
p2p/discover/node_test.go
View file

@ -68,7 +68,7 @@ var parseNodeTests = []struct {
// Complete nodes with IP address. // Complete nodes with IP address.
{ {
rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@hostname:3", rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@hostname:3",
wantError: `invalid IP address`, wantError: `could not resolve host`,
}, },
{ {
rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@127.0.0.1:foo", rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@127.0.0.1:foo",

8
p2p/discv5/node.go
View file

@ -179,13 +179,15 @@ func parseComplete(rawurl string) (*Node, error) {
if id, err = HexID(u.User.String()); err != nil { if id, err = HexID(u.User.String()); err != nil {
return nil, fmt.Errorf("invalid node ID (%v)", err) return nil, fmt.Errorf("invalid node ID (%v)", err)
} }
// Parse the IP address. // Parse the host.
host, port, err := net.SplitHostPort(u.Host) host, port, err := net.SplitHostPort(u.Host)
if err != nil { if err != nil {
return nil, fmt.Errorf("invalid host: %v", err) return nil, fmt.Errorf("invalid host: %v", err)
} }
if ip = net.ParseIP(host); ip == nil { if addrs, err := net.LookupIP(host); err == nil {
return nil, errors.New("invalid IP address") ip = addrs[0] // Take first address
} else {
return nil, errors.New("could not resolve host")
} }
// Ensure the IP is 4 bytes long for IPv4 addresses. // Ensure the IP is 4 bytes long for IPv4 addresses.
if ipv4 := ip.To4(); ipv4 != nil { if ipv4 := ip.To4(); ipv4 != nil {

2
p2p/discv5/node_test.go
View file

@ -68,7 +68,7 @@ var parseNodeTests = []struct {
// Complete nodes with IP address. // Complete nodes with IP address.
{ {
rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@hostname:3", rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@hostname:3",
wantError: `invalid IP address`, wantError: `could not resolve host`,
}, },
{ {
rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@127.0.0.1:foo", rawurl: "enode://1dd9d65c4552b5eb43d5ad55a2ee3f56c6cbc1c64a5c8d659f51fcd51bace24351232b8d7821617d2b29b54b81cdefb9b3e9c37d7fd5f63270bcc9e1a6f6a439@127.0.0.1:foo",