forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-22 15:59:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ethclient: fix timeout param for eth_sendRawTransactionSync (#33693)
Some checks are pending
/ Linux Build (push) Waiting to run
Details
/ Linux Build (arm) (push) Waiting to run
Details
/ Keeper Build (push) Waiting to run
Details
/ Windows Build (push) Waiting to run
Details
/ Docker Image (push) Waiting to run
Details

Browse source 
Fix timeout parameter in eth_sendRawTransactionSync
to be an integer instead of hex. The spec has now been
clarified on this point.
This commit is contained in:
milan-cb 2026-01-29 12:41:18 -08:00 committed by GitHub
parent a179ccf6f0
commit 845009f684
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ethclient/ethclient.go
View file

@ -729,9 +729,11 @@ func (ec *Client) SendRawTransactionSync(
rawTx []byte, rawTx []byte,
timeout *time.Duration, timeout *time.Duration,
) (*types.Receipt, error) { ) (*types.Receipt, error) {
var ms *hexutil.Uint64 var ms *uint64
if timeout != nil { if timeout != nil {
if d := hexutil.Uint64(timeout.Milliseconds()); d > 0 { msInt := timeout.Milliseconds()
if msInt > 0 {
d := uint64(msInt)
ms = &d ms = &d
} }
} }

2
internal/ethapi/api.go
View file

@ -1661,7 +1661,7 @@ func (api *TransactionAPI) SendRawTransaction(ctx context.Context, input hexutil
// SendRawTransactionSync will add the signed transaction to the transaction pool // SendRawTransactionSync will add the signed transaction to the transaction pool
// and wait until the transaction has been included in a block and return the receipt, or the timeout. // and wait until the transaction has been included in a block and return the receipt, or the timeout.
func (api *TransactionAPI) SendRawTransactionSync(ctx context.Context, input hexutil.Bytes, timeoutMs *hexutil.Uint64) (map[string]interface{}, error) { func (api *TransactionAPI) SendRawTransactionSync(ctx context.Context, input hexutil.Bytes, timeoutMs *uint64) (map[string]interface{}, error) {
tx := new(types.Transaction) tx := new(types.Transaction)
if err := tx.UnmarshalBinary(input); err != nil { if err := tx.UnmarshalBinary(input); err != nil {
return nil, err return nil, err

2
internal/ethapi/api_test.go
View file

@ -4026,7 +4026,7 @@ func TestSendRawTransactionSync_Timeout(t *testing.T) {
raw, _ := makeSelfSignedRaw(t, api, b.acc.Address) raw, _ := makeSelfSignedRaw(t, api, b.acc.Address)
timeout := hexutil.Uint64(200) // 200ms timeout := uint64(200) // 200ms
receipt, err := api.SendRawTransactionSync(context.Background(), raw, &timeout) receipt, err := api.SendRawTransactionSync(context.Background(), raw, &timeout)
if receipt != nil { if receipt != nil {