forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-03-01 00:53:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #19854 from karalabe/genesis-commit-check

Browse source 
core: check error before accessing potentially nil block
This commit is contained in:
Péter Szilágyi 2019-07-18 16:03:36 +03:00 committed by GitHub
commit 8485f7cc7b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
core/genesis.go
View file

@ -164,7 +164,10 @@ func SetupGenesisBlock(db ethdb.Database, genesis *Genesis) (*params.ChainConfig
log.Info("Writing custom genesis block")
}
block, err := genesis.Commit(db)
return genesis.Config, block.Hash(), err
if err != nil {
return genesis.Config, common.Hash{}, err
}
return genesis.Config, block.Hash(), nil
}
// We have the genesis block in database(perhaps in ancient database)
@ -180,7 +183,10 @@ func SetupGenesisBlock(db ethdb.Database, genesis *Genesis) (*params.ChainConfig
return genesis.Config, hash, &GenesisMismatchError{stored, hash}
}
block, err := genesis.Commit(db)
return genesis.Config, block.Hash(), err
if err != nil {
return genesis.Config, hash, err
}
return genesis.Config, block.Hash(), nil
}
// Check whether the genesis block is already written.