From 864ae0f3c2e8dfd4a86779ae108c3f6e0308d7c0 Mon Sep 17 00:00:00 2001 From: Mark Vujevits Date: Tue, 6 Nov 2018 15:20:10 +0100 Subject: [PATCH] resolve pr comments regarding comments and added a missing newline --- swarm/network/kademlia_test.go | 10 ++++++++++ swarm/network/stream/delivery_test.go | 1 + 2 files changed, 11 insertions(+) diff --git a/swarm/network/kademlia_test.go b/swarm/network/kademlia_test.go index 8af584846c..f5d87fee85 100644 --- a/swarm/network/kademlia_test.go +++ b/swarm/network/kademlia_test.go @@ -254,25 +254,35 @@ func TestSuggestPeerFindPeers(t *testing.T) { } +// a node should stay in the address book if it's removed from the kademlia func TestOffEffectingAddressBookNormalNode(t *testing.T) { k := newTestKademlia("00000000") + // peer added to kademlia k.On(newTestKadPeer(k, "01000000", false)) + // peer should be in the address book if k.addrs.Size() != 1 { t.Fatal("known peer addresses should contain 1 entry") } + // remove peer from kademlia k.Off(newTestKadPeer(k, "01000000", false)) + // peer should not be in the address book if k.addrs.Size() != 1 { t.Fatal("known peer addresses should contain 1 entry") } } +// a light node should not be in the address book func TestOffEffectingAddressBookLightNode(t *testing.T) { k := newTestKademlia("00000000") + // light node peer added to kademlia k.On(newTestKadPeer(k, "01000000", true)) + // peer should not be in the address book if k.addrs.Size() != 0 { t.Fatal("known peer addresses should contain 0 entry") } + // remove peer from kademlia k.Off(newTestKadPeer(k, "01000000", true)) + // peer should not be in the address book if k.addrs.Size() != 0 { t.Fatal("known peer addresses should contain 0 entry") } diff --git a/swarm/network/stream/delivery_test.go b/swarm/network/stream/delivery_test.go index a9960ce348..9163709f00 100644 --- a/swarm/network/stream/delivery_test.go +++ b/swarm/network/stream/delivery_test.go @@ -306,6 +306,7 @@ func TestRequestFromPeersWithLightNode(t *testing.T) { t.Fatalf("expected '%v', got %v", expectedError, err) } } + func TestStreamerDownstreamChunkDeliveryMsgExchange(t *testing.T) { tester, streamer, localStore, teardown, err := newStreamerTester(t, &RegistryOptions{ DoServeRetrieve: true,