forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-11 10:36:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

node: avoid double close resp.Body (#31710)

Browse source 
The functions `rpcRequest` and `batchRpcRequest` call `baseRpcRequest`.
And `resp.Body` will be closed in the function `baseRpcRequest` later by
`t.Cleanup`:

```go
func baseRpcRequest(t *testing.T, url, bodyStr string, extraHeaders ...string) *http.Response {
        // ......
	t.Cleanup(func() { resp.Body.Close() })
	return resp
}
```
This commit is contained in:
Daniel Liu 2025-05-02 23:21:17 +08:00 committed by GitHub
parent ed93a5ac04
commit 86a492471a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
node/rpcstack_test.go
View file

@ -570,7 +570,6 @@ func TestHTTPWriteTimeout(t *testing.T) {
// Send normal request // Send normal request
t.Run("message", func(t *testing.T) { t.Run("message", func(t *testing.T) {
resp := rpcRequest(t, url, "test_sleep") resp := rpcRequest(t, url, "test_sleep")
defer resp.Body.Close()
body, err := io.ReadAll(resp.Body) body, err := io.ReadAll(resp.Body)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
@ -584,7 +583,6 @@ func TestHTTPWriteTimeout(t *testing.T) {
t.Run("batch", func(t *testing.T) { t.Run("batch", func(t *testing.T) {
want := fmt.Sprintf("[%s,%s,%s]", greetRes, timeoutRes, timeoutRes) want := fmt.Sprintf("[%s,%s,%s]", greetRes, timeoutRes, timeoutRes)
resp := batchRpcRequest(t, url, []string{"test_greet", "test_sleep", "test_greet"}) resp := batchRpcRequest(t, url, []string{"test_greet", "test_sleep", "test_greet"})
defer resp.Body.Close()
body, err := io.ReadAll(resp.Body) body, err := io.ReadAll(resp.Body)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)