forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-27 15:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

comments

Browse source
This commit is contained in:
Jared Wasinger 2025-02-28 00:00:56 +01:00
parent 177b34114f
commit 8a70820f03
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
cmd/devp2p/internal/ethtest/suite.go
View file

@ -903,8 +903,9 @@ func (s *Suite) testBadBlobTx(t *utesting.T, tx *types.Transaction, badTx *types
errc := make(chan error) errc := make(chan error)
badPeer := func() { badPeer := func() {
// announce immediately with correct hash, but missing sidecar. // announce the correct hash from the bad peer.
// when the transaction is first requested, trigger step 2: connection and announcement by good peers // when the transaction is first requested before transmitting it from the bad peer,
// trigger step 2: connection and announcement by good peers
conn, err := s.dial() conn, err := s.dial()
if err != nil { if err != nil {
@ -938,8 +939,8 @@ func (s *Suite) testBadBlobTx(t *utesting.T, tx *types.Transaction, badTx *types
stage1.Done() stage1.Done()
stage2.Wait() stage2.Wait()
// the good peer(s) are connected, and have announced the same tx hash. // the good peer is connected, and has announced the tx.
// proceed to send the bad one. // proceed to send the incorrect one from the bad peer.
resp := eth.PooledTransactionsPacket{RequestId: req.RequestId, PooledTransactionsResponse: eth.PooledTransactionsResponse(types.Transactions{badTx})} resp := eth.PooledTransactionsPacket{RequestId: req.RequestId, PooledTransactionsResponse: eth.PooledTransactionsResponse(types.Transactions{badTx})}
if err := conn.Write(ethProto, eth.PooledTransactionsMsg, resp); err != nil { if err := conn.Write(ethProto, eth.PooledTransactionsMsg, resp); err != nil {
@ -968,9 +969,6 @@ func (s *Suite) testBadBlobTx(t *utesting.T, tx *types.Transaction, badTx *types
return return
} }
// announce the tx with correct size, trigger stage 2 (transmission from bad peer)
// wait for step 3 (transmission from good peer)
ann := eth.NewPooledTransactionHashesPacket{ ann := eth.NewPooledTransactionHashesPacket{
Types: []byte{types.BlobTxType}, Types: []byte{types.BlobTxType},
Sizes: []uint32{uint32(tx.Size())}, Sizes: []uint32{uint32(tx.Size())},
@ -982,11 +980,12 @@ func (s *Suite) testBadBlobTx(t *utesting.T, tx *types.Transaction, badTx *types
return return
} }
// wait until the bad peer has transmitted the incorrect transaction
stage2.Done() stage2.Done()
stage3.Wait() stage3.Wait()
// the bad peer has responded with sidecar-less transaction. // the bad peer has transmitted the bad tx, and been disconnected.
// bad peers are presumably disconnected now. // transmit the same tx but with correct sidecar from the good peer.
var req *eth.GetPooledTransactionsPacket var req *eth.GetPooledTransactionsPacket
req, err = readUntil[eth.GetPooledTransactionsPacket](context.Background(), conn) req, err = readUntil[eth.GetPooledTransactionsPacket](context.Background(), conn)