forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-28 07:36:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fixed extraneous CodeChange now recorded since Geth 1.14.12 merge

Browse source 
Geth 1.14.12 introduced new `OnCodeChange` emitting which breaks Firehose tracing which is not recording those.

Changed a big how we record call suicide and ignore `CodeChange` that makes the contract empty when a call is suicided.
This commit is contained in:
Matthieu Vachon 2025-01-08 17:09:46 -05:00
parent 12f070888f
commit 8baf43f2a3
1 changed files with 31 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
eth/tracers/firehose.go
View file

@ -793,8 +793,6 @@ func (f *Firehose) OnCallEnter(depth int, typ byte, from common.Address, to comm
// So we ignore `OnEnter/OnExit` callbacks for `SELFDESTRUCT` opcode, we ignore it here and set
// a special sentinel variable that will tell `OnExit` to ignore itself.
if opCode == vm.SELFDESTRUCT {
f.ensureInCall()
f.callStack.Peek().Suicide = true
// The next OnCallExit must be ignored, this variable will make the next OnCallExit to be ignored
f.latestCallEnterSuicided = true
@ -842,8 +840,13 @@ func (f *Firehose) OnOpcode(pc uint64, op byte, gas, cost uint64, scope tracing.
}
}
if opCode == vm.KECCAK256 {
switch opCode {
case vm.KECCAK256:
f.onOpcodeKeccak256(activeCall, scope.StackData(), Memory(scope.MemoryData()))
case vm.SELFDESTRUCT:
f.ensureInCall()
f.callStack.Peek().Suicide = true
}
}
}
@ -1225,16 +1228,9 @@ func (f *Firehose) OnNonceChange(a common.Address, prev, new uint64) {
}
func (f *Firehose) OnCodeChange(a common.Address, prevCodeHash common.Hash, prev []byte, codeHash common.Hash, code []byte) {
f.ensureInBlockOrTrx()
firehoseDebug("code changed (address=%s prev_hash=%s new_hash=%s)", a, prevCodeHash, codeHash)
change := &pbeth.CodeChange{
Address: a.Bytes(),
OldHash: prevCodeHash.Bytes(),
OldCode: prev,
NewHash: codeHash.Bytes(),
NewCode: code,
Ordinal: f.blockOrdinal.Next(),
}
f.ensureInBlockOrTrx()
if f.transaction != nil {
activeCall := f.callStack.Peek()
@ -1242,9 +1238,30 @@ func (f *Firehose) OnCodeChange(a common.Address, prevCodeHash common.Hash, prev
f.panicInvalidState("caller expected to be in call state but we were not, this is a bug", 0)
}
activeCall.CodeChanges = append(activeCall.CodeChanges, change)
// Geth 1.14.12 introduced a new behavior where a code change is emitted when a contract
// suicides. This was not the case before and we must ignore those changes to keep backward
// compatibility with the Firehose 2.3 and 3.0 model.
if activeCall.Suicide && len(code) == 0 {
return
}
activeCall.CodeChanges = append(activeCall.CodeChanges, &pbeth.CodeChange{
Address: a.Bytes(),
OldHash: prevCodeHash.Bytes(),
OldCode: prev,
NewHash: codeHash.Bytes(),
NewCode: code,
Ordinal: f.blockOrdinal.Next(),
})
} else {
f.block.CodeChanges = append(f.block.CodeChanges, change)
f.block.CodeChanges = append(f.block.CodeChanges, &pbeth.CodeChange{
Address: a.Bytes(),
OldHash: prevCodeHash.Bytes(),
OldCode: prev,
NewHash: codeHash.Bytes(),
NewCode: code,
Ordinal: f.blockOrdinal.Next(),
})
}
}