From 8bc021386f2bf30bf7c285e04e71a1f19c21862f Mon Sep 17 00:00:00 2001 From: Martin Holst Swende Date: Sat, 17 Feb 2018 14:09:19 +0100 Subject: [PATCH] signer: fix log flaw with string pointer --- cmd/signer/core/auditlog.go | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/cmd/signer/core/auditlog.go b/cmd/signer/core/auditlog.go index c5cb0ffb40..5dd0cc21ed 100644 --- a/cmd/signer/core/auditlog.go +++ b/cmd/signer/core/auditlog.go @@ -23,8 +23,8 @@ import ( "github.com/ethereum/go-ethereum/accounts" "github.com/ethereum/go-ethereum/common" "github.com/ethereum/go-ethereum/common/hexutil" - "github.com/ethereum/go-ethereum/log" "github.com/ethereum/go-ethereum/internal/ethapi" + "github.com/ethereum/go-ethereum/log" ) type AuditLogger struct { @@ -43,13 +43,18 @@ func (l *AuditLogger) New(ctx context.Context) (accounts.Account, error) { } func (l *AuditLogger) SignTransaction(ctx context.Context, args SendTxArgs, methodSelector *string) (*ethapi.SignTransactionResult, error) { + sel := "" + if methodSelector != nil { + sel = *methodSelector + } l.log.Info("SignTransaction", "type", "request", "metadata", MetadataFromContext(ctx).String(), "tx", args.String(), - "methodSelector", methodSelector) + "methodSelector", sel) + res, e := l.api.SignTransaction(ctx, args, methodSelector) - if res != nil{ + if res != nil { l.log.Info("SignTransaction", "type", "response", "data", common.Bytes2Hex(res.Raw), "error", e) - }else{ + } else { l.log.Info("SignTransaction", "type", "response", "data", res, "error", e) } return res, e