forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

p2p: improve dialTask docs

Browse source 
Also increase log level for "Can't resolve node"
This commit is contained in:
Felix Lange 2020-01-28 14:04:26 +01:00
parent 6353685608
commit 8cefa07079
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
p2p/dial.go
View file

@ -425,14 +425,15 @@ func (d *dialScheduler) startDial(task *dialTask) {
}() }()
} }
// A dialTask is generated for each node that is dialed. All fields except // A dialTask generated for each node that is dialed.
// staticPoolIndex cannot be accessed while the task is running.
type dialTask struct { type dialTask struct {
flags connFlag
dest *enode.Node
lastResolved mclock.AbsTime
resolveDelay time.Duration
staticPoolIndex int staticPoolIndex int
flags connFlag
// These fields are private to the task and should not be
// accessed by dialScheduler while the task is running.
dest *enode.Node
lastResolved mclock.AbsTime
resolveDelay time.Duration
} }
func newDialTask(dest *enode.Node, flags connFlag) *dialTask { func newDialTask(dest *enode.Node, flags connFlag) *dialTask {
@ -470,7 +471,7 @@ func (t *dialTask) run(d *dialScheduler) {
// The backoff delay resets when the node is found. // The backoff delay resets when the node is found.
func (t *dialTask) resolve(d *dialScheduler) bool { func (t *dialTask) resolve(d *dialScheduler) bool {
if d.resolver == nil { if d.resolver == nil {
d.log.Debug("Can't resolve node", "id", t.dest.ID(), "err", "discovery is disabled") d.log.Trace("Can't resolve node", "id", t.dest.ID(), "err", "discovery is disabled")
return false return false
} }
if t.resolveDelay == 0 { if t.resolveDelay == 0 {