forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-21 20:26:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/rawdb: fix resource leaks in freezer table tests

Browse source 
This commit fixes two resource leak issues in freezer_table_test.go:

1. TestFreezerRepairDanglingHead: Added missing defer f.Close() to
   ensure the freezer table is properly closed after test completion.

2. TestFreezerRepairDanglingHeadLarge: Fixed ignored error from
   newTable() call and added missing defer f.Close() to prevent
   file handle leaks.

These leaks could accumulate during test runs, potentially causing
failures due to hitting open file descriptor limits.
This commit is contained in:
inchori 2026-01-05 22:23:15 +09:00
parent de5ea2ffd8
commit 90d18d5287
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/rawdb/freezer_table_test.go
View file

@ -163,6 +163,7 @@ func TestFreezerRepairDanglingHead(t *testing.T) {
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
defer f.Close()
// The last item should be missing // The last item should be missing
if _, err = f.Retrieve(0xff); err == nil { if _, err = f.Retrieve(0xff); err == nil {
t.Errorf("Expected error for missing index entry") t.Errorf("Expected error for missing index entry")
@ -231,7 +232,11 @@ func TestFreezerRepairDanglingHeadLarge(t *testing.T) {
// And if we open it, we should now be able to read all of them (new values) // And if we open it, we should now be able to read all of them (new values)
{ {
f, _ := newTable(os.TempDir(), fname, rm, wm, sg, 50, freezerTableConfig{noSnappy: true}, false) f, err := newTable(os.TempDir(), fname, rm, wm, sg, 50, freezerTableConfig{noSnappy: true}, false)
if err != nil {
t.Fatal(err)
}
defer f.Close()
for y := 1; y < 255; y++ { for y := 1; y < 255; y++ {
exp := getChunk(15, ^y) exp := getChunk(15, ^y)
got, err := f.Retrieve(uint64(y)) got, err := f.Retrieve(uint64(y))