From 420c3ee70f2a55c2aa36f5afcbeb4de1ff8b3ac3 Mon Sep 17 00:00:00 2001 From: DavidYang <2157011+DavidYangNO1@users.noreply.github.com> Date: Thu, 24 May 2018 14:01:45 +0700 Subject: [PATCH 1/2] I think this part return nil will be better clean --- whisper/whisperv5/whisper.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/whisper/whisperv5/whisper.go b/whisper/whisperv5/whisper.go index 62bd1ce179..c6dfd80ba4 100644 --- a/whisper/whisperv5/whisper.go +++ b/whisper/whisperv5/whisper.go @@ -442,7 +442,8 @@ func (w *Whisper) Send(envelope *Envelope) error { if !ok { return fmt.Errorf("failed to add envelope") } - return err + // I think this part return nil will be better clean. + return nil } // Start implements node.Service, starting the background data propagation thread From 468fe4710438af4d5ccc6cc352c2e253307c1e52 Mon Sep 17 00:00:00 2001 From: DavidYang <2157011+DavidYangNO1@users.noreply.github.com> Date: Thu, 24 May 2018 16:09:08 +0700 Subject: [PATCH 2/2] whisperv6: I think this part return nil will be better clean. --- whisper/whisperv5/whisper.go | 1 - 1 file changed, 1 deletion(-) diff --git a/whisper/whisperv5/whisper.go b/whisper/whisperv5/whisper.go index c6dfd80ba4..7175d1c611 100644 --- a/whisper/whisperv5/whisper.go +++ b/whisper/whisperv5/whisper.go @@ -442,7 +442,6 @@ func (w *Whisper) Send(envelope *Envelope) error { if !ok { return fmt.Errorf("failed to add envelope") } - // I think this part return nil will be better clean. return nil }