forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-22 04:36:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Allways generate stack_get() call to detect stack underflow cases

Browse source
This commit is contained in:
Paweł Bylica 2015-01-13 16:05:03 +01:00
parent 7906cdd2e8
commit 92f42e98cf
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
libevmjit/BasicBlock.cpp
View file

@ -168,16 +168,13 @@ void BasicBlock::synchronizeLocalStack(Stack& _evmStack)
if (val == nullptr) if (val == nullptr)
continue; continue;
assert(llvm::isa<llvm::PHINode>(val));
llvm::PHINode* phi = llvm::cast<llvm::PHINode>(val); llvm::PHINode* phi = llvm::cast<llvm::PHINode>(val);
if (! phi->use_empty())
{
// Insert call to get() just before the PHI node and replace // Insert call to get() just before the PHI node and replace
// the uses of PHI with the uses of this new instruction. // the uses of PHI with the uses of this new instruction.
m_builder.SetInsertPoint(phi); m_builder.SetInsertPoint(phi);
auto newVal = _evmStack.get(idx); auto newVal = _evmStack.get(idx); // OPT: Value may be never user but we need to check stack heigth
// It is probably a good idea to keep heigth as a local variable accesible by LLVM directly
phi->replaceAllUsesWith(newVal); phi->replaceAllUsesWith(newVal);
}
phi->eraseFromParent(); phi->eraseFromParent();
} }