forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-16 18:00:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/txpool: improve transaction validate (#1921)

Browse source
This commit is contained in:
Daniel Liu 2026-01-16 18:15:07 +08:00 committed by GitHub
parent 86cbf4a897
commit 939225bd87
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
core/txpool/validation.go
View file

@ -93,24 +93,22 @@ func ValidateTransaction(tx *types.Transaction, head *types.Header, signer types
if tx.Nonce()+1 < tx.Nonce() { if tx.Nonce()+1 < tx.Nonce() {
return core.ErrNonceMax return core.ErrNonceMax
} }
isSpecial := tx.IsSpecialTransaction() // Skip further validation for special transactions
// Ensure the gasprice is high enough to cover the requirement of if tx.IsSpecialTransaction() {
// the calling pool and/or block producer if opts.NotSigner(from) {
if tx.GasTipCapIntCmp(opts.MinTip) < 0 {
// For special transactions, only check if the sender is not a signer
// For regular transactions, always check (to preserve old logic)
if !isSpecial || opts.NotSigner(from) {
return fmt.Errorf("%w: tip needed %v, tip permitted %v", ErrUnderpriced, opts.MinTip, tx.GasTipCap()) return fmt.Errorf("%w: tip needed %v, tip permitted %v", ErrUnderpriced, opts.MinTip, tx.GasTipCap())
} }
}
// Skip further checks for special transactions
if isSpecial {
return nil return nil
} }
// Check zero gas price. // Check zero gas price.
if tx.GasPrice().Sign() == 0 { if tx.GasPrice().Sign() == 0 {
return ErrZeroGasPrice return ErrZeroGasPrice
} }
// Ensure the gas price is high enough to cover the requirement of the calling
// pool and/or block producer
if tx.GasTipCapIntCmp(opts.MinTip) < 0 {
return fmt.Errorf("%w: tip needed %v, tip permitted %v", ErrUnderpriced, opts.MinTip, tx.GasTipCap())
}
// Ensure the transaction has more gas than the bare minimum needed to // Ensure the transaction has more gas than the bare minimum needed to
// cover the transaction metadata // cover the transaction metadata
intrGas, err := core.IntrinsicGas(tx.Data(), tx.AccessList(), tx.SetCodeAuthorizations(), tx.To() == nil, true, opts.Config.IsEIP1559(head.Number)) intrGas, err := core.IntrinsicGas(tx.Data(), tx.AccessList(), tx.SetCodeAuthorizations(), tx.To() == nil, true, opts.Config.IsEIP1559(head.Number))