forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-18 02:40:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #718 from gzliudan/fix-sa4009

Browse source 
p2p: fix staticcheck warning SA4009: overwrite function argument before first use
This commit is contained in:
Daniel Liu 2024-11-01 11:34:42 +08:00 committed by GitHub
commit 94d202edc7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
p2p/rlpx.go
View file

@ -183,7 +183,7 @@ func (t *rlpx) doEncHandshake(prv *ecdsa.PrivateKey, dial *discover.Node) (disco
if dial == nil { if dial == nil {
sec, err = receiverEncHandshake(t.fd, prv, nil) sec, err = receiverEncHandshake(t.fd, prv, nil)
} else { } else {
sec, err = initiatorEncHandshake(t.fd, prv, dial.ID, nil) sec, err = initiatorEncHandshake(t.fd, prv, dial.ID)
} }
if err != nil { if err != nil {
return discover.NodeID{}, err return discover.NodeID{}, err
@ -280,9 +280,9 @@ func (h *encHandshake) staticSharedSecret(prv *ecdsa.PrivateKey) ([]byte, error)
// it should be called on the dialing side of the connection. // it should be called on the dialing side of the connection.
// //
// prv is the local client's private key. // prv is the local client's private key.
func initiatorEncHandshake(conn io.ReadWriter, prv *ecdsa.PrivateKey, remoteID discover.NodeID, token []byte) (s secrets, err error) { func initiatorEncHandshake(conn io.ReadWriter, prv *ecdsa.PrivateKey, remoteID discover.NodeID) (s secrets, err error) {
h := &encHandshake{initiator: true, remoteID: remoteID} h := &encHandshake{initiator: true, remoteID: remoteID}
authMsg, err := h.makeAuthMsg(prv, token) authMsg, err := h.makeAuthMsg(prv)
if err != nil { if err != nil {
return s, err return s, err
} }
@ -306,7 +306,7 @@ func initiatorEncHandshake(conn io.ReadWriter, prv *ecdsa.PrivateKey, remoteID d
} }
// makeAuthMsg creates the initiator handshake message. // makeAuthMsg creates the initiator handshake message.
func (h *encHandshake) makeAuthMsg(prv *ecdsa.PrivateKey, token []byte) (*authMsgV4, error) { func (h *encHandshake) makeAuthMsg(prv *ecdsa.PrivateKey) (*authMsgV4, error) {
rpub, err := h.remoteID.Pubkey() rpub, err := h.remoteID.Pubkey()
if err != nil { if err != nil {
return nil, fmt.Errorf("bad remoteID: %v", err) return nil, fmt.Errorf("bad remoteID: %v", err)
@ -324,7 +324,7 @@ func (h *encHandshake) makeAuthMsg(prv *ecdsa.PrivateKey, token []byte) (*authMs
} }
// Sign known message: static-shared-secret ^ nonce // Sign known message: static-shared-secret ^ nonce
token, err = h.staticSharedSecret(prv) token, err := h.staticSharedSecret(prv)
if err != nil { if err != nil {
return nil, err return nil, err
} }