forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-14 12:06:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

internal/ethapi: limit number of getProofs keys (#34617)

Browse source 
We can consider making this limit configurable if ever the need arose.
This commit is contained in:
Sina M 2026-03-30 10:01:30 +02:00 committed by GitHub
parent ceabc39304
commit 95705e8b7b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
internal/ethapi/api.go
View file

@ -57,6 +57,10 @@ const estimateGasErrorRatio = 0.015
// be requested in a single eth_getStorageValues call. // be requested in a single eth_getStorageValues call.
const maxGetStorageSlots = 1024 const maxGetStorageSlots = 1024
// maxGetProofKeys is the maximum number of storage keys that can be
// requested in a single eth_getProof call.
const maxGetProofKeys = 1024
var errBlobTxNotSupported = errors.New("signing blob transactions not supported") var errBlobTxNotSupported = errors.New("signing blob transactions not supported")
var errSubClosed = errors.New("chain subscription closed") var errSubClosed = errors.New("chain subscription closed")
@ -362,6 +366,9 @@ func (n *proofList) Delete(key []byte) error {
// GetProof returns the Merkle-proof for a given account and optionally some storage keys. // GetProof returns the Merkle-proof for a given account and optionally some storage keys.
func (api *BlockChainAPI) GetProof(ctx context.Context, address common.Address, storageKeys []string, blockNrOrHash rpc.BlockNumberOrHash) (*AccountResult, error) { func (api *BlockChainAPI) GetProof(ctx context.Context, address common.Address, storageKeys []string, blockNrOrHash rpc.BlockNumberOrHash) (*AccountResult, error) {
if len(storageKeys) > maxGetProofKeys {
return nil, &invalidParamsError{fmt.Sprintf("too many storage keys requested (max %d, got %d)", maxGetProofKeys, len(storageKeys))}
}
var ( var (
keys = make([]common.Hash, len(storageKeys)) keys = make([]common.Hash, len(storageKeys))
keyLengths = make([]int, len(storageKeys)) keyLengths = make([]int, len(storageKeys))
@ -393,6 +400,9 @@ func (api *BlockChainAPI) GetProof(ctx context.Context, address common.Address,
} }
// Create the proofs for the storageKeys. // Create the proofs for the storageKeys.
for i, key := range keys { for i, key := range keys {
if err := ctx.Err(); err != nil {
return nil, err
}
// Output key encoding is a bit special: if the input was a 32-byte hash, it is // Output key encoding is a bit special: if the input was a 32-byte hash, it is
// returned as such. Otherwise, we apply the QUANTITY encoding mandated by the // returned as such. Otherwise, we apply the QUANTITY encoding mandated by the
// JSON-RPC spec for getProof. This behavior exists to preserve backwards // JSON-RPC spec for getProof. This behavior exists to preserve backwards