forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "eth: when snap is complaining for missing eth, be verbose about the details (#28249)"

Browse source 
This reverts commit 42fdae7d11.
This commit is contained in:
devopsbo3 2023-11-10 12:27:53 -06:00 committed by GitHub
parent da34ca641c
commit 96d19455c0
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
eth/handler.go
View file

@ -462,7 +462,7 @@ func (h *handler) runSnapExtension(peer *snap.Peer, handler snap.Handler) error
snap.EgressRegistrationErrorMeter.Mark(1) snap.EgressRegistrationErrorMeter.Mark(1)
} }
} }
peer.Log().Debug("Snapshot extension registration failed", "err", err) peer.Log().Warn("Snapshot extension registration failed", "err", err)
return err return err
} }
return handler(peer) return handler(peer)

3
eth/peerset.go
View file

@ -18,7 +18,6 @@ package eth
import ( import (
"errors" "errors"
"fmt"
"math/big" "math/big"
"sync" "sync"
@ -75,7 +74,7 @@ func (ps *peerSet) registerSnapExtension(peer *snap.Peer) error {
// Reject the peer if it advertises `snap` without `eth` as `snap` is only a // Reject the peer if it advertises `snap` without `eth` as `snap` is only a
// satellite protocol meaningful with the chain selection of `eth` // satellite protocol meaningful with the chain selection of `eth`
if !peer.RunningCap(eth.ProtocolName, eth.ProtocolVersions) { if !peer.RunningCap(eth.ProtocolName, eth.ProtocolVersions) {
return fmt.Errorf("%w: have %v", errSnapWithoutEth, peer.Caps()) return errSnapWithoutEth
} }
// Ensure nobody can double connect // Ensure nobody can double connect
ps.lock.Lock() ps.lock.Lock()