forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-07 23:48:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/txpool/blobpool: fix update() index corruption

Browse source 
dropStore deletes l.index[txhash] which already points to newID after
setAndIndex succeeds. Instead, inline the cleanup: delete store slot
and groups entry only, leaving the index mapping intact.

This matches the pattern used in finalize() and addLocked() replacement
path where store Delete is done without touching the index.
This commit is contained in:
Mayveskii 2026-05-11 18:46:06 +03:00 committed by cisco
parent f44892c679
commit 9726ecf630
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
core/txpool/blobpool/limbo.go
View file

@ -215,9 +215,16 @@ func (l *limbo) update(txhash common.Hash, block uint64) {
return
}
// New entry created successfully, now drop the old one.
if err := l.dropStore(oldID, item); err != nil {
// Do not use dropStore here - it deletes l.index[txhash] which
// already points to newID after setAndIndex. Only clean store
// and groups entries, leaving the index mapping intact.
if err := l.store.Delete(oldID); err != nil {
log.Error("failed to drop old limboed blob slot", "id", oldID, "err", err)
}
delete(l.groups[item.Block], oldID)
if len(l.groups[item.Block]) == 0 {
delete(l.groups, item.Block)
}
log.Trace("Blob transaction updated in limbo", "tx", txhash, "old-block", item.Block, "new-block", block)
}
@ -235,8 +242,8 @@ func (l *limbo) peek(id uint64) (*limboBlob, error) {
return item, nil
}
// dropStore deletes a blob item from the store and indices.
// Used by update to remove the old entry after successful setAndIndex.
// dropStore deletes a blob item from the store and in-memory indices.
// Used by getAndDrop/pull for full removal of a limbo entry.
func (l *limbo) dropStore(id uint64, item *limboBlob) error {
if err := l.store.Delete(id); err != nil {
return err