forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-20 19:56:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

cmd/utils: defer close in ImportHistory

Browse source
This commit is contained in:
lightclient 2026-01-30 07:06:46 -07:00
parent 2dafd06f23
commit 9755543d30
No known key found for this signature in database
GPG key ID: 657913021EF45A6A
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cmd/utils/cmd.go
View file

@ -286,8 +286,8 @@ func ImportHistory(chain *core.BlockChain, dir string, network string, from func
if err != nil { if err != nil {
return fmt.Errorf("open %s: %w", path, err) return fmt.Errorf("open %s: %w", path, err)
} }
defer f.Close()
if _, err := io.Copy(h, f); err != nil { if _, err := io.Copy(h, f); err != nil {
f.Close()
return fmt.Errorf("checksum %s: %w", path, err) return fmt.Errorf("checksum %s: %w", path, err)
} }
got := common.BytesToHash(h.Sum(scratch.Bytes()[:])).Hex() got := common.BytesToHash(h.Sum(scratch.Bytes()[:])).Hex()
@ -296,7 +296,6 @@ func ImportHistory(chain *core.BlockChain, dir string, network string, from func
scratch.Reset() scratch.Reset()
if got != want { if got != want {
f.Close()
return fmt.Errorf("%s checksum mismatch: have %s want %s", file, got, want) return fmt.Errorf("%s checksum mismatch: have %s want %s", file, got, want)
} }
// Import all block data from Era1. // Import all block data from Era1.