From 97beadd4fcd91d7db31514ab16a6a52bbcd77b8a Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Thu, 7 Sep 2017 13:20:31 +0200 Subject: [PATCH] ethdb: remove memory batch lock Batches are not safe for concurrent use. --- ethdb/memory_database.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/ethdb/memory_database.go b/ethdb/memory_database.go index d271d8889b..7f91220305 100644 --- a/ethdb/memory_database.go +++ b/ethdb/memory_database.go @@ -101,21 +101,14 @@ type kv struct{ k, v []byte } type memBatch struct { db *MemDatabase writes []kv - lock sync.RWMutex } func (b *memBatch) Put(key, value []byte) error { - b.lock.Lock() - defer b.lock.Unlock() - b.writes = append(b.writes, kv{common.CopyBytes(key), common.CopyBytes(value)}) return nil } func (b *memBatch) Write() error { - b.lock.RLock() - defer b.lock.RUnlock() - b.db.lock.Lock() defer b.db.lock.Unlock()