forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 10:22:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

swarm/storage: Add sane gc test params + test accesscnt!=indexcnt

Browse source
This commit is contained in:
lash 2018-10-04 10:36:36 +02:00
parent f726026312
commit 9886921a7e
2 changed files with 52 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
swarm/storage/ldbstore.go
View file

@ -170,6 +170,13 @@ func NewLDBStore(params *LDBStoreParams) (s *LDBStore, err error) {
return s, nil
}
func (s *LDBStore) getGCCount() uint64 {
if s.entryCnt >= maxGCItems {
return maxGCItems * gcArrayFreeRatio
}
return uint64(float64(s.entryCnt) * gcArrayFreeRatio)
}
// NewMockDbStore creates a new instance of DbStore with
// mockStore set to a provided value. If mockStore argument is nil,
// this function behaves exactly as NewDbStore.
@ -283,12 +290,7 @@ func (s *LDBStore) collectGarbage(ratio float32) {
garbage := []*gcItem{}
var gcnt uint64
var maxGcnt uint64
if s.entryCnt >= maxGCItems {
maxGcnt = maxGCItems * gcArrayFreeRatio
} else {
maxGcnt = uint64(float64(s.entryCnt) * gcArrayFreeRatio)
}
maxGcnt := s.getGCCount()
for ok := it.Seek([]byte{keyGCIdx}); ok && (gcnt < maxGcnt); ok = it.Next() {
itkey := it.Key()

45
swarm/storage/ldbstore_test.go
View file

@ -312,7 +312,6 @@ func TestLDBStoreCollectGarbage(t *testing.T) {
// TestLDBStoreCollectGarbage tests that we can put more chunks than LevelDB's capacity, and
// retrieve only some of them, because garbage collection must have cleared some of them
func testLDBStoreCollectGarbage(t *testing.T) {
params := strings.Split(t.Name(), "/")
capacity, err := strconv.Atoi(params[2])
if err != nil {
@ -483,3 +482,47 @@ func testLDBStoreRemoveThenCollectGarbage(t *testing.T) {
}
}
}
// TestLDBStoreCollectGarbageAccessUnlikeIndex tests garbage collection where accesscount differs from indexcount
func TestLDBStoreCollectGarbageAccessUnlikeIndex(t *testing.T) {
capacity := maxGCItems
n := capacity - 1
ldb, cleanup := newLDBStore(t)
ldb.setCapacity(uint64(capacity))
defer cleanup()
chunks, err := mputRandomChunks(ldb, n, int64(ch.DefaultSize))
if err != nil {
t.Fatal(err.Error())
}
log.Info("ldbstore", "entrycnt", ldb.entryCnt, "accesscnt", ldb.accessCnt)
// set first added capacity/2 chunks to highest accesscount
for i := 0; i < capacity/2; i++ {
ldb.Get(context.TODO(), chunks[i].Address())
}
_, err = mputRandomChunks(ldb, 2, int64(ch.DefaultSize))
if err != nil {
t.Fatal(err.Error())
}
// wait for garbage collection to kick in on the responsible actor
time.Sleep(1 * time.Second)
var missing int
for _, ch := range chunks[:capacity/2] {
ret, err := ldb.Get(context.Background(), ch.Address())
if err == ErrChunkNotFound || err == ldberrors.ErrNotFound {
t.Fatalf("fail find chunk %s: %v", ch.Address(), err)
}
if !bytes.Equal(ret.Data(), ch.Data()) {
t.Fatal("expected to get the same data back, but got smth else")
}
log.Trace("got back chunk", "chunk", ret)
}
log.Info("ldbstore", "total", n, "missing", missing, "entrycnt", ldb.entryCnt, "accesscnt", ldb.accessCnt)
}