From 9a905b5984e24bb1ff63a60bd1ec612cf1d2e9f6 Mon Sep 17 00:00:00 2001 From: lightclient Date: Mon, 22 Jan 2024 09:05:21 -0700 Subject: [PATCH] eth/catalyst: add comment about splitting up forkchoiceUpdated --- eth/catalyst/api.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/eth/catalyst/api.go b/eth/catalyst/api.go index e12949e346..0f0134165d 100644 --- a/eth/catalyst/api.go +++ b/eth/catalyst/api.go @@ -212,6 +212,10 @@ func (api *ConsensusAPI) ForkchoiceUpdatedV3(update engine.ForkchoiceStateV1, pa return engine.STATUS_INVALID, engine.UnsupportedFork.With(errors.New("forkchoiceUpdatedV3 must only be called for cancun payloads")) } } + // TODO(matt): the spec requires that fcu is applied when called on a valid + // hash, even if params are wrong. To do this we need to split up + // forkchoiceUpdate into a function that only updates the head and then a + // function that kicks off block construction. return api.forkchoiceUpdated(update, params) }