forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-22 12:46:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/state/snapshot: fix goroutine leak in TestGeneration

Browse source
This commit is contained in:
cjamhub 2025-11-20 18:53:44 +00:00
parent f4817b7a53
commit 9be1a00ee8
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
core/state/snapshot/generate_test.go
View file

@ -67,6 +67,16 @@ func testGeneration(t *testing.T, scheme string) {
helper.makeStorageTrie("acc-3", []string{"key-1", "key-2", "key-3"}, []string{"val-1", "val-2", "val-3"}, true) helper.makeStorageTrie("acc-3", []string{"key-1", "key-2", "key-3"}, []string{"val-1", "val-2", "val-3"}, true)
root, snap := helper.CommitAndGenerate() root, snap := helper.CommitAndGenerate()
// Ensure the generator is stopped at the end of the test
defer func() {
if snap.genAbort != nil {
stop := make(chan *generatorStats)
snap.genAbort <- stop
<-stop
}
}()
if have, want := root, common.HexToHash("0xe3712f1a226f3782caca78ca770ccc19ee000552813a9f59d479f8611db9b1fd"); have != want { if have, want := root, common.HexToHash("0xe3712f1a226f3782caca78ca770ccc19ee000552813a9f59d479f8611db9b1fd"); have != want {
t.Fatalf("have %#x want %#x", have, want) t.Fatalf("have %#x want %#x", have, want)
} }
@ -78,11 +88,6 @@ func testGeneration(t *testing.T, scheme string) {
t.Errorf("Snapshot generation failed") t.Errorf("Snapshot generation failed")
} }
checkSnapRoot(t, snap, root) checkSnapRoot(t, snap, root)
// Signal abortion to the generator and wait for it to tear down
stop := make(chan *generatorStats)
snap.genAbort <- stop
<-stop
} }
// Tests that snapshot generation with existent flat state. // Tests that snapshot generation with existent flat state.