From 9c1b90591f8947c4bb4fba56bec6a426b725e123 Mon Sep 17 00:00:00 2001 From: Will Button Date: Wed, 31 May 2023 15:37:35 -0700 Subject: [PATCH] DEVOPS-829 fix complaints from linter --- metrics/prometheus/collector.go | 5 +++++ metrics/prometheus/collector_test.go | 1 + 2 files changed, 6 insertions(+) diff --git a/metrics/prometheus/collector.go b/metrics/prometheus/collector.go index feb4c758cd..8187f4af02 100644 --- a/metrics/prometheus/collector.go +++ b/metrics/prometheus/collector.go @@ -62,12 +62,14 @@ func (c *collector) addGaugeFloat64(name string, m metrics.GaugeFloat64) { func (c *collector) addHistogram(name string, m metrics.Histogram) { pv := []float64{0.5, 0.75, 0.95, 0.99, 0.999, 0.9999} ps := m.Percentiles(pv) + var sum float64 = 0 c.buff.WriteString(fmt.Sprintf(typeSummaryTpl, mutateKey(name))) for i := range pv { c.writeSummaryPercentile(name, strconv.FormatFloat(pv[i], 'f', -1, 64), ps[i]) sum += ps[i] } + c.writeSummarySum(name, fmt.Sprintf("%f", sum)) c.writeSummaryCounter(name, len(ps)) c.buff.WriteRune('\n') @@ -98,10 +100,13 @@ func (c *collector) addResettingTimer(name string, m metrics.ResettingTimer) { c.writeSummaryPercentile(name, "0.50", ps[0]) c.writeSummaryPercentile(name, "0.95", ps[1]) c.writeSummaryPercentile(name, "0.99", ps[2]) + var sum int64 = 0 + for _, v := range val { sum += v } + c.writeSummarySum(name, fmt.Sprintf("%d", sum)) c.writeSummaryCounter(name, len(val)) c.buff.WriteRune('\n') diff --git a/metrics/prometheus/collector_test.go b/metrics/prometheus/collector_test.go index 9fc784f8c2..b1cc2aaf89 100644 --- a/metrics/prometheus/collector_test.go +++ b/metrics/prometheus/collector_test.go @@ -99,6 +99,7 @@ test_resetting_timer_sum 180000000 test_resetting_timer_count 6 ` + c.addResettingTimer("test/empty_resetting_timer", emptyResettingTimer) exp := c.buff.String()