From 5a2a3eeacc8cd478a3ee48b04f3e029a7eaf5e2e Mon Sep 17 00:00:00 2001 From: Joshua <62268199+minimalsm@users.noreply.github.com> Date: Thu, 1 Dec 2022 18:30:56 +0000 Subject: [PATCH 01/18] Fix typo (#101) --- docs/faq.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/faq.md b/docs/faq.md index d8c2d7a1d0..af2a98e339 100644 --- a/docs/faq.md +++ b/docs/faq.md @@ -5,7 +5,7 @@ description: Frequently asked questions related to Geth ## Where can I get more information? {#where-can-i-get-more-information} -This page contains answers to common questions about Geth. Source code and README documentation can be found on the Geth [GitHub](https://github.com/ethereum/go-ethereum). You can also ask questions on Geth's [Discord channel](https://discord.gg/WHNkYDsAKU) or keep up to date with Geth on [Twitter](https://twitter.com/go_ethereum). Information about Ethereum in general can be found at [ethereum.org](https://ethereum.org). +This page contains answers to common questions about Geth. Source code and README documentation can be found on the Geth [GitHub](https://github.com/ethereum/go-ethereum). You can also ask questions on Geth's [Discord server](https://discord.gg/WHNkYDsAKU) or keep up to date with Geth on [Twitter](https://twitter.com/go_ethereum). Information about Ethereum in general can be found at [ethereum.org](https://ethereum.org). The Geth team have also recently started to run AMA's on Reddit: From f2ae1511e5999718583ed1b4fde797f526cca44c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Quiroz?= Date: Thu, 1 Dec 2022 16:46:42 -0300 Subject: [PATCH 02/18] fix: downloads page borders & margins --- src/components/UI/downloads/DownloadsHero.tsx | 4 ++-- src/pages/downloads.tsx | 10 +++++++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/components/UI/downloads/DownloadsHero.tsx b/src/components/UI/downloads/DownloadsHero.tsx index 8a00452cc2..3792864f71 100644 --- a/src/components/UI/downloads/DownloadsHero.tsx +++ b/src/components/UI/downloads/DownloadsHero.tsx @@ -1,4 +1,4 @@ -import { Box, Button, Center, Grid, HStack, Image, Link, Stack, Text } from '@chakra-ui/react'; +import { Box, Button, Center, Grid, HStack, Link, Stack, Text } from '@chakra-ui/react'; import { FC } from 'react'; import NextLink from 'next/link'; @@ -32,7 +32,7 @@ export const DownloadsHero: FC = ({ return ( = ({ data }) => { borderColor='primary' gap={4} flexDirection={{ base: 'column', md: 'row' }} + alignItems='center' > @@ -512,7 +513,7 @@ const DownloadsPage: NextPage = ({ data }) => { - + gpg --recv-keys F9585DE6 C2FF8BBF 9BA28146 7B9E2481 D2A67EAC @@ -525,6 +526,8 @@ const DownloadsPage: NextPage = ({ data }) => { borderColor='primary' gap={4} flexDirection={{ base: 'column', md: 'row' }} + alignItems='center' + sx={{ mt: '0 !important' }} > @@ -533,7 +536,7 @@ const DownloadsPage: NextPage = ({ data }) => { - + gpg --recv-keys E058A81C 05A5DDF0 1CCB7DD2 @@ -542,10 +545,11 @@ const DownloadsPage: NextPage = ({ data }) => { From 123b299345e3274fdcd7696d7e54b06f7b14a2bf Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Fri, 2 Dec 2022 15:32:30 +0100 Subject: [PATCH 03/18] prevent Header title from wrapping [Fixes #79] (#111) --- src/components/UI/Header.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/UI/Header.tsx b/src/components/UI/Header.tsx index 7ad993fd0e..18cac9ca19 100644 --- a/src/components/UI/Header.tsx +++ b/src/components/UI/Header.tsx @@ -29,7 +29,7 @@ export const Header: FC = () => { > - go-ethereum + go-ethereum From 50bfc2053a4e019b8016ff13c797ba5ffa1607dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Quiroz?= Date: Fri, 2 Dec 2022 13:18:00 -0300 Subject: [PATCH 04/18] fix: show 2 latest releases for linux --- src/components/UI/downloads/DownloadsTable.tsx | 4 +++- src/constants.ts | 2 +- src/pages/downloads.tsx | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/components/UI/downloads/DownloadsTable.tsx b/src/components/UI/downloads/DownloadsTable.tsx index d77789f73f..7b3263313c 100644 --- a/src/components/UI/downloads/DownloadsTable.tsx +++ b/src/components/UI/downloads/DownloadsTable.tsx @@ -33,6 +33,8 @@ export const DownloadsTable: FC = ({ androidData.length ]; + const LAST_2_LINUX_RELEASES = amountOfReleasesToShow + 12; + return ( setTotalReleases(totalReleases[idx])}> @@ -61,7 +63,7 @@ export const DownloadsTable: FC = ({ diff --git a/src/constants.ts b/src/constants.ts index 3e282e0b85..58c0354042 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -20,7 +20,7 @@ export const GETH_DISCORD_URL = 'https://discord.com/invite/nthXNEv'; export const GO_URL = 'https://go.dev/'; // Downloads -export const DEFAULT_BUILD_AMOUNT_TO_SHOW = 10; +export const DEFAULT_BUILD_AMOUNT_TO_SHOW = 12; export const DOWNLOAD_HEADER_BUTTONS: { [index: string]: { name: string; diff --git a/src/pages/downloads.tsx b/src/pages/downloads.tsx index 3afa2c6005..c955085a13 100644 --- a/src/pages/downloads.tsx +++ b/src/pages/downloads.tsx @@ -287,11 +287,11 @@ const DownloadsPage: NextPage = ({ data }) => { const [totalDevBuilds, setTotalDevBuilds] = useState(ALL_LINUX_DEV_BUILDS.length); const showMoreStableReleases = () => { - setAmountStableReleases(amountStableReleases + 10); + setAmountStableReleases(amountStableReleases + 12); }; const showMoreDevBuilds = () => { - setAmountDevBuilds(amountDevBuilds + 10); + setAmountDevBuilds(amountDevBuilds + 12); }; return ( From a1ff1fe755811b32f051600e50e2de70ea7b3430 Mon Sep 17 00:00:00 2001 From: Avi Thour Date: Fri, 2 Dec 2022 21:49:09 +0530 Subject: [PATCH 05/18] Extracted the style objects and props into variable Extracted the common style objects and props into variables or constants to avoid repeating the same code and make the code easier to read. Instead of repeating the same _hover styles in multiple places, I created a hoverStyles object and used it in each Link component. --- src/components/layouts/Footer.tsx | 30 +++++++++++------------------- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/src/components/layouts/Footer.tsx b/src/components/layouts/Footer.tsx index 14db5fddfe..cd9802ca11 100644 --- a/src/components/layouts/Footer.tsx +++ b/src/components/layouts/Footer.tsx @@ -12,6 +12,12 @@ import { import { DiscordIcon, GitHubIcon, TwitterIcon } from '../UI/icons'; +const hoverStyles = { + textDecoration: 'none', + bg: 'primary', + color: 'bg !important' +}; + export const Footer: FC = () => { return ( @@ -32,11 +38,7 @@ export const Footer: FC = () => {
{
{ lg: 'none' }} borderColor='primary !important' - _hover={{ - bg: 'primary' - }} + _hover={hoverStyles} p={4} > @@ -96,9 +92,7 @@ export const Footer: FC = () => {
{
From 367e7c6e03c216e5912d140a707cc3fcef87e5dc Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Fri, 2 Dec 2022 17:56:44 +0100 Subject: [PATCH 06/18] remove any margin on first MD item (#109) [Fixes #75, issue when articles start with an H2 had extra margin between the H1 section and the starting H2. --- src/pages/[...slug].tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/[...slug].tsx b/src/pages/[...slug].tsx index f16e3fa1dc..9119adae5a 100644 --- a/src/pages/[...slug].tsx +++ b/src/pages/[...slug].tsx @@ -116,7 +116,7 @@ const DocPage: NextPage = ({ frontmatter, content, navLinks, lastModified - + Date: Fri, 2 Dec 2022 18:58:46 +0100 Subject: [PATCH 07/18] fix broken links (#103) --- docs/fundamentals/peer-to-peer.md | 2 +- docs/getting-started/index.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/fundamentals/peer-to-peer.md b/docs/fundamentals/peer-to-peer.md index 7784007454..28c71225eb 100644 --- a/docs/fundamentals/peer-to-peer.md +++ b/docs/fundamentals/peer-to-peer.md @@ -3,7 +3,7 @@ title: Connecting To The Network description: Guide to connecting Geth to a peer-to-peer network --- -The default behaviour for Geth is to connect to Ethereum Mainnet. However, Geth can also connect to public testnets, [private networks](/docs/developers/geth-developer/private-network.md) and [local testnets](/docs/developers/geth-developer/dev-mode). For convenience, the two public testnets with long term support, Goerli and Sepolia, have their own command line flag. Geth can connect to these testnets simpyl by passing: +The default behaviour for Geth is to connect to Ethereum Mainnet. However, Geth can also connect to public testnets, [private networks](/docs/developers/geth-developer/private-network) and [local testnets](/docs/developers/geth-developer/dev-mode). For convenience, the two public testnets with long term support, Goerli and Sepolia, have their own command line flag. Geth can connect to these testnets simpyl by passing: - `--goerli`, Goerli proof-of-authority test network - `--sepolia` Sepolia proof-of-work test network diff --git a/docs/getting-started/index.md b/docs/getting-started/index.md index 74a0d1c04b..a046f5f16b 100644 --- a/docs/getting-started/index.md +++ b/docs/getting-started/index.md @@ -5,7 +5,7 @@ description: Guide to getting up and running with Geth using Clef. This page explains how to set up Geth and execute some basic tasks using the command line tools. In order to use Geth, the software must first be installed. There are several ways Geth can be installed depending on the operating system and the user's choice of installation method, for example using a package manager, container or building from source. Instructions for installing Geth can be found on the ["Install and Build"](/docs/getting_started/Installing-Geth) pages. -Geth also needs to be connected to a [consensus client](docs/getting-started/consensus-clients.md) in order to function as an Ethereum node. The tutorial on this page assumes Geth and a consensus client have been installed successfully and that a firewall has been configured to block external traffic to the JSON-RPC port `8545` see [Security](/docs/fundamentals/security). +Geth also needs to be connected to a [consensus client](docs/getting-started/consensus-clients) in order to function as an Ethereum node. The tutorial on this page assumes Geth and a consensus client have been installed successfully and that a firewall has been configured to block external traffic to the JSON-RPC port `8545` see [Security](/docs/fundamentals/security). This page provides step-by-step instructions covering the fundamentals of using Geth. This includes generating accounts, joining an Ethereum network, syncing the blockchain and sending ether between accounts. This tutorial uses [Clef](/docs/tools/Clef/Tutorial). Clef is an account management tool external to Geth itself that allows users to sign transactions. It is developed and maintained by the Geth team. @@ -33,7 +33,7 @@ Read more about Ethereum accounts [here](https://ethereum.org/en/developers/docs ## Step 1: Generating accounts {#generating-accounts} -There are several methods for generating accounts in Geth. This tutorial demonstrates how to generate accounts using Clef, as this is considered best practice, largely because it decouples the users' key management from Geth, making it more modular and flexible. It can also be run from secure USB sticks or virtual machines, offering security benefits. For convenience, this tutorial will execute Clef on the same computer that will also run Geth, although more secure options are available (see [here](https://github.com/ethereum/go-ethereum/blob/master/cmd/clef/docs/setup.md)). +There are several methods for generating accounts in Geth. This tutorial demonstrates how to generate accounts using Clef, as this is considered best practice, largely because it decouples the users' key management from Geth, making it more modular and flexible. It can also be run from secure USB sticks or virtual machines, offering security benefits. For convenience, this tutorial will execute Clef on the same computer that will also run Geth, although more secure options are available (see [here](/docs/tools/clef/setup)). An account is a pair of keys (public and private). Clef needs to know where to save these keys to so that they can be retrieved later. This information is passed to Clef as an argument. This is achieved using the following command: @@ -121,7 +121,7 @@ geth --sepolia --datadir geth-tutorial --authrpc.addr localhost --authrpc.port 8 Running the above command starts Geth. Geth will not sync the blockchain correctly unless there is also a consensus client that can pass Geth a valid head to sync up to. In a separate terminal, start a consensus client. Once the consensus client gets in sync, Geth will start to sync too. -The terminal should rapidly fill with status updates that look similar to those below. To check the meaning of the logs, refer to the [logs page](docs/fundamentals/logs.md). +The terminal should rapidly fill with status updates that look similar to those below. To check the meaning of the logs, refer to the [logs page](/docs/fundamentals/logs). ```terminal INFO [02-10|13:59:06.649] Starting Geth on sepolia testnet... From 3a2a4b1cbf71f35a1a1213251158fe44da13ab9f Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Fri, 2 Dec 2022 19:07:58 +0100 Subject: [PATCH 08/18] patch responsive width [Fixes #53] (#104) --- src/components/layouts/Layout.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/layouts/Layout.tsx b/src/components/layouts/Layout.tsx index 46e8bed8ab..16a3534084 100644 --- a/src/components/layouts/Layout.tsx +++ b/src/components/layouts/Layout.tsx @@ -12,7 +12,7 @@ interface Props { export const Layout: FC = ({ children }) => { return ( - +
{children} From 2ae56986224005dba1b75bc152e6404e32798107 Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Mon, 5 Dec 2022 16:13:47 +0100 Subject: [PATCH 09/18] Stylize active docs link [Fixes #74, Fixes #115] (#108) * add bold for active docs link [Fixes #74] * Add ::before indicator to active doc link Removes bold styling per design * Update documentation-links.yaml Makes it so `id` is paired with either a `to` field OR a list of `items` but not both * Updates hover styling for left docs nav * clean up styling Removes remaining underlines from links styled as buttons. Cleans up logic for conditionally showing the ::before pseudo element. Makes the ::before indicator slightly larger. * tweak ::before indicator styling * tweak ::before indicator styling --- src/components/UI/docs/DocsLinks.tsx | 132 ++++++++++++++++----------- src/components/UI/docs/LinkList.tsx | 72 ++++++++++----- src/data/documentation-links.yaml | 15 ++- 3 files changed, 134 insertions(+), 85 deletions(-) diff --git a/src/components/UI/docs/DocsLinks.tsx b/src/components/UI/docs/DocsLinks.tsx index 14beb534ed..6350316399 100644 --- a/src/components/UI/docs/DocsLinks.tsx +++ b/src/components/UI/docs/DocsLinks.tsx @@ -11,6 +11,7 @@ import { } from '@chakra-ui/react'; import { AddIcon, MinusIcon } from '@chakra-ui/icons'; import NextLink from 'next/link'; +import { useRouter } from 'next/router'; import { LinksList } from './'; @@ -20,62 +21,83 @@ interface Props { navLinks: NavLink[]; } -export const DocsLinks: FC = ({ navLinks }) => ( - - {navLinks.map(({ id, to, items }, idx) => { - return ( - - - {({ isExpanded }) => ( - <> - - = ({ navLinks }) => { + const router = useRouter(); + const { slug } = router.query; + return ( + + {navLinks.map(({ id, to, items }, idx) => { + const split = to?.split('/') + const isActive = slug && split && split[split.length - 1] === slug[slug.length - 1]; + return ( + + + {({ isExpanded }) => ( + <> + - {to ? ( - - - {id} - - - ) : ( - {id} - )} - - - {items && ( - -
- {isExpanded ? ( - - ) : ( - - )} -
+ + {to ? ( + + + + {id} + + + + ) : ( + {id} + )} + + {items && ( + +
+ {isExpanded ? ( + + ) : ( + + )} +
+ + )} + + {items && ( + + + )} - - {items && ( - - - - )} - - )} - - - ); - })} - -); + + )} + + + ); + })} + + ); +} diff --git a/src/components/UI/docs/LinkList.tsx b/src/components/UI/docs/LinkList.tsx index d8c84c72d5..9b121c6f79 100644 --- a/src/components/UI/docs/LinkList.tsx +++ b/src/components/UI/docs/LinkList.tsx @@ -1,6 +1,7 @@ import { FC } from 'react'; import { Link, Stack, Text } from '@chakra-ui/react'; import NextLink from 'next/link'; +import { useRouter } from 'next/router'; import { NavLink } from '../../../types'; @@ -8,28 +9,49 @@ interface LinksListProps { links: NavLink[]; } -export const LinksList: FC = ({ links }) => ( - - {links.map(({ id, to, items }) => { - return to ? ( - - - - - {id} - - - - {items && } - - ) : ( - - - {id} - - {items && } - - ); - })} - -); +export const LinksList: FC = ({ links }) => { + const router = useRouter(); + const { slug } = router.query; + return ( + + {links.map(({ id, to, items }) => { + const split = to?.split('/') + const isActive = slug && split && split[split.length - 1] === slug[slug.length - 1]; + return to ? ( + + + + + {id} + + + + {items && } + + ) : ( + + + {id} + + {items && } + + ); + })} + + ); +}; diff --git a/src/data/documentation-links.yaml b/src/data/documentation-links.yaml index 137b4574d2..f889d4cc6f 100644 --- a/src/data/documentation-links.yaml +++ b/src/data/documentation-links.yaml @@ -1,6 +1,7 @@ - id: Getting started - to: /docs/getting-started items: + - id: Introduction + to: /docs/getting-started - id: Hardware requirements to: /docs/getting-started/hardware-requirements - id: Installing Geth @@ -8,8 +9,9 @@ - id: Consensus clients to: /docs/getting-started/consensus-clients - id: Fundamentals - to: /docs/fundamentals items: + - id: Introduction + to: /docs/fundamentals - id: Node architecture to: /docs/fundamentals/node-architecture - id: Command-line options @@ -35,8 +37,9 @@ - id: Interacting with Geth items: - id: JSON-RPC Server - to: /docs/interacting-with-geth/rpc items: + - id: Introduction + to: /docs/interacting-with-geth/rpc - id: Batch requests to: /docs/interacting-with-geth/rpc/batch - id: GraphQL server @@ -70,8 +73,9 @@ - id: 'JavaScript Console 2: Contracts' to: /docs/interacting-with-geth/javascript-console-contracts - id: Developers - to: /docs/developers items: + - id: Introduction + to: /docs/developers - id: Dapp developers items: - id: Go API @@ -83,8 +87,9 @@ - id: Geth for Mobile to: /docs/developers/dapp-developer/mobile - id: EVM tracing - to: /docs/developers/evm-tracing items: + - id: Introduction + to: /docs/developers/evm-tracing - id: Basic traces to: /docs/developers/evm-tracing/basic-traces - id: Built-in tracers From 0bddab847d6e0e5fb61dc051321cc6c90c58ad61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Quiroz?= Date: Mon, 5 Dec 2022 13:28:34 -0300 Subject: [PATCH 10/18] fix: Show older releases button width on mobile (#125) --- src/pages/downloads.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pages/downloads.tsx b/src/pages/downloads.tsx index 7be72330b9..8628b05360 100644 --- a/src/pages/downloads.tsx +++ b/src/pages/downloads.tsx @@ -393,6 +393,7 @@ const DownloadsPage: NextPage = ({ data }) => { = ({ data }) => { Date: Mon, 5 Dec 2022 17:31:39 +0100 Subject: [PATCH 11/18] Icon line weight patch [Fixes #70] (#105) * add custom AddIcon and MinusIcon svgs * switch DocsLinks to use custom +/- svgs * fix size of +/- svgs --- src/components/UI/docs/DocsLinks.tsx | 6 +++--- src/components/UI/svgs/AddIcon.tsx | 21 +++++++++++++++++++++ src/components/UI/svgs/MinusIcon.tsx | 20 ++++++++++++++++++++ src/components/UI/svgs/index.ts | 2 ++ 4 files changed, 46 insertions(+), 3 deletions(-) create mode 100644 src/components/UI/svgs/AddIcon.tsx create mode 100644 src/components/UI/svgs/MinusIcon.tsx diff --git a/src/components/UI/docs/DocsLinks.tsx b/src/components/UI/docs/DocsLinks.tsx index 6350316399..ab77e803ae 100644 --- a/src/components/UI/docs/DocsLinks.tsx +++ b/src/components/UI/docs/DocsLinks.tsx @@ -9,7 +9,7 @@ import { Stack, Text } from '@chakra-ui/react'; -import { AddIcon, MinusIcon } from '@chakra-ui/icons'; +import { AddIcon, MinusIcon } from '../svgs/' import NextLink from 'next/link'; import { useRouter } from 'next/router'; @@ -79,9 +79,9 @@ export const DocsLinks: FC = ({ navLinks }) => {
{isExpanded ? ( - + ) : ( - + )}
diff --git a/src/components/UI/svgs/AddIcon.tsx b/src/components/UI/svgs/AddIcon.tsx new file mode 100644 index 0000000000..fe8f3016c9 --- /dev/null +++ b/src/components/UI/svgs/AddIcon.tsx @@ -0,0 +1,21 @@ +import { IconProps } from '@chakra-ui/react'; +import { createIcon } from '@chakra-ui/icons'; + +const [w, h] = [24, 24]; + +const Icon = createIcon({ + displayName: 'AddIcon', + viewBox: `0 0 ${w} ${h}`, + path: ( + + + + + + + ) +}); + +export const AddIcon: React.FC = props => ( + +); diff --git a/src/components/UI/svgs/MinusIcon.tsx b/src/components/UI/svgs/MinusIcon.tsx new file mode 100644 index 0000000000..689f611370 --- /dev/null +++ b/src/components/UI/svgs/MinusIcon.tsx @@ -0,0 +1,20 @@ +import { IconProps } from '@chakra-ui/react'; +import { createIcon } from '@chakra-ui/icons'; + +const [w, h] = [24, 24]; + +const Icon = createIcon({ + displayName: 'MinusIcon', + viewBox: `0 0 ${w} ${h}`, + path: ( + + + + + + ) +}); + +export const MinusIcon: React.FC = props => ( + +); diff --git a/src/components/UI/svgs/index.ts b/src/components/UI/svgs/index.ts index c1a85f7e2c..91312334c8 100644 --- a/src/components/UI/svgs/index.ts +++ b/src/components/UI/svgs/index.ts @@ -1,5 +1,7 @@ +export * from './AddIcon'; export * from './GlyphHome'; export * from './GopherDownloads'; export * from './GopherHomeFront'; export * from './GopherHomeLinks'; export * from './GopherHomeNodes'; +export * from './MinusIcon'; From 1f90789712163ec8cfff0797a9d0172767a3f3a2 Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Mon, 5 Dec 2022 17:37:44 +0100 Subject: [PATCH 12/18] Link section padding [Fixes #71] (#106) * rename to LinksList * add padding after sections in LinksList * reduce padding between sections to 1.5rem --- src/components/UI/docs/{LinkList.tsx => LinksList.tsx} | 4 ++-- src/components/UI/docs/index.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) rename src/components/UI/docs/{LinkList.tsx => LinksList.tsx} (92%) diff --git a/src/components/UI/docs/LinkList.tsx b/src/components/UI/docs/LinksList.tsx similarity index 92% rename from src/components/UI/docs/LinkList.tsx rename to src/components/UI/docs/LinksList.tsx index 9b121c6f79..6c9d838e1d 100644 --- a/src/components/UI/docs/LinkList.tsx +++ b/src/components/UI/docs/LinksList.tsx @@ -18,7 +18,7 @@ export const LinksList: FC = ({ links }) => { const split = to?.split('/') const isActive = slug && split && split[split.length - 1] === slug[slug.length - 1]; return to ? ( - + = ({ links }) => { {items && } ) : ( - + {id} diff --git a/src/components/UI/docs/index.ts b/src/components/UI/docs/index.ts index 9214774f4c..56eadcff2b 100644 --- a/src/components/UI/docs/index.ts +++ b/src/components/UI/docs/index.ts @@ -3,6 +3,6 @@ export * from './Code'; export * from './DocsLinks'; export * from './DocsNav'; export * from './DocumentNav'; -export * from './LinkList'; +export * from './LinksList'; export * from './Note'; export { default } from './MDComponents'; From e25b87f32d9ca35a8e509848ca905ffaf2f2c7b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Quiroz?= Date: Mon, 5 Dec 2022 13:39:12 -0300 Subject: [PATCH 13/18] fix: remove Showing... count message (#118) * fix: remove Showing... count message * Update src/pages/downloads.tsx Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> * Update src/pages/downloads.tsx Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> --- src/pages/downloads.tsx | 31 ++++--------------------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/src/pages/downloads.tsx b/src/pages/downloads.tsx index 8628b05360..c521e6ea1d 100644 --- a/src/pages/downloads.tsx +++ b/src/pages/downloads.tsx @@ -374,26 +374,13 @@ const DownloadsPage: NextPage = ({ data }) => { - - - {totalStableReleases > 0 - ? `Showing ${Math.min( - amountStableReleases, - totalStableReleases - )} latest releases of - a total ${totalStableReleases} releases` - : `No releases`} - - - {totalStableReleases > amountStableReleases && ( = ({ data }) => { - - - {totalDevBuilds > 0 - ? `Showing ${Math.min(amountDevBuilds, totalDevBuilds)} latest releases of - a total ${totalDevBuilds} releases` - : `No releases`} - - - {totalDevBuilds > amountDevBuilds && ( Date: Mon, 5 Dec 2022 13:42:09 -0300 Subject: [PATCH 14/18] hotfix: button width --- src/pages/downloads.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pages/downloads.tsx b/src/pages/downloads.tsx index c521e6ea1d..00c0e0a288 100644 --- a/src/pages/downloads.tsx +++ b/src/pages/downloads.tsx @@ -381,6 +381,7 @@ const DownloadsPage: NextPage = ({ data }) => { = ({ data }) => { Date: Mon, 5 Dec 2022 17:54:38 +0100 Subject: [PATCH 15/18] xs font size for os label on mobile [Fixes #94] (#123) --- src/theme/foundations/textStyles.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/theme/foundations/textStyles.ts b/src/theme/foundations/textStyles.ts index df2c9e9d70..4ce02a0caa 100644 --- a/src/theme/foundations/textStyles.ts +++ b/src/theme/foundations/textStyles.ts @@ -137,7 +137,7 @@ export const textStyles = { fontWeight: 700, textTransform: 'uppercase', textAlign: 'center', - fontSize: 'sm' + fontSize: { base: 'xs', sm: 'sm' } }, 'docs-nav-dropdown': { fontFamily: 'heading', From 94cb14b9785a3de5f91f798e484e0d2cd6950866 Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Mon, 5 Dec 2022 18:13:26 +0100 Subject: [PATCH 16/18] Add gap between md content and right nav [Fixes #77] (#110) * add gap between md content and right nav * shorten max width of right nav divider * make DocumentNav width responsive Existing fixed width was too large after the 2rem of padding was added. Simply making it more narrow made it unnecessarily small on larger screen sizes. Clamp sets a min of chakra-size-40, max of chakra-size-58, while targeting an eighth of the screen width. --- src/pages/[...slug].tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/[...slug].tsx b/src/pages/[...slug].tsx index 9119adae5a..db92232ee2 100644 --- a/src/pages/[...slug].tsx +++ b/src/pages/[...slug].tsx @@ -115,7 +115,7 @@ const DocPage: NextPage = ({ frontmatter, content, navLinks, lastModified - + = ({ frontmatter, content, navLinks, lastModified - + From 26673626d23a34d8e70931a8efa4d32f72320ebd Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Mon, 5 Dec 2022 21:17:11 +0100 Subject: [PATCH 17/18] Remove color style for list items, and change first-child to first-of-type based on console error for SSR (#127) --- src/components/UI/docs/MDComponents.tsx | 2 +- src/pages/[...slug].tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/UI/docs/MDComponents.tsx b/src/components/UI/docs/MDComponents.tsx index 09f8b2b71f..ff1217b126 100644 --- a/src/components/UI/docs/MDComponents.tsx +++ b/src/components/UI/docs/MDComponents.tsx @@ -143,7 +143,7 @@ const MDComponents = { ); }, li: ({ children }: any) => { - return {children}; + return {children}; }, note: ({ children }: any) => { return {children}; diff --git a/src/pages/[...slug].tsx b/src/pages/[...slug].tsx index db92232ee2..3c5166e91b 100644 --- a/src/pages/[...slug].tsx +++ b/src/pages/[...slug].tsx @@ -116,7 +116,7 @@ const DocPage: NextPage = ({ frontmatter, content, navLinks, lastModified - + Date: Tue, 6 Dec 2022 01:40:07 +0100 Subject: [PATCH 18/18] Adjust link styling for various states [Fixes #89] (#129) * fix: link styling for various states updates hover/active/focus link states to match design system * hover underline color to secondary --- src/theme/components/Link.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/theme/components/Link.ts b/src/theme/components/Link.ts index ca8aaf93c1..0c09c4ecc7 100644 --- a/src/theme/components/Link.ts +++ b/src/theme/components/Link.ts @@ -15,13 +15,13 @@ export const Link = { light: { textDecoration: 'underline', color: 'primary', - _hover: { color: 'body', textDecorationColor: 'body' }, + _hover: { color: 'body', textDecorationColor: 'secondary' }, _focus: { color: 'primary', - boxShadow: '0 0 0 1px var(--chakra-colors-primary)', + boxShadow: '0 0 0 1px var(--chakra-colors-primary) !important', textDecoration: 'none' }, - _pressed: { + _active: { color: 'secondary', textDecorationColor: 'secondary' }