forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-18 18:02:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core: lift convenience warming of tx destination from per auth to post application of all authorizations

Browse source
This commit is contained in:
lightclient 2024-12-05 18:00:12 -05:00
parent 9b94402a9e
commit 9ee0d10421
No known key found for this signature in database
GPG key ID: 75C916AFEE20183E
2 changed files with 11 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/state/statedb.go
View file

@ -1343,10 +1343,6 @@ func (s *StateDB) Prepare(rules params.Rules, sender, coinbase common.Address, d
al.AddAddress(sender) al.AddAddress(sender)
if dst != nil { if dst != nil {
al.AddAddress(*dst) al.AddAddress(*dst)
// If the dst has a delegation, also warm its target.
if addr, ok := types.ParseDelegation(s.GetCode(*dst)); ok {
al.AddAddress(addr)
}
// If it's a create-tx, the destination will be added inside evm.create // If it's a create-tx, the destination will be added inside evm.create
} }
for _, addr := range precompiles { for _, addr := range precompiles {

21
core/state_transition.go
View file

@ -479,6 +479,17 @@ func (st *stateTransition) execute() (*ExecutionResult, error) {
} }
} }
if !contractCreation {
if addr, ok := types.ParseDelegation(st.state.GetCode(*msg.To)); ok {
// Perform convenience warming of sender's delegation target. Although the
// sender is already warmed in Prepare(..), it's possible a delegation to
// the account was deployed during this transaction. To handle correctly,
// wait until the final state of delegations is determined before
// performing the resolution and warming.
st.state.AddAddressToAccessList(addr)
}
}
var ( var (
ret []byte ret []byte
vmerr error // vm errors do not effect consensus and are therefore not assigned to err vmerr error // vm errors do not effect consensus and are therefore not assigned to err
@ -585,16 +596,6 @@ func (st *stateTransition) applyAuthorization(msg *Message, auth *types.Authoriz
// Otherwise install delegation to auth.Address. // Otherwise install delegation to auth.Address.
st.state.SetCode(authority, types.AddressToDelegation(auth.Address)) st.state.SetCode(authority, types.AddressToDelegation(auth.Address))
// If an account has a code delegation to another account, that account will be added to
// the access list in statedb.Prepare(..).
//
// However if the destination address of the transaction (msg) gains a new delegation
// in this same transaction, we need to explicitly warm the delegation address here,
// since Prepare has already happened. The intention here is to behave as if the
// delegation was already present before calling Prepare.
if *msg.To == authority {
st.state.AddAddressToAccessList(auth.Address)
}
return nil return nil
} }