From a132830195df2de264d16cb8ff20ab0ea721de66 Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Sun, 9 Feb 2020 17:45:11 +0100 Subject: [PATCH] p2p: document that RemovePeer blocks --- p2p/server.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/p2p/server.go b/p2p/server.go index dd15746e2f..1ed1be2ac6 100644 --- a/p2p/server.go +++ b/p2p/server.go @@ -326,6 +326,9 @@ func (srv *Server) AddPeer(node *enode.Node) { // RemovePeer removes a node from the static node set. It also disconnects from the given // node if it is currently connected as a peer. +// +// This method blocks until all protocols have exited and the peer is removed. Do not use +// RemovePeer in protocol implementations, call Disconnect on the Peer instead. func (srv *Server) RemovePeer(node *enode.Node) { var ( ch chan *PeerEvent