From a134b1835a5b382d91ae66d6360e959edb5a261d Mon Sep 17 00:00:00 2001 From: Sina Mahmoodi Date: Fri, 6 Feb 2026 20:51:30 +0100 Subject: [PATCH] fix export history for windows --- cmd/utils/cmd.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/cmd/utils/cmd.go b/cmd/utils/cmd.go index b5dd293e45..995724e6fc 100644 --- a/cmd/utils/cmd.go +++ b/cmd/utils/cmd.go @@ -497,11 +497,6 @@ func ExportHistory(bc *core.BlockChain, dir string, first, last uint64, newBuild if err != nil { return err } - final := filepath.Join(dir, filename(network, idx, id)) - if err := os.Rename(tmpPath, final); err != nil { - return err - } - if _, err := f.Seek(0, io.SeekStart); err != nil { return err } @@ -511,7 +506,11 @@ func ExportHistory(bc *core.BlockChain, dir string, first, last uint64, newBuild return err } checksums = append(checksums, common.BytesToHash(h.Sum(buf.Bytes()[:])).Hex()) - return nil + + // Close before rename. It's required on Windows. + f.Close() + final := filepath.Join(dir, filename(network, idx, id)) + return os.Rename(tmpPath, final) }(); err != nil { return err }