forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-09 22:44:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

all: fix staticcheck warning SA4010: append result never used

Browse source
This commit is contained in:
Daniel Liu 2024-10-29 09:16:23 +08:00
parent 6dbf0d26e9
commit a14e9416fa
3 changed files with 7 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
XDCxlending/lendingstate/statedb_test.go
View file

@ -18,10 +18,11 @@ package lendingstate
import ( import (
"fmt" "fmt"
"github.com/XinFinOrg/XDPoSChain/common"
"github.com/XinFinOrg/XDPoSChain/core/rawdb"
"math/big" "math/big"
"testing" "testing"
"github.com/XinFinOrg/XDPoSChain/common"
"github.com/XinFinOrg/XDPoSChain/core/rawdb"
) )
func TestEchangeStates(t *testing.T) { func TestEchangeStates(t *testing.T) {
@ -225,9 +226,7 @@ func TestDumpStates(t *testing.T) {
orderBook := common.StringToHash("BTC/XDC") orderBook := common.StringToHash("BTC/XDC")
numberOrder := 20 numberOrder := 20
orderItems := []LendingItem{} orderItems := []LendingItem{}
relayers := []common.Hash{}
for i := 0; i < numberOrder; i++ { for i := 0; i < numberOrder; i++ {
relayers = append(relayers, common.BigToHash(big.NewInt(int64(i))))
id := new(big.Int).SetUint64(uint64(i) + 1) id := new(big.Int).SetUint64(uint64(i) + 1)
orderItems = append(orderItems, LendingItem{LendingId: id.Uint64(), Quantity: big.NewInt(int64(2*i + 1)), Interest: big.NewInt(1), Side: Investing, Signature: &Signature{V: 1, R: common.HexToHash("111111"), S: common.HexToHash("222222222222")}}) orderItems = append(orderItems, LendingItem{LendingId: id.Uint64(), Quantity: big.NewInt(int64(2*i + 1)), Interest: big.NewInt(1), Side: Investing, Signature: &Signature{V: 1, R: common.HexToHash("111111"), S: common.HexToHash("222222222222")}})
orderItems = append(orderItems, LendingItem{LendingId: id.Uint64(), Quantity: big.NewInt(int64(2*i + 1)), Interest: big.NewInt(1), Side: Borrowing, Signature: &Signature{V: 1, R: common.HexToHash("3333333333"), S: common.HexToHash("22222222222222222")}}) orderItems = append(orderItems, LendingItem{LendingId: id.Uint64(), Quantity: big.NewInt(int64(2*i + 1)), Interest: big.NewInt(1), Side: Borrowing, Signature: &Signature{V: 1, R: common.HexToHash("3333333333"), S: common.HexToHash("22222222222222222")}})

5
bmt/bmt.go
View file

@ -196,11 +196,8 @@ type Tree struct {
func (t *Tree) Draw(hash []byte, d int) string { func (t *Tree) Draw(hash []byte, d int) string {
var left, right []string var left, right []string
var anc []*Node var anc []*Node
for i, n := range t.leaves { for _, n := range t.leaves {
left = append(left, fmt.Sprintf("%v", hashstr(n.left))) left = append(left, fmt.Sprintf("%v", hashstr(n.left)))
if i%2 == 0 {
anc = append(anc, n.parent)
}
right = append(right, fmt.Sprintf("%v", hashstr(n.right))) right = append(right, fmt.Sprintf("%v", hashstr(n.right)))
} }
anc = t.leaves anc = t.leaves

15
eth/handler.go
View file

@ -769,7 +769,6 @@ func (pm *ProtocolManager) handleMsg(p *peer) error {
if err := msg.Decode(&txs); err != nil { if err := msg.Decode(&txs); err != nil {
return errResp(ErrDecode, "msg %v: %v", msg, err) return errResp(ErrDecode, "msg %v: %v", msg, err)
} }
var unkownTxs []*types.Transaction
for i, tx := range txs { for i, tx := range txs {
// Validate and mark the remote transaction // Validate and mark the remote transaction
@ -778,9 +777,7 @@ func (pm *ProtocolManager) handleMsg(p *peer) error {
} }
p.MarkTransaction(tx.Hash()) p.MarkTransaction(tx.Hash())
exist, _ := pm.knownTxs.ContainsOrAdd(tx.Hash(), true) exist, _ := pm.knownTxs.ContainsOrAdd(tx.Hash(), true)
if !exist { if exist {
unkownTxs = append(unkownTxs, tx)
} else {
log.Trace("Discard known tx", "hash", tx.Hash(), "nonce", tx.Nonce(), "to", tx.To()) log.Trace("Discard known tx", "hash", tx.Hash(), "nonce", tx.Nonce(), "to", tx.To())
} }
@ -797,7 +794,6 @@ func (pm *ProtocolManager) handleMsg(p *peer) error {
if err := msg.Decode(&txs); err != nil { if err := msg.Decode(&txs); err != nil {
return errResp(ErrDecode, "msg %v: %v", msg, err) return errResp(ErrDecode, "msg %v: %v", msg, err)
} }
var unkownOrderTxs []*types.OrderTransaction
for i, tx := range txs { for i, tx := range txs {
// Validate and mark the remote transaction // Validate and mark the remote transaction
@ -806,9 +802,7 @@ func (pm *ProtocolManager) handleMsg(p *peer) error {
} }
p.MarkOrderTransaction(tx.Hash()) p.MarkOrderTransaction(tx.Hash())
exist, _ := pm.knowOrderTxs.ContainsOrAdd(tx.Hash(), true) exist, _ := pm.knowOrderTxs.ContainsOrAdd(tx.Hash(), true)
if !exist { if exist {
unkownOrderTxs = append(unkownOrderTxs, tx)
} else {
log.Trace("Discard known tx", "hash", tx.Hash(), "nonce", tx.Nonce()) log.Trace("Discard known tx", "hash", tx.Hash(), "nonce", tx.Nonce())
} }
@ -828,7 +822,6 @@ func (pm *ProtocolManager) handleMsg(p *peer) error {
if err := msg.Decode(&txs); err != nil { if err := msg.Decode(&txs); err != nil {
return errResp(ErrDecode, "msg %v: %v", msg, err) return errResp(ErrDecode, "msg %v: %v", msg, err)
} }
var unkownLendingTxs []*types.LendingTransaction
for i, tx := range txs { for i, tx := range txs {
// Validate and mark the remote transaction // Validate and mark the remote transaction
@ -837,9 +830,7 @@ func (pm *ProtocolManager) handleMsg(p *peer) error {
} }
p.MarkLendingTransaction(tx.Hash()) p.MarkLendingTransaction(tx.Hash())
exist, _ := pm.knowLendingTxs.ContainsOrAdd(tx.Hash(), true) exist, _ := pm.knowLendingTxs.ContainsOrAdd(tx.Hash(), true)
if !exist { if exist {
unkownLendingTxs = append(unkownLendingTxs, tx)
} else {
log.Trace("Discard known tx", "hash", tx.Hash(), "nonce", tx.Nonce()) log.Trace("Discard known tx", "hash", tx.Hash(), "nonce", tx.Nonce())
} }