From a305f5a08ca7c09892d0767ebe4292e4a9d8f6dd Mon Sep 17 00:00:00 2001 From: renaynay <41963722+renaynay@users.noreply.github.com> Date: Wed, 25 Mar 2020 19:14:33 +0100 Subject: [PATCH] removing unnecessary function --- node/node.go | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/node/node.go b/node/node.go index c44634fe0f..5cca0eabf5 100644 --- a/node/node.go +++ b/node/node.go @@ -20,7 +20,6 @@ import ( "errors" "fmt" "net" - "net/http" "os" "path/filepath" "reflect" @@ -377,12 +376,11 @@ func (n *Node) startHTTP(endpoint string, apis []rpc.API, modules []string, cors return err // TODO this should return upon failure, right? } - var ws http.Handler - if n.httpEndpoint == n.wsEndpoint { - ws = srv.WebsocketHandler(wsOrigins) - } + handler := NewHTTPHandlerStack(srv, cors, vhosts) // wrap handler in websocket handler only if websocket port is the same as http rpc - handler := n.AddWebsocketHandler(NewHTTPHandlerStack(srv, cors, vhosts), ws) + if n.httpEndpoint == n.wsEndpoint { + handler = NewWebsocketUpgradeHandler(handler, srv.WebsocketHandler(wsOrigins)) + } listener, err := rpc.StartHTTPEndpoint(endpoint, timeouts, handler) if err != nil { @@ -402,15 +400,6 @@ func (n *Node) startHTTP(endpoint string, apis []rpc.API, modules []string, cors return nil } -// AddWebsocketHandler creates the handler stack necessary to handle both http rpc requests and websocket requests -func (n *Node) AddWebsocketHandler(handler http.Handler, websocket http.Handler) http.Handler { - if websocket != nil { - return NewWebsocketUpgradeHandler(handler, websocket) - } - - return handler -} - // stopHTTP terminates the HTTP RPC endpoint. func (n *Node) stopHTTP() { if n.httpListener != nil {