From a57d21166a8e08a6d9c6a58a69e65e6914342bd8 Mon Sep 17 00:00:00 2001 From: Evgeny Danienko <6655321@bk.ru> Date: Thu, 12 May 2022 18:27:03 +0300 Subject: [PATCH] leaks --- .github/workflows/ci.yml | 10 ++++++---- common/leak/ignore_list.go | 8 ++++++++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0cb5167156..6060ca77cf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,13 +25,19 @@ jobs: - run: | git submodule update --init --recursive --force git fetch --no-tags --prune --depth=1 origin +refs/heads/master:refs/remotes/origin/master + - uses: actions/setup-go@v3 with: go-version: 1.18.x + - name: Install dependencies on Linux if: runner.os == 'Linux' run: sudo apt update && sudo apt install build-essential + - name: Golang-ci install + if: runner.os == 'Linux' + run: make lintci-deps + - uses: actions/cache@v3 with: path: | @@ -56,10 +62,6 @@ jobs: # echo >&2 "Reproducible build broken"; cat bor1.sha256; cat bor2.sha256; exit 1 # fi - - name: Golang-ci install - if: runner.os == 'Linux' - run: make lintci-deps - - name: Lint if: runner.os == 'Linux' run: make lint diff --git a/common/leak/ignore_list.go b/common/leak/ignore_list.go index e43e1c0393..ed61342a06 100644 --- a/common/leak/ignore_list.go +++ b/common/leak/ignore_list.go @@ -4,10 +4,18 @@ import "go.uber.org/goleak" func IgnoreList() []goleak.Option { return []goleak.Option{ + // a list of goroutne leaks that goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache"), goleak.IgnoreTopFunction("github.com/rjeczalik/notify.(*recursiveTree).dispatch"), + goleak.IgnoreTopFunction("github.com/rjeczalik/notify.(*nonrecursiveTree).dispatch"), goleak.IgnoreTopFunction("github.com/rjeczalik/notify._Cfunc_CFRunLoopRun"), + + // todo: this leaks should be fixed goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/metrics.(*meterArbiter).tick"), goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/consensus/ethash.(*remoteSealer).loop"), + goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/core.(*BlockChain).updateFutureBlocks"), + goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/core/state/snapshot.(*diskLayer).generate"), + goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/accounts/abi/bind/backends.nullSubscription.func1"), + goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/eth/filters.(*EventSystem).eventLoop"), } }