From a58ab05fc015d99e04f8c6036c159d59581befeb Mon Sep 17 00:00:00 2001 From: Alexey Akhunov Date: Tue, 4 Jun 2019 13:53:13 +0100 Subject: [PATCH] Not fail when SendTx has transaction with incorrect RLP --- cmd/geth/retesteth.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/geth/retesteth.go b/cmd/geth/retesteth.go index 0b7b0fba4e..004585f3d7 100644 --- a/cmd/geth/retesteth.go +++ b/cmd/geth/retesteth.go @@ -414,7 +414,8 @@ func (api *RetestethAPI) SetChainParams(ctx context.Context, chainParams ChainPa func (api *RetestethAPI) SendRawTransaction(ctx context.Context, rawTx hexutil.Bytes) (common.Hash, error) { tx := new(types.Transaction) if err := rlp.DecodeBytes(rawTx, tx); err != nil { - return common.Hash{}, err + // Return nil is not by mistake - some tests include sending transaction where gasLimit overflows uint64 + return common.Hash{}, nil } signer := types.MakeSigner(api.chainConfig, big.NewInt(int64(api.blockNumber))) sender, err := types.Sender(signer, tx)