From a5eab7eddb6f75785b95e4374e0130d5a4f81e0f Mon Sep 17 00:00:00 2001 From: Daniel Liu <139250065@qq.com> Date: Tue, 9 Sep 2025 14:59:01 +0800 Subject: [PATCH] eth/tracers: replace noarg fmt.Errorf with errors.New #27330 (#1335) --- eth/tracers/js/goja.go | 2 +- eth/tracers/logger/logger_test.go | 4 ++-- eth/tracers/tracers.go | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/eth/tracers/js/goja.go b/eth/tracers/js/goja.go index 8427fbbb60..387f9fbc91 100644 --- a/eth/tracers/js/goja.go +++ b/eth/tracers/js/goja.go @@ -88,7 +88,7 @@ func fromBuf(vm *goja.Runtime, bufType goja.Value, buf goja.Value, allowString b b := obj.Get("buffer").Export().(goja.ArrayBuffer).Bytes() return b, nil } - return nil, fmt.Errorf("invalid buffer type") + return nil, errors.New("invalid buffer type") } // jsTracer is an implementation of the Tracer interface which evaluates diff --git a/eth/tracers/logger/logger_test.go b/eth/tracers/logger/logger_test.go index 7f10271508..d6aeb11510 100644 --- a/eth/tracers/logger/logger_test.go +++ b/eth/tracers/logger/logger_test.go @@ -18,7 +18,7 @@ package logger import ( "encoding/json" - "fmt" + "errors" "math/big" "testing" @@ -84,7 +84,7 @@ func TestStructLogMarshalingOmitEmpty(t *testing.T) { }{ {"empty err and no fields", &StructLog{}, `{"pc":0,"op":0,"gas":"0x0","gasCost":"0x0","memSize":0,"stack":null,"depth":0,"refund":0,"opName":"STOP"}`}, - {"with err", &StructLog{Err: fmt.Errorf("this failed")}, + {"with err", &StructLog{Err: errors.New("this failed")}, `{"pc":0,"op":0,"gas":"0x0","gasCost":"0x0","memSize":0,"stack":null,"depth":0,"refund":0,"opName":"STOP","error":"this failed"}`}, {"with mem", &StructLog{Memory: make([]byte, 2), MemorySize: 2}, `{"pc":0,"op":0,"gas":"0x0","gasCost":"0x0","memory":"0x0000","memSize":2,"stack":null,"depth":0,"refund":0,"opName":"STOP"}`}, diff --git a/eth/tracers/tracers.go b/eth/tracers/tracers.go index e487ca041c..79829bc448 100644 --- a/eth/tracers/tracers.go +++ b/eth/tracers/tracers.go @@ -19,6 +19,7 @@ package tracers import ( "encoding/json" + "errors" "fmt" "math/big" @@ -105,7 +106,7 @@ const ( // It zero-pads the slice if it extends beyond memory bounds. func GetMemoryCopyPadded(m *vm.Memory, offset, size int64) ([]byte, error) { if offset < 0 || size < 0 { - return nil, fmt.Errorf("offset or size must not be negative") + return nil, errors.New("offset or size must not be negative") } if int(offset+size) < m.Len() { // slice fully inside memory return m.GetCopy(offset, size), nil