forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-15 04:26:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

internal/jsre: handle null and undefined to prevent crash (#23701)

Browse source 
This prevents the console from crashing when auto-completing on
a variable or property that is null or undefined.

Fixes #23693
This commit is contained in:
Aditya Arora 2021-10-10 09:58:47 -03:00 committed by GitHub
parent 1bea4b0dfa
commit a6a0609b05
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/jsre/completion.go
View file

@ -44,7 +44,7 @@ func getCompletions(vm *goja.Runtime, line string) (results []string) {
obj := vm.GlobalObject() obj := vm.GlobalObject()
for i := 0; i < len(parts)-1; i++ { for i := 0; i < len(parts)-1; i++ {
v := obj.Get(parts[i]) v := obj.Get(parts[i])
if v == nil { if v == nil || goja.IsNull(v) || goja.IsUndefined(v) {
return nil // No object was found return nil // No object was found
} }
obj = v.ToObject(vm) obj = v.ToObject(vm)