From a86ccc421251156d8d9df21fe1227d5b359251d4 Mon Sep 17 00:00:00 2001 From: Jared Wasinger Date: Wed, 15 Nov 2023 16:57:35 +0800 Subject: [PATCH] simplify TerminalHandler constructor/WithAttrs by omitting explicit instantiation for value types that take defaults --- log/handler.go | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/log/handler.go b/log/handler.go index 47bfbdb4f6..97f3224511 100644 --- a/log/handler.go +++ b/log/handler.go @@ -100,12 +100,10 @@ func NewTerminalHandler(wr io.Writer, useColor bool) *TerminalHandler { // records which are less than or equal to the specified verbosity level. func NewTerminalHandlerWithLevel(wr io.Writer, lvl slog.Level, useColor bool) *TerminalHandler { return &TerminalHandler{ - sync.Mutex{}, - wr, - lvl, - useColor, - []slog.Attr{}, - make(map[string]int), + wr: wr, + lvl: lvl, + useColor: useColor, + fieldPadding: make(map[string]int), } } @@ -126,12 +124,11 @@ func (h *TerminalHandler) WithGroup(name string) slog.Handler { func (h *TerminalHandler) WithAttrs(attrs []slog.Attr) slog.Handler { return &TerminalHandler{ - sync.Mutex{}, - h.wr, - h.lvl, - h.useColor, - append(h.attrs, attrs...), - make(map[string]int), + wr: h.wr, + lvl: h.lvl, + useColor: h.useColor, + attrs: append(h.attrs, attrs...), + fieldPadding: make(map[string]int), } }