From b9323b73e09eb634b2eadede4e75020d85be8dd8 Mon Sep 17 00:00:00 2001 From: Daniel Liu Date: Tue, 29 Oct 2024 16:26:18 +0800 Subject: [PATCH] metrics/influxdb: fix staticcheck warning SA1015: replace time.Tick with time.NewTicker --- metrics/influxdb/influxdb.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/metrics/influxdb/influxdb.go b/metrics/influxdb/influxdb.go index 90df2e18a7..5c00c1a4c3 100644 --- a/metrics/influxdb/influxdb.go +++ b/metrics/influxdb/influxdb.go @@ -69,16 +69,19 @@ func (r *reporter) makeClient() (err error) { } func (r *reporter) run() { - intervalTicker := time.Tick(r.interval) - pingTicker := time.Tick(time.Second * 5) + intervalTicker := time.NewTicker(r.interval) + pingTicker := time.NewTicker(time.Second * 5) + + defer intervalTicker.Stop() + defer pingTicker.Stop() for { select { - case <-intervalTicker: + case <-intervalTicker.C: if err := r.send(); err != nil { log.Printf("unable to send to InfluxDB. err=%v", err) } - case <-pingTicker: + case <-pingTicker.C: _, _, err := r.client.Ping() if err != nil { log.Printf("got error while sending a ping to InfluxDB, trying to recreate client. err=%v", err)