forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-26 06:36:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

whisper: fixed the error logs

Browse source
This commit is contained in:
Vlad 2016-11-22 20:32:12 +01:00
parent 568b1dc50e
commit aa925b6384
9 changed files with 324 additions and 598 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

285
whisper/shhapi/api_test.go
View file

@ -30,78 +30,64 @@ func TestBasic(x *testing.T) {
var id string = "test" var id string = "test"
api := NewPublicWhisperAPI() api := NewPublicWhisperAPI()
if api == nil { if api == nil {
x.Errorf("failed to create API.") x.Fatalf("failed to create API.")
return
} }
ver, err := api.Version() ver, err := api.Version()
if err != nil { if err != nil {
x.Errorf("failed generateFilter: %s.", err) x.Fatalf("failed generateFilter: %s.", err)
return
} }
if ver.Uint64() != whisperv5.ProtocolVersion { if ver.Uint64() != whisperv5.ProtocolVersion {
x.Errorf("wrong version: %d.", ver.Uint64()) x.Fatalf("wrong version: %d.", ver.Uint64())
return
} }
var hexnum rpc.HexNumber var hexnum rpc.HexNumber
mail := api.GetFilterChanges(hexnum) mail := api.GetFilterChanges(hexnum)
if len(mail) != 0 { if len(mail) != 0 {
x.Errorf("failed GetFilterChanges") x.Fatalf("failed GetFilterChanges")
return
} }
exist, err := api.HasIdentity(id) exist, err := api.HasIdentity(id)
if err != nil { if err != nil {
x.Errorf("failed 1 HasIdentity: %s.", err) x.Fatalf("failed test case 1: %s.", err)
return
} }
if exist { if exist {
x.Errorf("failed 2 HasIdentity: false positive.") x.Fatalf("failed test case 2, HasIdentity: false positive.")
return
} }
err = api.DeleteIdentity(id) err = api.DeleteIdentity(id)
if err != nil { if err != nil {
x.Errorf("failed 3 DeleteIdentity: %s.", err) x.Fatalf("failed test case 3: %s.", err)
return
} }
pub, err := api.NewIdentity() pub, err := api.NewIdentity()
if err != nil { if err != nil {
x.Errorf("failed 4 NewIdentity: %s.", err) x.Fatalf("failed test case 4: %s.", err)
return
} }
if len(pub) == 0 { if len(pub) == 0 {
x.Errorf("NewIdentity 5: empty") x.Fatalf("test case 5, NewIdentity: empty")
return
} }
exist, err = api.HasIdentity(pub) exist, err = api.HasIdentity(pub)
if err != nil { if err != nil {
x.Errorf("failed 6 HasIdentity: %s.", err) x.Fatalf("failed test case 6: %s.", err)
return
} }
if !exist { if !exist {
x.Errorf("failed 7 HasIdentity: false negative.") x.Fatalf("failed test case 7, HasIdentity: false negative.")
return
} }
err = api.DeleteIdentity(pub) err = api.DeleteIdentity(pub)
if err != nil { if err != nil {
x.Errorf("failed 8 DeleteIdentity: %s.", err) x.Fatalf("failed 8 DeleteIdentity: %s.", err)
return
} }
exist, err = api.HasIdentity(pub) exist, err = api.HasIdentity(pub)
if err != nil { if err != nil {
x.Errorf("failed 9 HasIdentity: %s.", err) x.Fatalf("failed test case 9: %s.", err)
return
} }
if exist { if exist {
x.Errorf("failed 10 HasIdentity: false positive.") x.Fatalf("failed test case 10, HasIdentity: false positive.")
return
} }
id = "arbitrary text" id = "arbitrary text"
@ -109,66 +95,54 @@ func TestBasic(x *testing.T) {
exist, err = api.HasSymKey(id) exist, err = api.HasSymKey(id)
if err != nil { if err != nil {
x.Errorf("failed 11 HasSymKey: %s.", err) x.Fatalf("failed test case 11: %s.", err)
return
} }
if exist { if exist {
x.Errorf("failed 12 HasSymKey: false positive.") x.Fatalf("failed test case 12, HasSymKey: false positive.")
return
} }
err = api.GenerateSymKey(id) err = api.GenerateSymKey(id)
if err != nil { if err != nil {
x.Errorf("failed 13 GenerateSymKey: %s.", err) x.Fatalf("failed 13 GenerateSymKey: %s.", err)
return
} }
exist, err = api.HasSymKey(id) exist, err = api.HasSymKey(id)
if err != nil { if err != nil {
x.Errorf("failed 14 HasSymKey: %s.", err) x.Fatalf("failed test case 14: %s.", err)
return
} }
if !exist { if !exist {
x.Errorf("failed 15 HasSymKey: false negative.") x.Fatalf("failed test case 15, HasSymKey: false negative.")
return
} }
err = api.AddSymKey(id, []byte("some stuff here")) err = api.AddSymKey(id, []byte("some stuff here"))
if err == nil { if err == nil {
x.Errorf("failed 16 AddSymKey: %s.", err) x.Fatalf("failed test case 16: %s.", err)
return
} }
err = api.AddSymKey(id2, []byte("some stuff here")) err = api.AddSymKey(id2, []byte("some stuff here"))
if err != nil { if err != nil {
x.Errorf("failed 17 AddSymKey: %s.", err) x.Fatalf("failed test case 17: %s.", err)
return
} }
exist, err = api.HasSymKey(id2) exist, err = api.HasSymKey(id2)
if err != nil { if err != nil {
x.Errorf("failed 18 HasSymKey: %s.", err) x.Fatalf("failed test case 18: %s.", err)
return
} }
if !exist { if !exist {
x.Errorf("failed 19 HasSymKey: false negative.") x.Fatalf("failed test case 19, HasSymKey: false negative.")
return
} }
err = api.DeleteSymKey(id) err = api.DeleteSymKey(id)
if err != nil { if err != nil {
x.Errorf("failed 20 DeleteSymKey: %s.", err) x.Fatalf("failed test case 20: %s.", err)
return
} }
exist, err = api.HasSymKey(id) exist, err = api.HasSymKey(id)
if err != nil { if err != nil {
x.Errorf("failed 21 HasSymKey: %s.", err) x.Fatalf("failed test case 21: %s.", err)
return
} }
if exist { if exist {
x.Errorf("failed 22 HasSymKey: false positive.") x.Fatalf("failed test case 22, HasSymKey: false positive.")
return
} }
} }
@ -185,57 +159,46 @@ func TestUnmarshalFilterArgs(x *testing.T) {
var f WhisperFilterArgs var f WhisperFilterArgs
err := f.UnmarshalJSON(s) err := f.UnmarshalJSON(s)
if err != nil { if err != nil {
x.Errorf("failed UnmarshalJSON: %s.", err) x.Fatalf("failed UnmarshalJSON: %s.", err)
return
} }
if f.To != "0x70c87d191324e6712a591f304b4eedef6ad9bb9d" { if f.To != "0x70c87d191324e6712a591f304b4eedef6ad9bb9d" {
x.Errorf("wrong To: %x.", f.To) x.Fatalf("wrong To: %x.", f.To)
return
} }
if f.From != "0x9b2055d370f73ec7d8a03e965129118dc8f5bf83" { if f.From != "0x9b2055d370f73ec7d8a03e965129118dc8f5bf83" {
x.Errorf("wrong From: %x.", f.To) x.Fatalf("wrong From: %x.", f.To)
return
} }
if f.KeyName != "testname" { if f.KeyName != "testname" {
x.Errorf("wrong KeyName: %s.", f.KeyName) x.Fatalf("wrong KeyName: %s.", f.KeyName)
return
} }
if f.PoW != 2.34 { if f.PoW != 2.34 {
x.Errorf("wrong pow: %f.", f.PoW) x.Fatalf("wrong pow: %f.", f.PoW)
return
} }
if !f.AcceptP2P { if !f.AcceptP2P {
x.Errorf("wrong AcceptP2P: %v.", f.AcceptP2P) x.Fatalf("wrong AcceptP2P: %v.", f.AcceptP2P)
return
} }
if len(f.Topics) != 4 { if len(f.Topics) != 4 {
x.Errorf("wrong topics number: %d.", len(f.Topics)) x.Fatalf("wrong topics number: %d.", len(f.Topics))
return
} }
i := 0 i := 0
if f.Topics[i] != (whisperv5.TopicType{0x00, 0x00, 0x00, 0x00}) { if f.Topics[i] != (whisperv5.TopicType{0x00, 0x00, 0x00, 0x00}) {
x.Errorf("wrong topic[%d]: %x.", i, f.Topics[i]) x.Fatalf("wrong topic[%d]: %x.", i, f.Topics[i])
return
} }
i++ i++
if f.Topics[i] != (whisperv5.TopicType{0x00, 0x7f, 0x80, 0xff}) { if f.Topics[i] != (whisperv5.TopicType{0x00, 0x7f, 0x80, 0xff}) {
x.Errorf("wrong topic[%d]: %x.", i, f.Topics[i]) x.Fatalf("wrong topic[%d]: %x.", i, f.Topics[i])
return
} }
i++ i++
if f.Topics[i] != (whisperv5.TopicType{0xff, 0x80, 0x7f, 0x00}) { if f.Topics[i] != (whisperv5.TopicType{0xff, 0x80, 0x7f, 0x00}) {
x.Errorf("wrong topic[%d]: %x.", i, f.Topics[i]) x.Fatalf("wrong topic[%d]: %x.", i, f.Topics[i])
return
} }
i++ i++
if f.Topics[i] != (whisperv5.TopicType{0xf2, 0x6e, 0x77, 0x79}) { if f.Topics[i] != (whisperv5.TopicType{0xf2, 0x6e, 0x77, 0x79}) {
x.Errorf("wrong topic[%d]: %x.", i, f.Topics[i]) x.Fatalf("wrong topic[%d]: %x.", i, f.Topics[i])
return
} }
} }
@ -257,53 +220,41 @@ func TestUnmarshalPostArgs(x *testing.T) {
var a PostArgs var a PostArgs
err := a.UnmarshalJSON(s) err := a.UnmarshalJSON(s)
if err != nil { if err != nil {
x.Errorf("failed UnmarshalJSON: %s.", err) x.Fatalf("failed UnmarshalJSON: %s.", err)
return
} }
if a.TTL != 12345 { if a.TTL != 12345 {
x.Errorf("wrong ttl: %d.", a.TTL) x.Fatalf("wrong ttl: %d.", a.TTL)
return
} }
if a.From != "0x70c87d191324e6712a591f304b4eedef6ad9bb9d" { if a.From != "0x70c87d191324e6712a591f304b4eedef6ad9bb9d" {
x.Errorf("wrong From: %x.", a.To) x.Fatalf("wrong From: %x.", a.To)
return
} }
if a.To != "0x9b2055d370f73ec7d8a03e965129118dc8f5bf83" { if a.To != "0x9b2055d370f73ec7d8a03e965129118dc8f5bf83" {
x.Errorf("wrong To: %x.", a.To) x.Fatalf("wrong To: %x.", a.To)
return
} }
if a.KeyName != "shh_test" { if a.KeyName != "shh_test" {
x.Errorf("wrong KeyName: %s.", a.KeyName) x.Fatalf("wrong KeyName: %s.", a.KeyName)
return
} }
if a.Topic != (whisperv5.TopicType{0xf2, 0x6e, 0x77, 0x79}) { if a.Topic != (whisperv5.TopicType{0xf2, 0x6e, 0x77, 0x79}) {
x.Errorf("wrong topic: %x.", a.Topic) x.Fatalf("wrong topic: %x.", a.Topic)
return
} }
if string(a.Padding) != "this is my test string" { if string(a.Padding) != "this is my test string" {
x.Errorf("wrong Padding: %s.", string(a.Padding)) x.Fatalf("wrong Padding: %s.", string(a.Padding))
return
} }
if string(a.Payload) != "payload should be pseudorandom" { if string(a.Payload) != "payload should be pseudorandom" {
x.Errorf("wrong Payload: %s.", string(a.Payload)) x.Fatalf("wrong Payload: %s.", string(a.Payload))
return
} }
if a.WorkTime != 777 { if a.WorkTime != 777 {
x.Errorf("wrong WorkTime: %d.", a.WorkTime) x.Fatalf("wrong WorkTime: %d.", a.WorkTime)
return
} }
if a.PoW != 3.1416 { if a.PoW != 3.1416 {
x.Errorf("wrong pow: %f.", a.PoW) x.Fatalf("wrong pow: %f.", a.PoW)
return
} }
if a.FilterID != 64 { if a.FilterID != 64 {
x.Errorf("wrong FilterID: %d.", a.FilterID) x.Fatalf("wrong FilterID: %d.", a.FilterID)
return
} }
if bytes.Compare(a.PeerID[:], a.Topic[:]) != 0 { if bytes.Compare(a.PeerID[:], a.Topic[:]) != 0 {
x.Errorf("wrong PeerID: %x.", a.PeerID) x.Fatalf("wrong PeerID: %x.", a.PeerID)
return
} }
} }
@ -323,38 +274,31 @@ func waitForMessage(api *PublicWhisperAPI, id *rpc.HexNumber, target int) bool {
func TestIntegrationAsym(x *testing.T) { func TestIntegrationAsym(x *testing.T) {
api := NewPublicWhisperAPI() api := NewPublicWhisperAPI()
if api == nil { if api == nil {
x.Errorf("failed 1 to create API.") x.Fatalf("failed to create API.")
return
} }
sig, err := api.NewIdentity() sig, err := api.NewIdentity()
if err != nil { if err != nil {
x.Errorf("failed 22 NewIdentity: %s.", err) x.Fatalf("failed test case 22: %s.", err)
return
} }
if len(sig) == 0 { if len(sig) == 0 {
x.Errorf("NewIdentity 23: empty") x.Fatalf("failed test case 23")
return
} }
exist, err := api.HasIdentity(sig) exist, err := api.HasIdentity(sig)
if err != nil { if err != nil {
x.Errorf("failed 24 HasIdentity: %s.", err) x.Fatalf("failed test case 24: %s.", err)
return
} }
if !exist { if !exist {
x.Errorf("failed 25 HasIdentity: false negative.") x.Fatalf("failed test case 25, HasIdentity: false negative.")
return
} }
key, err := api.NewIdentity() key, err := api.NewIdentity()
if err != nil { if err != nil {
x.Errorf("failed 26 NewIdentity: %s.", err) x.Fatalf("failed test case 26: %s.", err)
return
} }
if len(key) == 0 { if len(key) == 0 {
x.Errorf("failed 27 to generate new identity") x.Fatalf("failed test case 27")
return
} }
var topics [2]whisperv5.TopicType var topics [2]whisperv5.TopicType
@ -369,8 +313,7 @@ func TestIntegrationAsym(x *testing.T) {
id, err := api.NewFilter(f) id, err := api.NewFilter(f)
if err != nil { if err != nil {
x.Errorf("failed 31 to create new filter: %s.", err) x.Fatalf("failed to create new filter: %s.", err)
return
} }
var p PostArgs var p PostArgs
@ -385,87 +328,73 @@ func TestIntegrationAsym(x *testing.T) {
err = api.Post(p) err = api.Post(p)
if err != nil { if err != nil {
x.Errorf("failed 32 to post message: %s.", err) x.Errorf("failed to post message: %s.", err)
return
} }
ok := waitForMessage(api, id, 1) ok := waitForMessage(api, id, 1)
if !ok { if !ok {
x.Errorf("failed 33 receive first message: timeout.") x.Fatalf("failed to receive first message: timeout.")
return
} }
mail := api.GetFilterChanges(*id) mail := api.GetFilterChanges(*id)
if len(mail) != 1 { if len(mail) != 1 {
x.Errorf("failed 34 to GetFilterChanges: got %d messages.", len(mail)) x.Fatalf("failed to GetFilterChanges: got %d messages.", len(mail))
return
} }
text := string(common.FromHex(mail[0].Payload)) text := string(common.FromHex(mail[0].Payload))
if text != string("extended test string") { if text != string("extended test string") {
x.Errorf("failed 35 to decrypt first message: %s.", text) x.Fatalf("failed to decrypt first message: %s.", text)
return
} }
p.Padding = []byte("new value") p.Padding = []byte("new value")
p.Payload = []byte("extended new value") p.Payload = []byte("extended new value")
err = api.Post(p) err = api.Post(p)
if err != nil { if err != nil {
x.Errorf("failed 42 to post message: %s.", err) x.Fatalf("failed to post next message: %s.", err)
return
} }
ok = waitForMessage(api, id, 2) ok = waitForMessage(api, id, 2)
if !ok { if !ok {
x.Errorf("failed 43 receive second message: timeout.") x.Fatalf("failed to receive second message: timeout.")
return
} }
mail = api.GetFilterChanges(*id) mail = api.GetFilterChanges(*id)
if len(mail) != 1 { if len(mail) != 1 {
x.Errorf("failed 44 to GetFilterChanges: got %d messages.", len(mail)) x.Fatalf("failed to GetFilterChanges: got %d messages.", len(mail))
return
} }
text = string(common.FromHex(mail[0].Payload)) text = string(common.FromHex(mail[0].Payload))
if text != string("extended new value") { if text != string("extended new value") {
x.Errorf("failed 45 to decrypt second message: %s.", text) x.Fatalf("failed to decrypt second message: %s.", text)
return
} }
} }
func TestIntegrationSym(x *testing.T) { func TestIntegrationSym(x *testing.T) {
api := NewPublicWhisperAPI() api := NewPublicWhisperAPI()
if api == nil { if api == nil {
x.Errorf("failed 1 to create API.") x.Fatalf("failed to create API.")
return
} }
keyname := "schluessel" keyname := "schluessel"
err := api.GenerateSymKey(keyname) err := api.GenerateSymKey(keyname)
if err != nil { if err != nil {
x.Errorf("failed 2 to GenerateSymKey: %s.", err) x.Fatalf("failed test case 1: %s.", err)
return
} }
sig, err := api.NewIdentity() sig, err := api.NewIdentity()
if err != nil { if err != nil {
x.Errorf("failed 22 NewIdentity: %s.", err) x.Fatalf("failed test case 2: %s.", err)
return
} }
if len(sig) == 0 { if len(sig) == 0 {
x.Errorf("NewIdentity 23: empty") x.Fatalf("failed test case 3")
return
} }
exist, err := api.HasIdentity(sig) exist, err := api.HasIdentity(sig)
if err != nil { if err != nil {
x.Errorf("failed 24 HasIdentity: %s.", err) x.Fatalf("failed test case 4: %s.", err)
return
} }
if !exist { if !exist {
x.Errorf("failed 25 HasIdentity: false negative.") x.Fatalf("failed test case 5, HasIdentity: false negative.")
return
} }
var topics [2]whisperv5.TopicType var topics [2]whisperv5.TopicType
@ -480,8 +409,7 @@ func TestIntegrationSym(x *testing.T) {
id, err := api.NewFilter(f) id, err := api.NewFilter(f)
if err != nil { if err != nil {
x.Errorf("failed 31 to create new filter: %s.", err) x.Fatalf("failed 31 to create new filter: %s.", err)
return
} }
var p PostArgs var p PostArgs
@ -496,87 +424,73 @@ func TestIntegrationSym(x *testing.T) {
err = api.Post(p) err = api.Post(p)
if err != nil { if err != nil {
x.Errorf("failed 32 to post message: %s.", err) x.Fatalf("failed test case 32 (post message): %s.", err)
return
} }
ok := waitForMessage(api, id, 1) ok := waitForMessage(api, id, 1)
if !ok { if !ok {
x.Errorf("failed 33 to receive first message: timeout.") x.Fatalf("failed test case 33 (receive first message: timeout).")
return
} }
mail := api.GetFilterChanges(*id) mail := api.GetFilterChanges(*id)
if len(mail) != 1 { if len(mail) != 1 {
x.Errorf("failed 34 to GetFilterChanges: got %d messages.", len(mail)) x.Fatalf("failed test case 34 (GetFilterChanges: got %d messages).", len(mail))
return
} }
text := string(common.FromHex(mail[0].Payload)) text := string(common.FromHex(mail[0].Payload))
if text != string("extended test string") { if text != string("extended test string") {
x.Errorf("failed 35 to decrypt first message: %s.", text) x.Fatalf("failed test case 35 (decrypt first message): %s.", text)
return
} }
p.Padding = []byte("new value") p.Padding = []byte("new value")
p.Payload = []byte("extended new value") p.Payload = []byte("extended new value")
err = api.Post(p) err = api.Post(p)
if err != nil { if err != nil {
x.Errorf("failed 42 to post message: %s.", err) x.Fatalf("failed test case 42 (post message): %s.", err)
return
} }
ok = waitForMessage(api, id, 2) ok = waitForMessage(api, id, 2)
if !ok { if !ok {
x.Errorf("failed 43 receive second message: timeout.") x.Fatalf("failed test case 43 (receive second message: timeout).")
return
} }
mail = api.GetFilterChanges(*id) mail = api.GetFilterChanges(*id)
if len(mail) != 1 { if len(mail) != 1 {
x.Errorf("failed 44 to GetFilterChanges: got %d messages.", len(mail)) x.Fatalf("failed test case 44 (GetFilterChanges: got %d messages).", len(mail))
return
} }
text = string(common.FromHex(mail[0].Payload)) text = string(common.FromHex(mail[0].Payload))
if text != string("extended new value") { if text != string("extended new value") {
x.Errorf("failed 45 to decrypt second message: %s.", text) x.Fatalf("failed test case 45 (decrypt second message: %s).", text)
return
} }
} }
func TestIntegrationSymWithFilter(x *testing.T) { func TestIntegrationSymWithFilter(x *testing.T) {
api := NewPublicWhisperAPI() api := NewPublicWhisperAPI()
if api == nil { if api == nil {
x.Errorf("failed 1 to create API.") x.Fatalf("failed to create API.")
return
} }
keyname := "schluessel" keyname := "schluessel"
err := api.GenerateSymKey(keyname) err := api.GenerateSymKey(keyname)
if err != nil { if err != nil {
x.Errorf("failed 2 to GenerateSymKey: %s.", err) x.Fatalf("failed to GenerateSymKey: %s.", err)
return
} }
sig, err := api.NewIdentity() sig, err := api.NewIdentity()
if err != nil { if err != nil {
x.Errorf("failed 22 NewIdentity: %s.", err) x.Fatalf("failed test case 2: %s.", err)
return
} }
if len(sig) == 0 { if len(sig) == 0 {
x.Errorf("NewIdentity 23: empty") x.Fatalf("failed test case 3.")
return
} }
exist, err := api.HasIdentity(sig) exist, err := api.HasIdentity(sig)
if err != nil { if err != nil {
x.Errorf("failed 24 HasIdentity: %s.", err) x.Fatalf("failed test case 4: %s.", err)
return
} }
if !exist { if !exist {
x.Errorf("failed 25 HasIdentity: false negative.") x.Fatalf("failed test case 5.")
return
} }
var topics [2]whisperv5.TopicType var topics [2]whisperv5.TopicType
@ -591,8 +505,7 @@ func TestIntegrationSymWithFilter(x *testing.T) {
id, err := api.NewFilter(f) id, err := api.NewFilter(f)
if err != nil { if err != nil {
x.Errorf("failed 31 to create new filter: %s.", err) x.Fatalf("failed to create new filter: %s.", err)
return
} }
var p PostArgs var p PostArgs
@ -607,51 +520,43 @@ func TestIntegrationSymWithFilter(x *testing.T) {
err = api.Post(p) err = api.Post(p)
if err != nil { if err != nil {
x.Errorf("failed 32 to post message: %s.", err) x.Fatalf("failed to post message: %s.", err)
return
} }
ok := waitForMessage(api, id, 1) ok := waitForMessage(api, id, 1)
if !ok { if !ok {
x.Errorf("failed 33 to receive first message: timeout.") x.Fatalf("failed to receive first message: timeout.")
return
} }
mail := api.GetFilterChanges(*id) mail := api.GetFilterChanges(*id)
if len(mail) != 1 { if len(mail) != 1 {
x.Errorf("failed 34 to GetFilterChanges: got %d messages.", len(mail)) x.Fatalf("failed to GetFilterChanges: got %d messages.", len(mail))
return
} }
text := string(common.FromHex(mail[0].Payload)) text := string(common.FromHex(mail[0].Payload))
if text != string("extended test string") { if text != string("extended test string") {
x.Errorf("failed 35 to decrypt first message: %s.", text) x.Fatalf("failed to decrypt first message: %s.", text)
return
} }
p.Padding = []byte("new value") p.Padding = []byte("new value")
p.Payload = []byte("extended new value") p.Payload = []byte("extended new value")
err = api.Post(p) err = api.Post(p)
if err != nil { if err != nil {
x.Errorf("failed 42 to post message: %s.", err) x.Fatalf("failed to post next message: %s.", err)
return
} }
ok = waitForMessage(api, id, 2) ok = waitForMessage(api, id, 2)
if !ok { if !ok {
x.Errorf("failed 43 receive second message: timeout.") x.Fatalf("failed to receive second message: timeout.")
return
} }
mail = api.GetFilterChanges(*id) mail = api.GetFilterChanges(*id)
if len(mail) != 1 { if len(mail) != 1 {
x.Errorf("failed 44 to GetFilterChanges: got %d messages.", len(mail)) x.Fatalf("failed to GetFilterChanges: got %d messages.", len(mail))
return
} }
text = string(common.FromHex(mail[0].Payload)) text = string(common.FromHex(mail[0].Payload))
if text != string("extended new value") { if text != string("extended new value") {
x.Errorf("failed 45 to decrypt second message: %s.", text) x.Fatalf("failed to decrypt second message: %s.", text)
return
} }
} }

57
whisper/whisperv5/benchmarks_test.go
View file

@ -40,8 +40,7 @@ func BenchmarkEncryptionSym(b *testing.B) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
b.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) b.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
@ -60,13 +59,11 @@ func BenchmarkEncryptionAsym(b *testing.B) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
b.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) b.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()
if err != nil { if err != nil {
b.Errorf("failed GenerateKey with seed %d: %s.", seed, err) b.Fatalf("failed GenerateKey with seed %d: %s.", seed, err)
return
} }
params.KeySym = nil params.KeySym = nil
params.Dst = &key.PublicKey params.Dst = &key.PublicKey
@ -75,8 +72,7 @@ func BenchmarkEncryptionAsym(b *testing.B) {
msg := NewSentMessage(params) msg := NewSentMessage(params)
_, err := msg.Wrap(params) _, err := msg.Wrap(params)
if err != nil { if err != nil {
b.Errorf("failed Wrap with seed %d: %s.", seed, err) b.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
} }
} }
@ -86,22 +82,19 @@ func BenchmarkDecryptionSymValid(b *testing.B) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
b.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) b.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
b.Errorf("failed Wrap with seed %d: %s.", seed, err) b.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
f := Filter{KeySym: params.KeySym} f := Filter{KeySym: params.KeySym}
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
msg := env.Open(&f) msg := env.Open(&f)
if msg == nil { if msg == nil {
b.Errorf("failed to open with seed %d.", seed) b.Fatalf("failed to open with seed %d.", seed)
return
} }
} }
} }
@ -111,22 +104,19 @@ func BenchmarkDecryptionSymInvalid(b *testing.B) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
b.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) b.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
b.Errorf("failed Wrap with seed %d: %s.", seed, err) b.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
f := Filter{KeySym: []byte("arbitrary stuff here")} f := Filter{KeySym: []byte("arbitrary stuff here")}
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
msg := env.Open(&f) msg := env.Open(&f)
if msg != nil { if msg != nil {
b.Errorf("opened envelope with invalid key, seed: %d.", seed) b.Fatalf("opened envelope with invalid key, seed: %d.", seed)
return
} }
} }
} }
@ -136,13 +126,11 @@ func BenchmarkDecryptionAsymValid(b *testing.B) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
b.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) b.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()
if err != nil { if err != nil {
b.Errorf("failed GenerateKey with seed %d: %s.", seed, err) b.Fatalf("failed GenerateKey with seed %d: %s.", seed, err)
return
} }
f := Filter{KeyAsym: key} f := Filter{KeyAsym: key}
params.KeySym = nil params.KeySym = nil
@ -150,15 +138,13 @@ func BenchmarkDecryptionAsymValid(b *testing.B) {
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
b.Errorf("failed Wrap with seed %d: %s.", seed, err) b.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
msg := env.Open(&f) msg := env.Open(&f)
if msg == nil { if msg == nil {
b.Errorf("fail to open, seed: %d.", seed) b.Fatalf("fail to open, seed: %d.", seed)
return
} }
} }
} }
@ -168,35 +154,30 @@ func BenchmarkDecryptionAsymInvalid(b *testing.B) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
b.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) b.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()
if err != nil { if err != nil {
b.Errorf("failed GenerateKey with seed %d: %s.", seed, err) b.Fatalf("failed GenerateKey with seed %d: %s.", seed, err)
return
} }
params.KeySym = nil params.KeySym = nil
params.Dst = &key.PublicKey params.Dst = &key.PublicKey
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
b.Errorf("failed Wrap with seed %d: %s.", seed, err) b.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
key, err = crypto.GenerateKey() key, err = crypto.GenerateKey()
if err != nil { if err != nil {
b.Errorf("failed GenerateKey with seed %d: %s.", seed, err) b.Fatalf("failed GenerateKey with seed %d: %s.", seed, err)
return
} }
f := Filter{KeyAsym: key} f := Filter{KeyAsym: key}
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
msg := env.Open(&f) msg := env.Open(&f)
if msg != nil { if msg != nil {
b.Errorf("opened envelope with invalid key, seed: %d.", seed) b.Fatalf("opened envelope with invalid key, seed: %d.", seed)
return
} }
} }
} }

4
whisper/whisperv5/doc.go
View file

@ -46,9 +46,7 @@ const (
messagesCode = 1 messagesCode = 1
p2pCode = 2 p2pCode = 2
mailRequestCode = 3 mailRequestCode = 3
bloomExchangeCode = 4 NumberOfMessageCodes = 10
reservedCode = 5
NumberOfMessageCodes = 6
paddingMask = byte(3) paddingMask = byte(3)
signatureFlag = byte(4) signatureFlag = byte(4)

17
whisper/whisperv5/filter.go
View file

@ -155,21 +155,20 @@ func (f *Filter) MatchEnvelope(envelope *Envelope) bool {
return false return false
} }
encryptionMethodMatch := false
if f.expectsAsymmetricEncryption() && envelope.isAsymmetric() { if f.expectsAsymmetricEncryption() && envelope.isAsymmetric() {
encryptionMethodMatch = true return f.MatchTopic(envelope.Topic)
if f.Topics == nil {
// wildcard
return true
}
} else if f.expectsSymmetricEncryption() && envelope.IsSymmetric() { } else if f.expectsSymmetricEncryption() && envelope.IsSymmetric() {
encryptionMethodMatch = true return f.MatchTopic(envelope.Topic)
} }
return false
return encryptionMethodMatch && f.MatchTopic(envelope.Topic)
} }
func (f *Filter) MatchTopic(topic TopicType) bool { func (f *Filter) MatchTopic(topic TopicType) bool {
if len(f.Topics) == 0 {
// any topic matches
return true
}
for _, t := range f.Topics { for _, t := range f.Topics {
if t == topic { if t == topic {
return true return true

225
whisper/whisperv5/filter_test.go
View file

@ -61,7 +61,7 @@ func generateFilter(x *testing.T, symmetric bool) (*Filter, error) {
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("generateFilter failed 1 with seed %d.", seed) x.Fatalf("generateFilter 1 failed with seed %d.", seed)
return nil, err return nil, err
} }
f.Src = &key.PublicKey f.Src = &key.PublicKey
@ -73,7 +73,7 @@ func generateFilter(x *testing.T, symmetric bool) (*Filter, error) {
} else { } else {
f.KeyAsym, err = crypto.GenerateKey() f.KeyAsym, err = crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("generateFilter failed 2 with seed %d.", seed) x.Fatalf("generateFilter 2 failed with seed %d.", seed)
return nil, err return nil, err
} }
} }
@ -107,8 +107,7 @@ func TestInstallFilters(x *testing.T) {
} }
if j < SizeTestFilters-1 { if j < SizeTestFilters-1 {
x.Errorf("seed %d: wrong index %d", seed, j) x.Fatalf("seed %d: wrong index %d", seed, j)
return
} }
for _, t := range tst { for _, t := range tst {
@ -121,12 +120,10 @@ func TestInstallFilters(x *testing.T) {
fil := filters.Get(t.id) fil := filters.Get(t.id)
exist := (fil != nil) exist := (fil != nil)
if exist != t.alive { if exist != t.alive {
x.Errorf("seed %d: failed alive: %d, %v, %v", seed, i, exist, t.alive) x.Fatalf("seed %d: failed alive: %d, %v, %v", seed, i, exist, t.alive)
return
} }
if exist && fil.PoW != t.f.PoW { if exist && fil.PoW != t.f.PoW {
x.Errorf("seed %d: failed Get: %d, %v, %v", seed, i, exist, t.alive) x.Fatalf("seed %d: failed Get: %d, %v, %v", seed, i, exist, t.alive)
return
} }
} }
} }
@ -136,29 +133,24 @@ func TestComparePubKey(x *testing.T) {
key1, err := crypto.GenerateKey() key1, err := crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("failed GenerateKey 1 with seed %d: %s.", seed, err) x.Fatalf("failed GenerateKey 1 with seed %d: %s.", seed, err)
return
} }
key2, err := crypto.GenerateKey() key2, err := crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("failed GenerateKey 2 with seed %d: %s.", seed, err) x.Fatalf("failed GenerateKey 2 with seed %d: %s.", seed, err)
return
} }
if isPubKeyEqual(&key1.PublicKey, &key2.PublicKey) { if isPubKeyEqual(&key1.PublicKey, &key2.PublicKey) {
x.Errorf("failed !equal with seed %d.", seed) x.Fatalf("failed !equal with seed %d.", seed)
return
} }
// generate key3 == key1 // generate key3 == key1
rand.Seed(seed) rand.Seed(seed)
key3, err := crypto.GenerateKey() key3, err := crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("failed GenerateKey 3 with seed %d: %s.", seed, err) x.Fatalf("failed GenerateKey 3 with seed %d: %s.", seed, err)
return
} }
if isPubKeyEqual(&key1.PublicKey, &key3.PublicKey) { if isPubKeyEqual(&key1.PublicKey, &key3.PublicKey) {
x.Errorf("failed equal with seed %d.", seed) x.Fatalf("failed equal with seed %d.", seed)
return
} }
} }
@ -167,20 +159,17 @@ func TestMatchEnvelope(x *testing.T) {
fsym, err := generateFilter(x, true) fsym, err := generateFilter(x, true)
if err != nil { if err != nil {
x.Errorf("failed generateFilter 1 with seed %d: %s.", seed, err) x.Fatalf("failed generateFilter 1 with seed %d: %s.", seed, err)
return
} }
fasym, err := generateFilter(x, false) fasym, err := generateFilter(x, false)
if err != nil { if err != nil {
x.Errorf("failed generateFilter 2 with seed %d: %s.", seed, err) x.Fatalf("failed generateFilter 2 with seed %d: %s.", seed, err)
return
} }
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams 3 with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams 3 with seed %d: %s.", seed, err)
return
} }
params.Topic[0] = 0xFF // ensure mismatch params.Topic[0] = 0xFF // ensure mismatch
@ -189,18 +178,15 @@ func TestMatchEnvelope(x *testing.T) {
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed Wrap 4 with seed %d: %s.", seed, err) x.Fatalf("failed Wrap 4 with seed %d: %s.", seed, err)
return
} }
match := fsym.MatchEnvelope(env) match := fsym.MatchEnvelope(env)
if match { if match {
x.Errorf("failed test case 5 with seed %d.", seed) x.Fatalf("failed test case 5 with seed %d.", seed)
return
} }
match = fasym.MatchEnvelope(env) match = fasym.MatchEnvelope(env)
if match { if match {
x.Errorf("failed test case 6 with seed %d.", seed) x.Fatalf("failed test case 6 with seed %d.", seed)
return
} }
// encrypt symmetrically // encrypt symmetrically
@ -210,109 +196,109 @@ func TestMatchEnvelope(x *testing.T) {
msg = NewSentMessage(params) msg = NewSentMessage(params)
env, err = msg.Wrap(params) env, err = msg.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed test case 7 with seed %d, test case 3: %s.", seed, err) x.Fatalf("failed test case 7 with seed %d, test case 3: %s.", seed, err)
return
} }
// symmetric + matching topic: match // symmetric + matching topic: match
match = fsym.MatchEnvelope(env) match = fsym.MatchEnvelope(env)
if !match { if !match {
x.Errorf("failed test case 8 with seed %d.", seed) x.Fatalf("failed test case 8 with seed %d.", seed)
return
} }
// asymmetric + matching topic: mismatch // asymmetric + matching topic: mismatch
match = fasym.MatchEnvelope(env) match = fasym.MatchEnvelope(env)
if match { if match {
x.Errorf("failed test case 9 with seed %d.", seed) x.Fatalf("failed test case 9 with seed %d.", seed)
return
} }
// symmetric + matching topic + insufficient PoW: mismatch // symmetric + matching topic + insufficient PoW: mismatch
fsym.PoW = env.PoW() + 1.0 fsym.PoW = env.PoW() + 1.0
match = fsym.MatchEnvelope(env) match = fsym.MatchEnvelope(env)
if match { if match {
x.Errorf("failed test case 10 with seed %d.", seed) x.Fatalf("failed test case 10 with seed %d.", seed)
return
} }
// symmetric + matching topic + sufficient PoW: match // symmetric + matching topic + sufficient PoW: match
fsym.PoW = env.PoW() / 2 fsym.PoW = env.PoW() / 2
match = fsym.MatchEnvelope(env) match = fsym.MatchEnvelope(env)
if !match { if !match {
x.Errorf("failed test case 11 with seed %d.", seed) x.Fatalf("failed test case 11 with seed %d.", seed)
return
} }
// symmetric + topics are nil: mismatch // symmetric + topics are nil (wildcard): match
prevTopics := fsym.Topics prevTopics := fsym.Topics
fsym.Topics = nil fsym.Topics = nil
match = fasym.MatchEnvelope(env) match = fsym.MatchEnvelope(env)
if match { if !match {
x.Errorf("failed test case 12 with seed %d.", seed) x.Fatalf("failed test case 12 with seed %d.", seed)
return
} }
fsym.Topics = prevTopics fsym.Topics = prevTopics
// encrypt asymmetrically // encrypt asymmetrically
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("failed GenerateKey 13 with seed %d: %s.", seed, err) x.Fatalf("failed GenerateKey 13 with seed %d: %s.", seed, err)
return
} }
params.KeySym = nil params.KeySym = nil
params.Dst = &key.PublicKey params.Dst = &key.PublicKey
msg = NewSentMessage(params) msg = NewSentMessage(params)
env, err = msg.Wrap(params) env, err = msg.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed test case 14 with seed %d, test case 3: %s.", seed, err) x.Fatalf("failed test case 14 with seed %d, test case 3: %s.", seed, err)
return
} }
// encryption method mismatch // encryption method mismatch
match = fsym.MatchEnvelope(env) match = fsym.MatchEnvelope(env)
if match { if match {
x.Errorf("failed test case 15 with seed %d.", seed) x.Fatalf("failed test case 15 with seed %d.", seed)
return
} }
// asymmetric + mismatching topic: mismatch // asymmetric + mismatching topic: mismatch
match = fasym.MatchEnvelope(env) match = fasym.MatchEnvelope(env)
if !match { if !match {
x.Errorf("failed test case 16 with seed %d.", seed) x.Fatalf("failed test case 16 with seed %d.", seed)
return
} }
// asymmetric + matching topic: match // asymmetric + matching topic: match
fasym.Topics[i] = fasym.Topics[i+1] fasym.Topics[i] = fasym.Topics[i+1]
match = fasym.MatchEnvelope(env) match = fasym.MatchEnvelope(env)
if match { if match {
x.Errorf("failed test case 17 with seed %d.", seed) x.Fatalf("failed test case 17 with seed %d.", seed)
return
} }
// asymmetric + topic is nil (wildcard): match // asymmetric + filter without topic (wildcard): match
fasym.Topics = nil fasym.Topics = nil
match = fasym.MatchEnvelope(env) match = fasym.MatchEnvelope(env)
if !match { if !match {
x.Errorf("failed test case 18 with seed %d.", seed) x.Fatalf("failed test case 18 with seed %d.", seed)
return
} }
// asymmetric + insufficient PoW: mismatch // asymmetric + insufficient PoW: mismatch
fasym.PoW = env.PoW() + 1.0 fasym.PoW = env.PoW() + 1.0
match = fasym.MatchEnvelope(env) match = fasym.MatchEnvelope(env)
if match { if match {
x.Errorf("failed test case 19 with seed %d.", seed) x.Fatalf("failed test case 19 with seed %d.", seed)
return
} }
// asymmetric + sufficient PoW: match // asymmetric + sufficient PoW: match
fasym.PoW = env.PoW() / 2 fasym.PoW = env.PoW() / 2
match = fasym.MatchEnvelope(env) match = fasym.MatchEnvelope(env)
if !match { if !match {
x.Errorf("failed test case 20 with seed %d.", seed) x.Fatalf("failed test case 20 with seed %d.", seed)
return }
// filter without topic + envelope without topic: match
env.Topic = TopicType{}
match = fasym.MatchEnvelope(env)
if !match {
x.Fatalf("failed test case 21 with seed %d.", seed)
}
// filter with topic + envelope without topic: mismatch
fasym.Topics = fsym.Topics
match = fasym.MatchEnvelope(env)
if match {
x.Fatalf("failed test case 22 with seed %d.", seed)
} }
} }
@ -321,14 +307,12 @@ func TestMatchMessageSym(x *testing.T) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
f, err := generateFilter(x, true) f, err := generateFilter(x, true)
if err != nil { if err != nil {
x.Errorf("failed generateFilter 1 with seed %d: %s.", seed, err) x.Fatalf("failed generateFilter 1 with seed %d: %s.", seed, err)
return
} }
const index = 1 const index = 1
@ -338,90 +322,77 @@ func TestMatchMessageSym(x *testing.T) {
sentMessage := NewSentMessage(params) sentMessage := NewSentMessage(params)
env, err := sentMessage.Wrap(params) env, err := sentMessage.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed Wrap 2 with seed %d: %s.", seed, err) x.Fatalf("failed Wrap 2 with seed %d: %s.", seed, err)
return
} }
msg := env.Open(f) msg := env.Open(f)
if msg == nil { if msg == nil {
x.Errorf("failed to open 3 with seed %d.", seed) x.Fatalf("failed to open 3 with seed %d.", seed)
return
} }
// Src mismatch // Src mismatch
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 4 with seed %d.", seed) x.Fatalf("failed test case 4 with seed %d.", seed)
return
} }
// Src: match // Src: match
*f.Src.X = *params.Src.PublicKey.X *f.Src.X = *params.Src.PublicKey.X
*f.Src.Y = *params.Src.PublicKey.Y *f.Src.Y = *params.Src.PublicKey.Y
if !f.MatchMessage(msg) { if !f.MatchMessage(msg) {
x.Errorf("failed test case 5 with seed %d.", seed) x.Fatalf("failed test case 5 with seed %d.", seed)
return
} }
// insufficient PoW: mismatch // insufficient PoW: mismatch
f.PoW = msg.PoW + 1.0 f.PoW = msg.PoW + 1.0
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 6 with seed %d.", seed) x.Fatalf("failed test case 6 with seed %d.", seed)
return
} }
// sufficient PoW: match // sufficient PoW: match
f.PoW = msg.PoW / 2 f.PoW = msg.PoW / 2
if !f.MatchMessage(msg) { if !f.MatchMessage(msg) {
x.Errorf("failed test case 7 with seed %d.", seed) x.Fatalf("failed test case 7 with seed %d.", seed)
return
} }
// topic mismatch // topic mismatch
f.Topics[index][0]++ f.Topics[index][0]++
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 8 with seed %d.", seed) x.Fatalf("failed test case 8 with seed %d.", seed)
return
} }
f.Topics[index][0]-- f.Topics[index][0]--
// key mismatch // key mismatch
f.SymKeyHash[0]++ f.SymKeyHash[0]++
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 9 with seed %d.", seed) x.Fatalf("failed test case 9 with seed %d.", seed)
return
} }
f.SymKeyHash[0]-- f.SymKeyHash[0]--
// Src absent: match // Src absent: match
f.Src = nil f.Src = nil
if !f.MatchMessage(msg) { if !f.MatchMessage(msg) {
x.Errorf("failed test case 10 with seed %d.", seed) x.Fatalf("failed test case 10 with seed %d.", seed)
return
} }
// key hash mismatch mismatch // key hash mismatch mismatch
h := f.SymKeyHash h := f.SymKeyHash
f.SymKeyHash = common.Hash{} f.SymKeyHash = common.Hash{}
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 11 with seed %d.", seed) x.Fatalf("failed test case 11 with seed %d.", seed)
return
} }
f.SymKeyHash = h f.SymKeyHash = h
if !f.MatchMessage(msg) { if !f.MatchMessage(msg) {
x.Errorf("failed test case 12 with seed %d.", seed) x.Fatalf("failed test case 12 with seed %d.", seed)
return
} }
// encryption method mismatch // encryption method mismatch
f.KeySym = nil f.KeySym = nil
f.KeyAsym, err = crypto.GenerateKey() f.KeyAsym, err = crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("failed GenerateKey 13 with seed %d: %s.", seed, err) x.Fatalf("failed GenerateKey 13 with seed %d: %s.", seed, err)
return
} }
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 14 with seed %d.", seed) x.Fatalf("failed test case 14 with seed %d.", seed)
return
} }
} }
@ -430,14 +401,12 @@ func TestMatchMessageAsym(x *testing.T) {
f, err := generateFilter(x, false) f, err := generateFilter(x, false)
if err != nil { if err != nil {
x.Errorf("failed generateFilter with seed %d: %s.", seed, err) x.Fatalf("failed generateFilter with seed %d: %s.", seed, err)
return
} }
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
const index = 1 const index = 1
@ -449,49 +418,42 @@ func TestMatchMessageAsym(x *testing.T) {
sentMessage := NewSentMessage(params) sentMessage := NewSentMessage(params)
env, err := sentMessage.Wrap(params) env, err := sentMessage.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed Wrap with seed %d: %s.", seed, err) x.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
msg := env.Open(f) msg := env.Open(f)
if msg == nil { if msg == nil {
x.Errorf("failed to open with seed %d.", seed) x.Fatalf("failed to open with seed %d.", seed)
return
} }
// Src mismatch // Src mismatch
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 4 with seed %d.", seed) x.Fatalf("failed test case 4 with seed %d.", seed)
return
} }
// Src: match // Src: match
*f.Src.X = *params.Src.PublicKey.X *f.Src.X = *params.Src.PublicKey.X
*f.Src.Y = *params.Src.PublicKey.Y *f.Src.Y = *params.Src.PublicKey.Y
if !f.MatchMessage(msg) { if !f.MatchMessage(msg) {
x.Errorf("failed test case 5 with seed %d.", seed) x.Fatalf("failed test case 5 with seed %d.", seed)
return
} }
// insufficient PoW: mismatch // insufficient PoW: mismatch
f.PoW = msg.PoW + 1.0 f.PoW = msg.PoW + 1.0
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 6 with seed %d.", seed) x.Fatalf("failed test case 6 with seed %d.", seed)
return
} }
// sufficient PoW: match // sufficient PoW: match
f.PoW = msg.PoW / 2 f.PoW = msg.PoW / 2
if !f.MatchMessage(msg) { if !f.MatchMessage(msg) {
x.Errorf("failed test case 7 with seed %d.", seed) x.Fatalf("failed test case 7 with seed %d.", seed)
return
} }
// topic mismatch // topic mismatch
f.Topics[index][0]++ f.Topics[index][0]++
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 8 with seed %d.", seed) x.Fatalf("failed test case 8 with seed %d.", seed)
return
} }
f.Topics[index][0]-- f.Topics[index][0]--
@ -500,24 +462,21 @@ func TestMatchMessageAsym(x *testing.T) {
zero := *big.NewInt(0) zero := *big.NewInt(0)
*f.KeyAsym.PublicKey.X = zero *f.KeyAsym.PublicKey.X = zero
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 9 with seed %d.", seed) x.Fatalf("failed test case 9 with seed %d.", seed)
return
} }
*f.KeyAsym.PublicKey.X = prev *f.KeyAsym.PublicKey.X = prev
// Src absent: match // Src absent: match
f.Src = nil f.Src = nil
if !f.MatchMessage(msg) { if !f.MatchMessage(msg) {
x.Errorf("failed test case 10 with seed %d.", seed) x.Fatalf("failed test case 10 with seed %d.", seed)
return
} }
// encryption method mismatch // encryption method mismatch
f.KeySym = keySymOrig f.KeySym = keySymOrig
f.KeyAsym = nil f.KeyAsym = nil
if f.MatchMessage(msg) { if f.MatchMessage(msg) {
x.Errorf("failed test case 11 with seed %d.", seed) x.Fatalf("failed test case 11 with seed %d.", seed)
return
} }
} }
@ -537,7 +496,7 @@ func cloneFilter(orig *Filter) *Filter {
func generateCompatibeEnvelope(x *testing.T, f *Filter) *Envelope { func generateCompatibeEnvelope(x *testing.T, f *Filter) *Envelope {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams 77 with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams 77 with seed %d: %s.", seed, err)
return nil return nil
} }
@ -546,7 +505,7 @@ func generateCompatibeEnvelope(x *testing.T, f *Filter) *Envelope {
sentMessage := NewSentMessage(params) sentMessage := NewSentMessage(params)
env, err := sentMessage.Wrap(params) env, err := sentMessage.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed Wrap 78 with seed %d: %s.", seed, err) x.Fatalf("failed Wrap 78 with seed %d: %s.", seed, err)
return nil return nil
} }
return env return env
@ -594,20 +553,17 @@ func TestWatchers(x *testing.T) {
} }
if total != NumMessages { if total != NumMessages {
x.Errorf("failed test case 1 with seed %d: total = %d, want: %d.", seed, total, NumMessages) x.Fatalf("failed test case 1 with seed %d: total = %d, want: %d.", seed, total, NumMessages)
return
} }
for i = 0; i < NumFilters; i++ { for i = 0; i < NumFilters; i++ {
mail = tst[i].f.Retrieve() mail = tst[i].f.Retrieve()
if len(mail) != 0 { if len(mail) != 0 {
x.Errorf("failed test case 2 with seed %d: i = %d.", seed, i) x.Fatalf("failed test case 2 with seed %d: i = %d.", seed, i)
return
} }
if tst[i].msgCnt != count[i] { if tst[i].msgCnt != count[i] {
x.Errorf("failed test case 3 with seed %d: i = %d, get %d, want %d.", seed, i, tst[i].msgCnt, count[i]) x.Fatalf("failed test case 3 with seed %d: i = %d, get %d, want %d.", seed, i, tst[i].msgCnt, count[i])
return
} }
} }
@ -647,30 +603,25 @@ func TestWatchers(x *testing.T) {
combined := tst[0].msgCnt + tst[last].msgCnt combined := tst[0].msgCnt + tst[last].msgCnt
if total != NumMessages+count[0] { if total != NumMessages+count[0] {
x.Errorf("failed test case 4 with seed %d: total = %d, count[0] = %d.", seed, total, count[0]) x.Fatalf("failed test case 4 with seed %d: total = %d, count[0] = %d.", seed, total, count[0])
return
} }
if combined != count[0] { if combined != count[0] {
x.Errorf("failed test case 5 with seed %d: combined = %d, count[0] = %d.", seed, combined, count[0]) x.Fatalf("failed test case 5 with seed %d: combined = %d, count[0] = %d.", seed, combined, count[0])
return
} }
if combined != count[last] { if combined != count[last] {
x.Errorf("failed test case 6 with seed %d: combined = %d, count[last] = %d.", seed, combined, count[last]) x.Fatalf("failed test case 6 with seed %d: combined = %d, count[last] = %d.", seed, combined, count[last])
return
} }
for i = 1; i < NumFilters-1; i++ { for i = 1; i < NumFilters-1; i++ {
mail = tst[i].f.Retrieve() mail = tst[i].f.Retrieve()
if len(mail) != 0 { if len(mail) != 0 {
x.Errorf("failed test case 7 with seed %d: i = %d.", seed, i) x.Fatalf("failed test case 7 with seed %d: i = %d.", seed, i)
return
} }
if tst[i].msgCnt != count[i] { if tst[i].msgCnt != count[i] {
x.Errorf("failed test case 8 with seed %d: i = %d, get %d, want %d.", seed, i, tst[i].msgCnt, count[i]) x.Fatalf("failed test case 8 with seed %d: i = %d, get %d, want %d.", seed, i, tst[i].msgCnt, count[i])
return
} }
} }
@ -685,8 +636,7 @@ func TestWatchers(x *testing.T) {
} }
if total != 0 { if total != 0 {
x.Errorf("failed test case 9 with seed %d.", seed) x.Fatalf("failed test case 9 with seed %d.", seed)
return
} }
f := filters.Get(0) f := filters.Get(0)
@ -700,7 +650,6 @@ func TestWatchers(x *testing.T) {
} }
if total != 1 { if total != 1 {
x.Errorf("failed test case 10 with seed %d: total = %d.", seed, total) x.Fatalf("failed test case 10 with seed %d: total = %d.", seed, total)
return
} }
} }

90
whisper/whisperv5/message_test.go
View file

@ -60,14 +60,12 @@ func generateMessageParams() (*MessageParams, error) {
func singleMessageTest(x *testing.T, symmetric bool) { func singleMessageTest(x *testing.T, symmetric bool) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("failed GenerateKey with seed %d: %s.", seed, err) x.Fatalf("failed GenerateKey with seed %d: %s.", seed, err)
return
} }
if !symmetric { if !symmetric {
@ -85,8 +83,7 @@ func singleMessageTest(x *testing.T, symmetric bool) {
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed Wrap with seed %d: %s.", seed, err) x.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
var decrypted *ReceivedMessage var decrypted *ReceivedMessage
@ -97,35 +94,28 @@ func singleMessageTest(x *testing.T, symmetric bool) {
} }
if err != nil { if err != nil {
x.Errorf("failed to encrypt with seed %d: %s.", seed, err) x.Fatalf("failed to encrypt with seed %d: %s.", seed, err)
return
} }
if !decrypted.Validate() { if !decrypted.Validate() {
x.Errorf("failed to validate with seed %d.", seed) x.Fatalf("failed to validate with seed %d.", seed)
return
} }
padsz := len(decrypted.Padding) padsz := len(decrypted.Padding)
if bytes.Compare(steg[:padsz], decrypted.Padding) != 0 { if bytes.Compare(steg[:padsz], decrypted.Padding) != 0 {
x.Errorf("failed with seed %d: compare padding.", seed) x.Fatalf("failed with seed %d: compare padding.", seed)
return
} }
if bytes.Compare(text, decrypted.Payload) != 0 { if bytes.Compare(text, decrypted.Payload) != 0 {
x.Errorf("failed with seed %d: compare payload.", seed) x.Fatalf("failed with seed %d: compare payload.", seed)
return
} }
if !isMessageSigned(decrypted.Raw[0]) { if !isMessageSigned(decrypted.Raw[0]) {
x.Errorf("failed with seed %d: unsigned.", seed) x.Fatalf("failed with seed %d: unsigned.", seed)
return
} }
if len(decrypted.Signature) != signatureLength { if len(decrypted.Signature) != signatureLength {
x.Errorf("failed with seed %d: signature len %d.", seed, len(decrypted.Signature)) x.Fatalf("failed with seed %d: signature len %d.", seed, len(decrypted.Signature))
return
} }
if !isPubKeyEqual(decrypted.Src, &params.Src.PublicKey) { if !isPubKeyEqual(decrypted.Src, &params.Src.PublicKey) {
x.Errorf("failed with seed %d: signature mismatch.", seed) x.Fatalf("failed with seed %d: signature mismatch.", seed)
return
} }
} }
@ -146,8 +136,7 @@ func TestMessageWrap(x *testing.T) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
msg := NewSentMessage(params) msg := NewSentMessage(params)
@ -156,14 +145,12 @@ func TestMessageWrap(x *testing.T) {
params.PoW = target params.PoW = target
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed Wrap with seed %d: %s.", seed, err) x.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
pow := env.PoW() pow := env.PoW()
if pow < target { if pow < target {
x.Errorf("failed Wrap with seed %d: pow < target (%f vs. %f).", seed, pow, target) x.Fatalf("failed Wrap with seed %d: pow < target (%f vs. %f).", seed, pow, target)
return
} }
} }
@ -174,8 +161,7 @@ func TestMessageSeal(x *testing.T) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
msg := NewSentMessage(params) msg := NewSentMessage(params)
@ -187,8 +173,7 @@ func TestMessageSeal(x *testing.T) {
env := NewEnvelope(params.TTL, params.Topic, salt, aesnonce, msg) env := NewEnvelope(params.TTL, params.Topic, salt, aesnonce, msg)
if err != nil { if err != nil {
x.Errorf("failed Wrap with seed %d: %s.", seed, err) x.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
env.Expiry = uint32(seed) // make it deterministic env.Expiry = uint32(seed) // make it deterministic
@ -200,8 +185,7 @@ func TestMessageSeal(x *testing.T) {
env.calculatePoW(0) env.calculatePoW(0)
pow := env.PoW() pow := env.PoW()
if pow < target { if pow < target {
x.Errorf("failed Wrap with seed %d: pow < target (%f vs. %f).", seed, pow, target) x.Fatalf("failed Wrap with seed %d: pow < target (%f vs. %f).", seed, pow, target)
return
} }
params.WorkTime = 1 params.WorkTime = 1
@ -210,8 +194,7 @@ func TestMessageSeal(x *testing.T) {
env.calculatePoW(0) env.calculatePoW(0)
pow = env.PoW() pow = env.PoW()
if pow < 2*target { if pow < 2*target {
x.Errorf("failed Wrap with seed %d: pow too small %f.", seed, pow) x.Fatalf("failed Wrap with seed %d: pow too small %f.", seed, pow)
return
} }
} }
@ -228,14 +211,12 @@ func TestEnvelopeOpen(x *testing.T) {
func singleEnvelopeOpenTest(x *testing.T, symmetric bool) { func singleEnvelopeOpenTest(x *testing.T, symmetric bool) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed generateMessageParams with seed %d: %s.", seed, err) x.Fatalf("failed generateMessageParams with seed %d: %s.", seed, err)
return
} }
key, err := crypto.GenerateKey() key, err := crypto.GenerateKey()
if err != nil { if err != nil {
x.Errorf("failed GenerateKey with seed %d: %s.", seed, err) x.Fatalf("failed GenerateKey with seed %d: %s.", seed, err)
return
} }
if !symmetric { if !symmetric {
@ -253,54 +234,43 @@ func singleEnvelopeOpenTest(x *testing.T, symmetric bool) {
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed Wrap with seed %d: %s.", seed, err) x.Fatalf("failed Wrap with seed %d: %s.", seed, err)
return
} }
f := Filter{KeyAsym: key, KeySym: params.KeySym} f := Filter{KeyAsym: key, KeySym: params.KeySym}
decrypted := env.Open(&f) decrypted := env.Open(&f)
if decrypted == nil { if decrypted == nil {
x.Errorf("failed to open with seed %d.", seed) x.Fatalf("failed to open with seed %d.", seed)
return
} }
padsz := len(decrypted.Padding) padsz := len(decrypted.Padding)
if bytes.Compare(steg[:padsz], decrypted.Padding) != 0 { if bytes.Compare(steg[:padsz], decrypted.Padding) != 0 {
x.Errorf("failed with seed %d: compare padding.", seed) x.Fatalf("failed with seed %d: compare padding.", seed)
return
} }
if bytes.Compare(text, decrypted.Payload) != 0 { if bytes.Compare(text, decrypted.Payload) != 0 {
x.Errorf("failed with seed %d: compare payload.", seed) x.Fatalf("failed with seed %d: compare payload.", seed)
return
} }
if !isMessageSigned(decrypted.Raw[0]) { if !isMessageSigned(decrypted.Raw[0]) {
x.Errorf("failed with seed %d: unsigned.", seed) x.Fatalf("failed with seed %d: unsigned.", seed)
return
} }
if len(decrypted.Signature) != signatureLength { if len(decrypted.Signature) != signatureLength {
x.Errorf("failed with seed %d: signature len %d.", seed, len(decrypted.Signature)) x.Fatalf("failed with seed %d: signature len %d.", seed, len(decrypted.Signature))
return
} }
if !isPubKeyEqual(decrypted.Src, &params.Src.PublicKey) { if !isPubKeyEqual(decrypted.Src, &params.Src.PublicKey) {
x.Errorf("failed with seed %d: signature mismatch.", seed) x.Fatalf("failed with seed %d: signature mismatch.", seed)
return
} }
if decrypted.isAsymmetricEncryption() == symmetric { if decrypted.isAsymmetricEncryption() == symmetric {
x.Errorf("failed with seed %d: asymmetric %v vs. %v.", seed, decrypted.isAsymmetricEncryption(), symmetric) x.Fatalf("failed with seed %d: asymmetric %v vs. %v.", seed, decrypted.isAsymmetricEncryption(), symmetric)
return
} }
if decrypted.isSymmetricEncryption() != symmetric { if decrypted.isSymmetricEncryption() != symmetric {
x.Errorf("failed with seed %d: symmetric %v vs. %v.", seed, decrypted.isSymmetricEncryption(), symmetric) x.Fatalf("failed with seed %d: symmetric %v vs. %v.", seed, decrypted.isSymmetricEncryption(), symmetric)
return
} }
if !symmetric { if !symmetric {
if decrypted.Dst == nil { if decrypted.Dst == nil {
x.Errorf("failed with seed %d: dst is nil.", seed) x.Fatalf("failed with seed %d: dst is nil.", seed)
return
} }
if !isPubKeyEqual(decrypted.Dst, &key.PublicKey) { if !isPubKeyEqual(decrypted.Dst, &key.PublicKey) {
x.Errorf("failed with seed %d: Dst.", seed) x.Fatalf("failed with seed %d: Dst.", seed)
return
} }
} }
} }

32
whisper/whisperv5/peer_test.go
View file

@ -124,8 +124,7 @@ func initialize(x *testing.T) {
node.filerId = node.shh.Watch(&f) node.filerId = node.shh.Watch(&f)
node.id, err = crypto.HexToECDSA(keys[i]) node.id, err = crypto.HexToECDSA(keys[i])
if err != nil { if err != nil {
x.Errorf("failed convert the key: %s.", keys[i]) x.Fatalf("failed convert the key: %s.", keys[i])
return
} }
port := port0 + i port := port0 + i
addr := fmt.Sprintf(":%d", port) // e.g. ":30303" addr := fmt.Sprintf(":%d", port) // e.g. ":30303"
@ -155,8 +154,7 @@ func initialize(x *testing.T) {
err = node.server.Start() err = node.server.Start()
if err != nil { if err != nil {
x.Errorf("failed to start server %d.", i) x.Fatalf("failed to start server %d.", i)
return
} }
nodes[i] = &node nodes[i] = &node
@ -187,8 +185,7 @@ func checkPropagation(x *testing.T) {
for i := 0; i < NumNodes; i++ { for i := 0; i < NumNodes; i++ {
f := nodes[i].shh.GetFilter(nodes[i].filerId) f := nodes[i].shh.GetFilter(nodes[i].filerId)
if f == nil { if f == nil {
x.Errorf("failed to get filterId %d from node %d.", nodes[i].filerId, i) x.Fatalf("failed to get filterId %d from node %d.", nodes[i].filerId, i)
return
} }
mail := f.Retrieve() mail := f.Retrieve()
@ -197,13 +194,12 @@ func checkPropagation(x *testing.T) {
} }
if isTestComplete() { if isTestComplete() {
return return
} }
} }
} }
x.Errorf("Test was not complete: timeout %d seconds.", iterations*cycle/1000) x.Fatalf("Test was not complete: timeout %d seconds.", iterations*cycle/1000)
} }
func validateMail(x *testing.T, index int, mail []*ReceivedMessage) bool { func validateMail(x *testing.T, index int, mail []*ReceivedMessage) bool {
@ -219,7 +215,7 @@ func validateMail(x *testing.T, index int, mail []*ReceivedMessage) bool {
return true return true
} }
if cnt > 1 { if cnt > 1 {
x.Errorf("node %d received %d.", index, cnt) x.Fatalf("node %d received %d.", index, cnt)
return false return false
} }
@ -228,8 +224,7 @@ func validateMail(x *testing.T, index int, mail []*ReceivedMessage) bool {
defer result.mutex.Unlock() defer result.mutex.Unlock()
result.counter[index] += cnt result.counter[index] += cnt
if result.counter[index] > 1 { if result.counter[index] > 1 {
x.Errorf("node %d accumulated %d.", index, result.counter[index]) x.Fatalf("node %d accumulated %d.", index, result.counter[index])
return false
} }
} }
return true return true
@ -270,14 +265,12 @@ func sendMsg(x *testing.T, expected bool, id int) {
msg := NewSentMessage(&opt) msg := NewSentMessage(&opt)
envelope, err := msg.Wrap(&opt) envelope, err := msg.Wrap(&opt)
if err != nil { if err != nil {
x.Errorf("failed to seal message.") x.Fatalf("failed to seal message.")
return
} }
err = nodes[id].shh.Send(envelope) err = nodes[id].shh.Send(envelope)
if err != nil { if err != nil {
x.Errorf("failed to send message.") x.Fatalf("failed to send message.")
return
} }
} }
@ -286,22 +279,19 @@ func TestPeerBasic(x *testing.T) {
params, err := generateMessageParams() params, err := generateMessageParams()
if err != nil { if err != nil {
x.Errorf("failed 1 with seed %d.", seed) x.Fatalf("failed generateMessageParams with seed %d.", seed)
return
} }
params.PoW = 0.001 params.PoW = 0.001
msg := NewSentMessage(params) msg := NewSentMessage(params)
env, err := msg.Wrap(params) env, err := msg.Wrap(params)
if err != nil { if err != nil {
x.Errorf("failed 2 with seed %d.", seed) x.Fatalf("failed Wrap with seed %d.", seed)
return
} }
p := newPeer(nil, nil, nil) p := newPeer(nil, nil, nil)
p.mark(env) p.mark(env)
if !p.marked(env) { if !p.marked(env) {
x.Errorf("failed 3 with seed %d.", seed) x.Fatalf("failed mark with seed %d.", seed)
return
} }
} }

14
whisper/whisperv5/topic_test.go
View file

@ -32,7 +32,7 @@ func TestTopicString(x *testing.T) {
for i, tst := range topicStringTests { for i, tst := range topicStringTests {
s := tst.topic.String() s := tst.topic.String()
if s != tst.str { if s != tst.str {
x.Errorf("failed test %d: have %s, want %s.", i, s, tst.str) x.Fatalf("failed test %d: have %s, want %s.", i, s, tst.str)
} }
} }
} }
@ -57,7 +57,7 @@ func TestBytesToTopic(x *testing.T) {
for i, tst := range bytesToTopicTests { for i, tst := range bytesToTopicTests {
t := BytesToTopic(tst.data) t := BytesToTopic(tst.data)
if t != tst.topic { if t != tst.topic {
x.Errorf("failed test %d: have %v, want %v.", i, t, tst.topic) x.Fatalf("failed test %d: have %v, want %v.", i, t, tst.topic)
} }
} }
} }
@ -104,9 +104,9 @@ func TestUnmarshalTestsGood(x *testing.T) {
var t TopicType var t TopicType
err := t.UnmarshalJSON(tst.data) err := t.UnmarshalJSON(tst.data)
if err != nil { if err != nil {
x.Errorf("failed test %d. input: %v.", i, tst.data) x.Fatalf("failed test %d. input: %v.", i, tst.data)
} else if t != tst.topic { } else if t != tst.topic {
x.Errorf("failed test %d: have %v, want %v.", i, t, tst.topic) x.Fatalf("failed test %d: have %v, want %v.", i, t, tst.topic)
} }
} }
} }
@ -117,7 +117,7 @@ func TestUnmarshalTestsBad(x *testing.T) {
var t TopicType var t TopicType
err := t.UnmarshalJSON(tst.data) err := t.UnmarshalJSON(tst.data)
if err == nil { if err == nil {
x.Errorf("failed test %d. input: %v.", i, tst.data) x.Fatalf("failed test %d. input: %v.", i, tst.data)
} }
} }
} }
@ -128,9 +128,9 @@ func TestUnmarshalTestsUgly(x *testing.T) {
var t TopicType var t TopicType
err := t.UnmarshalJSON(tst.data) err := t.UnmarshalJSON(tst.data)
if err != nil { if err != nil {
x.Errorf("failed test %d. input: %v.", i, tst.data) x.Fatalf("failed test %d. input: %v.", i, tst.data)
} else if t == tst.topic { } else if t == tst.topic {
x.Errorf("failed test %d: have %v, want %v.", i, t, tst.topic) x.Fatalf("failed test %d: have %v, want %v.", i, t, tst.topic)
} }
} }
} }

198
whisper/whisperv5/whisper_test.go
View file

@ -29,114 +29,92 @@ func TestWhisperBasic(x *testing.T) {
p := w.Protocols() p := w.Protocols()
shh := p[0] shh := p[0]
if shh.Name != ProtocolName { if shh.Name != ProtocolName {
x.Errorf("failed Protocol Name: %v.", shh.Name) x.Fatalf("failed Protocol Name: %v.", shh.Name)
return
} }
if uint64(shh.Version) != ProtocolVersion { if uint64(shh.Version) != ProtocolVersion {
x.Errorf("failed Protocol Version: %v.", shh.Version) x.Fatalf("failed Protocol Version: %v.", shh.Version)
return
} }
if shh.Length != NumberOfMessageCodes { if shh.Length != NumberOfMessageCodes {
x.Errorf("failed Protocol Length: %v.", shh.Length) x.Fatalf("failed Protocol Length: %v.", shh.Length)
return
} }
if shh.Run == nil { if shh.Run == nil {
x.Errorf("failed shh.Run.") x.Fatalf("failed shh.Run.")
return
} }
if uint64(w.Version()) != ProtocolVersion { if uint64(w.Version()) != ProtocolVersion {
x.Errorf("failed whisper Version: %v.", shh.Version) x.Fatalf("failed whisper Version: %v.", shh.Version)
return
} }
if w.GetFilter(0) != nil { if w.GetFilter(0) != nil {
x.Errorf("failed GetFilter.") x.Fatalf("failed GetFilter.")
return
} }
peerID := make([]byte, 64) peerID := make([]byte, 64)
randomize(peerID) randomize(peerID)
peer, err := w.getPeer(peerID) peer, err := w.getPeer(peerID)
if peer != nil { if peer != nil {
x.Errorf("failed GetPeer.") x.Fatalf("failed GetPeer.")
return
} }
err = w.MarkPeerTrusted(peerID) err = w.MarkPeerTrusted(peerID)
if err == nil { if err == nil {
x.Errorf("failed MarkPeerTrusted.") x.Fatalf("failed MarkPeerTrusted.")
return
} }
err = w.RequestHistoricMessages(peerID, peerID) err = w.RequestHistoricMessages(peerID, peerID)
if err == nil { if err == nil {
x.Errorf("failed RequestHistoricMessages.") x.Fatalf("failed RequestHistoricMessages.")
return
} }
err = w.SendP2PMessage(peerID, nil) err = w.SendP2PMessage(peerID, nil)
if err == nil { if err == nil {
x.Errorf("failed SendP2PMessage.") x.Fatalf("failed SendP2PMessage.")
return
} }
exist := w.HasSymKey("non-existing") exist := w.HasSymKey("non-existing")
if exist { if exist {
x.Errorf("failed HasSymKey.") x.Fatalf("failed HasSymKey.")
return
} }
key := w.GetSymKey("non-existing") key := w.GetSymKey("non-existing")
if key != nil { if key != nil {
x.Errorf("failed GetSymKey.") x.Fatalf("failed GetSymKey.")
return
} }
mail := w.Envelopes() mail := w.Envelopes()
if len(mail) != 0 { if len(mail) != 0 {
x.Errorf("failed w.Envelopes().") x.Fatalf("failed w.Envelopes().")
return
} }
m := w.Messages(0) m := w.Messages(0)
if len(m) != 0 { if len(m) != 0 {
x.Errorf("failed w.Messages.") x.Fatalf("failed w.Messages.")
return
} }
var derived []byte var derived []byte
ver := uint64(0xDEADBEEF) ver := uint64(0xDEADBEEF)
derived, err = deriveKeyMaterial(peerID, ver) derived, err = deriveKeyMaterial(peerID, ver)
if err != unknownVersionError(ver) { if err != unknownVersionError(ver) {
x.Errorf("failed deriveKeyMaterial 1 with param = %v: %s.", peerID, err) x.Fatalf("failed deriveKeyMaterial test case 1 with param = %v: %s.", peerID, err)
return
} }
derived, err = deriveKeyMaterial(peerID, 0) derived, err = deriveKeyMaterial(peerID, 0)
if err != nil { if err != nil {
x.Errorf("failed deriveKeyMaterial 2 with param = %v: %s.", peerID, err) x.Fatalf("failed deriveKeyMaterial test case 2 with param = %v: %s.", peerID, err)
return
} }
if !validateSymmetricKey(derived) { if !validateSymmetricKey(derived) {
x.Errorf("failed validateSymmetricKey with param = %v.", derived) x.Fatalf("failed validateSymmetricKey with param = %v.", derived)
return
} }
if containsOnlyZeros(derived) { if containsOnlyZeros(derived) {
x.Errorf("failed containsOnlyZeros with param = %v.", derived) x.Fatalf("failed containsOnlyZeros with param = %v.", derived)
return
} }
buf := []byte{0xFF, 0xE5, 0x80, 0x2, 0} buf := []byte{0xFF, 0xE5, 0x80, 0x2, 0}
le := bytesToIntLittleEndian(buf) le := bytesToIntLittleEndian(buf)
be := BytesToIntBigEndian(buf) be := BytesToIntBigEndian(buf)
if le != uint64(0x280e5ff) { if le != uint64(0x280e5ff) {
x.Errorf("failed bytesToIntLittleEndian: %d.", le) x.Fatalf("failed bytesToIntLittleEndian: %d.", le)
return
} }
if be != uint64(0xffe5800200) { if be != uint64(0xffe5800200) {
x.Errorf("failed BytesToIntBigEndian: %d.", be) x.Fatalf("failed BytesToIntBigEndian: %d.", be)
return
} }
pk := w.NewIdentity() pk := w.NewIdentity()
if !validatePrivateKey(pk) { if !validatePrivateKey(pk) {
x.Errorf("failed validatePrivateKey: %v.", pk) x.Fatalf("failed validatePrivateKey: %v.", pk)
return
} }
if !ValidatePublicKey(&pk.PublicKey) { if !ValidatePublicKey(&pk.PublicKey) {
x.Errorf("failed ValidatePublicKey: %v.", pk) x.Fatalf("failed ValidatePublicKey: %v.", pk)
return
} }
} }
@ -149,20 +127,16 @@ func TestWhisperIdentityManagement(x *testing.T) {
pk1 := w.GetIdentity(pub1) pk1 := w.GetIdentity(pub1)
pk2 := w.GetIdentity(pub2) pk2 := w.GetIdentity(pub2)
if !w.HasIdentity(pub1) { if !w.HasIdentity(pub1) {
x.Errorf("failed HasIdentity 1.") x.Fatalf("failed test case 1.")
return
} }
if !w.HasIdentity(pub2) { if !w.HasIdentity(pub2) {
x.Errorf("failed HasIdentity 2.") x.Fatalf("failed test case 2.")
return
} }
if pk1 != id1 { if pk1 != id1 {
x.Errorf("failed GetIdentity 3.") x.Fatalf("failed test case 3.")
return
} }
if pk2 != id2 { if pk2 != id2 {
x.Errorf("failed GetIdentity 4.") x.Fatalf("failed test case 4.")
return
} }
// Delete one identity // Delete one identity
@ -170,20 +144,16 @@ func TestWhisperIdentityManagement(x *testing.T) {
pk1 = w.GetIdentity(pub1) pk1 = w.GetIdentity(pub1)
pk2 = w.GetIdentity(pub2) pk2 = w.GetIdentity(pub2)
if w.HasIdentity(pub1) { if w.HasIdentity(pub1) {
x.Errorf("failed HasIdentity 11.") x.Fatalf("failed test case 11.")
return
} }
if !w.HasIdentity(pub2) { if !w.HasIdentity(pub2) {
x.Errorf("failed HasIdentity 12.") x.Fatalf("failed test case 12.")
return
} }
if pk1 != nil { if pk1 != nil {
x.Errorf("failed GetIdentity 13.") x.Fatalf("failed test case 13.")
return
} }
if pk2 != id2 { if pk2 != id2 {
x.Errorf("failed GetIdentity 14.") x.Fatalf("failed test case 14.")
return
} }
// Delete again non-existing identity // Delete again non-existing identity
@ -191,20 +161,16 @@ func TestWhisperIdentityManagement(x *testing.T) {
pk1 = w.GetIdentity(pub1) pk1 = w.GetIdentity(pub1)
pk2 = w.GetIdentity(pub2) pk2 = w.GetIdentity(pub2)
if w.HasIdentity(pub1) { if w.HasIdentity(pub1) {
x.Errorf("failed HasIdentity 21.") x.Fatalf("failed test case 21.")
return
} }
if !w.HasIdentity(pub2) { if !w.HasIdentity(pub2) {
x.Errorf("failed HasIdentity 22.") x.Fatalf("failed test case 22.")
return
} }
if pk1 != nil { if pk1 != nil {
x.Errorf("failed GetIdentity 23.") x.Fatalf("failed test case 23.")
return
} }
if pk2 != id2 { if pk2 != id2 {
x.Errorf("failed GetIdentity 24.") x.Fatalf("failed test case 24.")
return
} }
// Delete second identity // Delete second identity
@ -212,20 +178,16 @@ func TestWhisperIdentityManagement(x *testing.T) {
pk1 = w.GetIdentity(pub1) pk1 = w.GetIdentity(pub1)
pk2 = w.GetIdentity(pub2) pk2 = w.GetIdentity(pub2)
if w.HasIdentity(pub1) { if w.HasIdentity(pub1) {
x.Errorf("failed HasIdentity 31.") x.Fatalf("failed test case 31.")
return
} }
if w.HasIdentity(pub2) { if w.HasIdentity(pub2) {
x.Errorf("failed HasIdentity 32.") x.Fatalf("failed test case 32.")
return
} }
if pk1 != nil { if pk1 != nil {
x.Errorf("failed GetIdentity 33.") x.Fatalf("failed test case 33.")
return
} }
if pk2 != nil { if pk2 != nil {
x.Errorf("failed GetIdentity 34.") x.Fatalf("failed test case 34.")
return
} }
} }
@ -239,27 +201,22 @@ func TestWhisperSymKeyManagement(x *testing.T) {
err := w.GenerateSymKey(id1) err := w.GenerateSymKey(id1)
if err != nil { if err != nil {
x.Errorf("failed test case 1 with seed %d: %s.", seed, err) x.Fatalf("failed test case 1 with seed %d: %s.", seed, err)
return
} }
k1 = w.GetSymKey(id1) k1 = w.GetSymKey(id1)
k2 = w.GetSymKey(id2) k2 = w.GetSymKey(id2)
if !w.HasSymKey(id1) { if !w.HasSymKey(id1) {
x.Errorf("failed HasIdentity 2.") x.Fatalf("failed test case 2.")
return
} }
if w.HasSymKey(id2) { if w.HasSymKey(id2) {
x.Errorf("failed HasIdentity 3.") x.Fatalf("failed test case 3.")
return
} }
if k1 == nil { if k1 == nil {
x.Errorf("failed GetIdentity 4.") x.Fatalf("failed test case 4.")
return
} }
if k2 != nil { if k2 != nil {
x.Errorf("failed GetIdentity 5.") x.Fatalf("failed test case 5.")
return
} }
// add existing id, nothing should change // add existing id, nothing should change
@ -267,91 +224,72 @@ func TestWhisperSymKeyManagement(x *testing.T) {
randomize(randomKey) randomize(randomKey)
err = w.AddSymKey(id1, randomKey) err = w.AddSymKey(id1, randomKey)
if err == nil { if err == nil {
x.Errorf("failed test case 10 with seed %d.", seed) x.Fatalf("failed test case 10 with seed %d.", seed)
return
} }
k1 = w.GetSymKey(id1) k1 = w.GetSymKey(id1)
k2 = w.GetSymKey(id2) k2 = w.GetSymKey(id2)
if !w.HasSymKey(id1) { if !w.HasSymKey(id1) {
x.Errorf("failed HasIdentity 12.") x.Fatalf("failed test case 12.")
return
} }
if w.HasSymKey(id2) { if w.HasSymKey(id2) {
x.Errorf("failed HasIdentity 13.") x.Fatalf("failed test case 13.")
return
} }
if k1 == nil { if k1 == nil {
x.Errorf("failed GetIdentity 14.") x.Fatalf("failed test case 14.")
return
} }
if bytes.Compare(k1, randomKey) == 0 { if bytes.Compare(k1, randomKey) == 0 {
x.Errorf("failed GetIdentity 15: k1 == randomKey.") x.Fatalf("failed test case 15: k1 == randomKey.")
return
} }
if k2 != nil { if k2 != nil {
x.Errorf("failed GetIdentity 16.") x.Fatalf("failed test case 16.")
return
} }
err = w.AddSymKey(id2, randomKey) // add non-existing (yet) err = w.AddSymKey(id2, randomKey) // add non-existing (yet)
if err != nil { if err != nil {
x.Errorf("failed test case 21 with seed %d: %s.", seed, err) x.Fatalf("failed test case 21 with seed %d: %s.", seed, err)
return
} }
k1 = w.GetSymKey(id1) k1 = w.GetSymKey(id1)
k2 = w.GetSymKey(id2) k2 = w.GetSymKey(id2)
if !w.HasSymKey(id1) { if !w.HasSymKey(id1) {
x.Errorf("failed HasIdentity 22.") x.Fatalf("failed test case 22.")
return
} }
if !w.HasSymKey(id2) { if !w.HasSymKey(id2) {
x.Errorf("failed HasIdentity 23.") x.Fatalf("failed test case 23.")
return
} }
if k1 == nil { if k1 == nil {
x.Errorf("failed GetIdentity 24.") x.Fatalf("failed test case 24.")
return
} }
if k2 == nil { if k2 == nil {
x.Errorf("failed GetIdentity 25.") x.Fatalf("failed test case 25.")
return
} }
if bytes.Compare(k1, k2) == 0 { if bytes.Compare(k1, k2) == 0 {
x.Errorf("failed GetIdentity 26.") x.Fatalf("failed test case 26.")
return
} }
if bytes.Compare(k1, randomKey) == 0 { if bytes.Compare(k1, randomKey) == 0 {
x.Errorf("failed GetIdentity 27.") x.Fatalf("failed test case 27.")
return
} }
if len(k1) != aesKeyLength { if len(k1) != aesKeyLength {
x.Errorf("failed GetIdentity 28.") x.Fatalf("failed test case 28.")
return
} }
if len(k2) != aesKeyLength { if len(k2) != aesKeyLength {
x.Errorf("failed GetIdentity 29.") x.Fatalf("failed test case 29.")
return
} }
w.DeleteSymKey(id1) w.DeleteSymKey(id1)
k1 = w.GetSymKey(id1) k1 = w.GetSymKey(id1)
k2 = w.GetSymKey(id2) k2 = w.GetSymKey(id2)
if w.HasSymKey(id1) { if w.HasSymKey(id1) {
x.Errorf("failed HasIdentity 31.") x.Fatalf("failed test case 31.")
return
} }
if !w.HasSymKey(id2) { if !w.HasSymKey(id2) {
x.Errorf("failed HasIdentity 32.") x.Fatalf("failed test case 32.")
return
} }
if k1 != nil { if k1 != nil {
x.Errorf("failed GetIdentity 33.") x.Fatalf("failed test case 33.")
return
} }
if k2 == nil { if k2 == nil {
x.Errorf("failed GetIdentity 34.") x.Fatalf("failed test case 34.")
return
} }
w.DeleteSymKey(id1) w.DeleteSymKey(id1)
@ -359,19 +297,15 @@ func TestWhisperSymKeyManagement(x *testing.T) {
k1 = w.GetSymKey(id1) k1 = w.GetSymKey(id1)
k2 = w.GetSymKey(id2) k2 = w.GetSymKey(id2)
if w.HasSymKey(id1) { if w.HasSymKey(id1) {
x.Errorf("failed HasIdentity 41.") x.Fatalf("failed test case 41.")
return
} }
if w.HasSymKey(id2) { if w.HasSymKey(id2) {
x.Errorf("failed HasIdentity 42.") x.Fatalf("failed test case 42.")
return
} }
if k1 != nil { if k1 != nil {
x.Errorf("failed GetIdentity 43.") x.Fatalf("failed test case 43.")
return
} }
if k2 != nil { if k2 != nil {
x.Errorf("failed GetIdentity 44.") x.Fatalf("failed test case 44.")
return
} }
} }