forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-24 08:49:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rpc: accept Windows reset error in websocket read limit test

Browse source 
TestServerWebsocketReadLimit/limit_with_large_request_-_should_fail
flakes on windows/amd64 when the server-side close races the client
read. On Windows the OS surfaces the reset as

  read tcp ...->...: wsarecv: An existing connection was forcibly
  closed by the remote host

instead of a websocket close frame, and the test rejects this as
"unexpected error for read limit violation".

Treat error strings containing "forcibly closed" as another acceptable
outcome of exceeding the read limit, alongside the existing CloseError
1009, ErrReadLimit, and "connection reset by peer" matches.

Fixes #34877
This commit is contained in:
ozpool 2026-05-11 11:52:03 +05:30
parent 01036bed83
commit aba74067f3
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
rpc/server_test.go
View file

@ -274,8 +274,11 @@ func TestServerWebsocketReadLimit(t *testing.T) {
} else if !errors.Is(err, websocket.ErrReadLimit) &&
!strings.Contains(strings.ToLower(err.Error()), "1009") &&
!strings.Contains(strings.ToLower(err.Error()), "message too big") &&
!strings.Contains(strings.ToLower(err.Error()), "connection reset by peer") {
// Not the error we expect from exceeding the message size limit.
!strings.Contains(strings.ToLower(err.Error()), "connection reset by peer") &&
!strings.Contains(strings.ToLower(err.Error()), "forcibly closed") {
// On Windows the server-side close races the client read and the OS
// surfaces the reset as "wsarecv: An existing connection was forcibly
// closed by the remote host" instead of a websocket close frame.
t.Fatalf("unexpected error for read limit violation: %v", err)
}
} else {