From ac0387fefa1a2efa369ab3a38ff151dc3d5efc89 Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Fri, 14 Jun 2019 12:29:38 +0200 Subject: [PATCH] core: fixes for review comments --- core/tx_pool.go | 2 +- core/tx_pool_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/tx_pool.go b/core/tx_pool.go index b42446b1b0..7b32b844c2 100644 --- a/core/tx_pool.go +++ b/core/tx_pool.go @@ -737,7 +737,7 @@ func (pool *TxPool) AddLocal(tx *types.Transaction) error { // AddRemotes enqueues a batch of transactions into the pool if they are valid. If the // senders are not among the locally tracked ones, full pricing constraints will apply. // -// This method is used to add transactions from the p2p and does not wait for pool +// This method is used to add transactions from the p2p network and does not wait for pool // reorganization and internal event propagation. func (pool *TxPool) AddRemotes(txs []*types.Transaction) []error { return pool.addTxs(txs, false, false) diff --git a/core/tx_pool_test.go b/core/tx_pool_test.go index 1e0b0c15a2..c9d061a202 100644 --- a/core/tx_pool_test.go +++ b/core/tx_pool_test.go @@ -280,7 +280,7 @@ func TestTransactionQueue(t *testing.T) { pool.currentState.SetNonce(from, 2) pool.enqueueTx(tx.Hash(), tx) - pool.promoteExecutables([]common.Address{from}) + <-pool.promoteExecutables([]common.Address{from}) if _, ok := pool.pending[from].txs.items[tx.Nonce()]; ok { t.Error("expected transaction to be in tx pool") }