cmd/geth: fix passing datadir flag to attach subcommand

the datadir flag wasn't respected, instead you had to provide an
additional argument, which was unclear from a usage point of view

Signed-off-by: Maximilian Meister <mmeister@suse.de>
This commit is contained in:
Maximilian Meister 2017-11-18 16:35:27 +01:00
parent 0f7fbb85d6
commit afab235477

View file

@ -17,6 +17,7 @@
package main
import (
"fmt"
"os"
"os/signal"
"strings"
@ -112,7 +113,11 @@ func localConsole(ctx *cli.Context) error {
// console to it.
func remoteConsole(ctx *cli.Context) error {
// Attach to a remotely running geth instance and start the JavaScript console
client, err := dialRPC(ctx.Args().First())
endpoint := ctx.Args().First()
if endpoint == "" && ctx.GlobalIsSet(utils.DataDirFlag.Name) {
endpoint = fmt.Sprintf("%s/geth.ipc", ctx.GlobalString(utils.DataDirFlag.Name))
}
client, err := dialRPC(endpoint)
if err != nil {
utils.Fatalf("Unable to attach to remote geth: %v", err)
}