forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-27 15:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

eth/downloader: fix mutex regression causing panics on fail

Browse source
This commit is contained in:
Péter Szilágyi 2017-01-19 11:18:12 +02:00
parent f087c66f95
commit b0ec4359a5
No known key found for this signature in database
GPG key ID: E9AE538CEDF8293D
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
eth/downloader/queue.go
View file

@ -1129,12 +1129,13 @@ func (q *queue) deliverNodeData(results []trie.SyncResult, callback func(int, bo
if err != nil { if err != nil {
q.stateSchedLock.Unlock() q.stateSchedLock.Unlock()
callback(i, progressed, err) callback(i, progressed, err)
return
} }
if err = batch.Write(); err != nil { if err = batch.Write(); err != nil {
q.stateSchedLock.Unlock() q.stateSchedLock.Unlock()
callback(i, progressed, err) callback(i, progressed, err)
return // TODO(karalabe): If a DB write fails (disk full), we ought to cancel the sync
} }
// Item processing succeeded, release the lock (temporarily) // Item processing succeeded, release the lock (temporarily)
progressed = progressed || prog progressed = progressed || prog
q.stateSchedLock.Unlock() q.stateSchedLock.Unlock()