forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-19 19:30:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

add ClientName attribute to OTEL resource

Browse source
This commit is contained in:
jonny rhea 2026-01-02 18:02:27 -06:00 committed by Felix Lange
parent 135f0fbfb1
commit b37fae7aa3
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
cmd/utils/otel.go
View file

@ -22,10 +22,12 @@ import (
"net/url" "net/url"
"time" "time"
"github.com/ethereum/go-ethereum/internal/version"
"github.com/ethereum/go-ethereum/log" "github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/node" "github.com/ethereum/go-ethereum/node"
"github.com/urfave/cli/v2" "github.com/urfave/cli/v2"
"go.opentelemetry.io/otel" "go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp" "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
"go.opentelemetry.io/otel/propagation" "go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/sdk/resource" "go.opentelemetry.io/otel/sdk/resource"
@ -48,10 +50,10 @@ func (o *otelService) Stop() error {
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel() defer cancel()
if err := o.tracerProvider.Shutdown(ctx); err != nil { if err := o.tracerProvider.Shutdown(ctx); err != nil {
log.Error("Failed to stop otelService", "err", err) log.Error("Failed to stop OTEL Service", "err", err)
return err return err
} }
log.Info("otelService stopped") log.Info("OTEL Service stopped")
return nil return nil
} }
@ -98,14 +100,11 @@ func SetupOTEL(ctx *cli.Context) (*otelService, error) {
} }
// Create resource with service information // Create resource with service information
res, err := resource.New(setupCtx, res := resource.NewWithAttributes(
resource.WithAttributes( semconv.SchemaURL,
semconv.ServiceName(serviceName), semconv.ServiceName(serviceName),
), attribute.String("ClientName", version.ClientName("geth")),
) )
if err != nil {
return nil, fmt.Errorf("failed to create otel resource: %w", err)
}
// Create TracerProvider // Create TracerProvider
tp := sdktrace.NewTracerProvider( tp := sdktrace.NewTracerProvider(
@ -117,6 +116,7 @@ func SetupOTEL(ctx *cli.Context) (*otelService, error) {
otel.SetTracerProvider(tp) otel.SetTracerProvider(tp)
// Set global propagator for context propagation // Set global propagator for context propagation
// Note: This should enable distributed tracing
otel.SetTextMapPropagator(propagation.NewCompositeTextMapPropagator( otel.SetTextMapPropagator(propagation.NewCompositeTextMapPropagator(
propagation.TraceContext{}, propagation.TraceContext{},
propagation.Baggage{}, propagation.Baggage{},