forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-18 02:40:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve log (#368)

Browse source 
* improve log
This commit is contained in:
Liam 2023-11-26 22:04:08 +11:00 committed by GitHub
parent 92689943a0
commit b4bd070837
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
consensus/XDPoS/engines/engine_v1/engine.go
View file

@ -310,7 +310,16 @@ func (x *XDPoS_v1) checkSignersOnCheckpoint(chain consensus.ChainReader, header
validSigners := utils.CompareSignersLists(masternodesFromCheckpointHeader, signers) validSigners := utils.CompareSignersLists(masternodesFromCheckpointHeader, signers)
if !validSigners { if !validSigners {
log.Error("Masternodes lists are different in checkpoint header and snapshot", "number", number, "masternodes_from_checkpoint_header", masternodesFromCheckpointHeader, "masternodes_in_snapshot", signers, "penList", penPenalties) log.Error("Masternodes lists are different in checkpoint header and snapshot", "number", number)
for i, v := range masternodesFromCheckpointHeader {
log.Error("masternodes_from_checkpoint_header", "i", i, "addr", v.Hex())
}
for i, v := range signers {
log.Error("masternodes_in_snapshot", "i", i, "addr", v.Hex())
}
for i, v := range penPenalties {
log.Error("penPenalties", "i", i, "addr", v.Hex())
}
return utils.ErrInvalidCheckpointSigners return utils.ErrInvalidCheckpointSigners
} }
if x.HookVerifyMNs != nil { if x.HookVerifyMNs != nil {
@ -816,7 +825,10 @@ func (x *XDPoS_v1) UpdateMasternodes(chain consensus.ChainReader, header *types.
nm = append(nm, n.Address.String()) nm = append(nm, n.Address.String())
} }
x.recents.Add(snap.Hash, snap) x.recents.Add(snap.Hash, snap)
log.Info("New set of masternodes has been updated to snapshot", "number", snap.Number, "hash", snap.Hash, "new masternodes", nm) log.Info("New set of masternodes has been updated to snapshot", "number", snap.Number, "hash", snap.Hash)
for i, v := range nm {
log.Info("masternodes", "i", i, "addr", v)
}
return nil return nil
} }

2
consensus/XDPoS/engines/engine_v2/vote.go
View file

@ -89,7 +89,7 @@ func (x *XDPoS_v2) voteHandler(chain consensus.ChainReader, voteMsg *types.Vote)
// Check if the block already exist, otherwise we try luck with the next vote // Check if the block already exist, otherwise we try luck with the next vote
proposedBlockHeader := chain.GetHeaderByHash(voteMsg.ProposedBlockInfo.Hash) proposedBlockHeader := chain.GetHeaderByHash(voteMsg.ProposedBlockInfo.Hash)
if proposedBlockHeader == nil { if proposedBlockHeader == nil {
log.Warn("[voteHandler] The proposed block from vote message does not exist yet, wait for the next vote to try again", "blockNum", voteMsg.ProposedBlockInfo.Number, "Hash", voteMsg.ProposedBlockInfo.Hash, "Round", voteMsg.ProposedBlockInfo.Round) log.Info("[voteHandler] The proposed block from vote message does not exist yet, wait for the next vote to try again", "blockNum", voteMsg.ProposedBlockInfo.Number, "Hash", voteMsg.ProposedBlockInfo.Hash, "Round", voteMsg.ProposedBlockInfo.Round)
return nil return nil
} }

8
eth/handler.go
View file

@ -280,7 +280,7 @@ func (pm *ProtocolManager) removePeer(id string) {
// Unregister the peer from the downloader and Ethereum peer set // Unregister the peer from the downloader and Ethereum peer set
pm.downloader.UnregisterPeer(id) pm.downloader.UnregisterPeer(id)
if err := pm.peers.Unregister(id); err != nil { if err := pm.peers.Unregister(id); err != nil {
log.Warn("Peer removal failed", "peer", id, "err", err) log.Debug("Peer removal failed", "peer", id, "err", err)
} }
// Hard disconnect at the networking layer // Hard disconnect at the networking layer
if peer != nil { if peer != nil {
@ -962,7 +962,7 @@ func (pm *ProtocolManager) BroadcastVote(vote *types.Vote) {
for _, peer := range peers { for _, peer := range peers {
err := peer.SendVote(vote) err := peer.SendVote(vote)
if err != nil { if err != nil {
log.Error("[BroadcastVote] Fail to broadcast vote message", "peerId", peer.id, "version", peer.version, "blockNum", vote.ProposedBlockInfo.Number, "err", err) log.Debug("[BroadcastVote] Fail to broadcast vote message", "peerId", peer.id, "version", peer.version, "blockNum", vote.ProposedBlockInfo.Number, "err", err)
pm.removePeer(peer.id) pm.removePeer(peer.id)
} }
} }
@ -979,7 +979,7 @@ func (pm *ProtocolManager) BroadcastTimeout(timeout *types.Timeout) {
for _, peer := range peers { for _, peer := range peers {
err := peer.SendTimeout(timeout) err := peer.SendTimeout(timeout)
if err != nil { if err != nil {
log.Error("[BroadcastTimeout] Fail to broadcast timeout message, remove peer", "peerId", peer.id, "version", peer.version, "timeout", timeout, "err", err) log.Debug("[BroadcastTimeout] Fail to broadcast timeout message, remove peer", "peerId", peer.id, "version", peer.version, "timeout", timeout, "err", err)
pm.removePeer(peer.id) pm.removePeer(peer.id)
} }
} }
@ -996,7 +996,7 @@ func (pm *ProtocolManager) BroadcastSyncInfo(syncInfo *types.SyncInfo) {
for _, peer := range peers { for _, peer := range peers {
err := peer.SendSyncInfo(syncInfo) err := peer.SendSyncInfo(syncInfo)
if err != nil { if err != nil {
log.Error("[BroadcastSyncInfo] Fail to broadcast syncInfo message, remove peer", "peerId", peer.id, "version", peer.version, "syncInfo", syncInfo, "err", err) log.Debug("[BroadcastSyncInfo] Fail to broadcast syncInfo message, remove peer", "peerId", peer.id, "version", peer.version, "syncInfo", syncInfo, "err", err)
pm.removePeer(peer.id) pm.removePeer(peer.id)
} }
} }