From b4d842be75b3e34049dfad92caf9229d415f1e53 Mon Sep 17 00:00:00 2001 From: Banana-J Date: Mon, 29 Jan 2024 11:31:36 +1100 Subject: [PATCH] chore: remove unnecessary order.status assignment (#407) --- XDCx/XDCx.go | 8 -------- XDCxlending/XDCxlending.go | 8 -------- 2 files changed, 16 deletions(-) diff --git a/XDCx/XDCx.go b/XDCx/XDCx.go index 75a2c7f9c8..bae3d00374 100644 --- a/XDCx/XDCx.go +++ b/XDCx/XDCx.go @@ -207,20 +207,12 @@ func (XDCx *XDCX) ProcessOrderPending(header *types.Header, coinbase common.Addr S: common.BigToHash(S), }, } - cancel := false - if order.Status == tradingstate.OrderStatusCancelled { - cancel = true - } log.Info("Process order pending", "orderPending", order, "BaseToken", order.BaseToken.Hex(), "QuoteToken", order.QuoteToken) originalOrder := &tradingstate.OrderItem{} *originalOrder = *order originalOrder.Quantity = tradingstate.CloneBigInt(order.Quantity) - if cancel { - order.Status = tradingstate.OrderStatusCancelled - } - newTrades, newRejectedOrders, err := XDCx.CommitOrder(header, coinbase, chain, statedb, XDCXstatedb, tradingstate.GetTradingOrderBookHash(order.BaseToken, order.QuoteToken), order) for _, reject := range newRejectedOrders { diff --git a/XDCxlending/XDCxlending.go b/XDCxlending/XDCxlending.go index fcdd8375fe..6818b375a2 100644 --- a/XDCxlending/XDCxlending.go +++ b/XDCxlending/XDCxlending.go @@ -144,20 +144,12 @@ func (l *Lending) ProcessOrderPending(header *types.Header, coinbase common.Addr S: common.BigToHash(S), }, } - cancel := false - if order.Status == lendingstate.LendingStatusCancelled { - cancel = true - } log.Info("Process order pending", "orderPending", order, "LendingToken", order.LendingToken.Hex(), "CollateralToken", order.CollateralToken) originalOrder := &lendingstate.LendingItem{} *originalOrder = *order originalOrder.Quantity = lendingstate.CloneBigInt(order.Quantity) - if cancel { - order.Status = lendingstate.LendingStatusCancelled - } - newTrades, newRejectedOrders, err := l.CommitOrder(header, coinbase, chain, statedb, lendingStatedb, tradingStateDb, lendingstate.GetLendingOrderBookHash(order.LendingToken, order.Term), order) for _, reject := range newRejectedOrders { log.Debug("Reject order", "reject", *reject)