cmd: deprecate flag --mine

cmd/XDC/config.go

@@ -98,7 +98,6 @@ type XDCConfig struct {
 	Metrics   metrics.Config
 	XDCX      XDCx.Config
 	Account   account
-	StakeEnable bool
 	Bootnodes Bootnodes
 	Verbosity int
 	NAT       string
@@ -136,7 +135,6 @@ func makeConfigNode(ctx *cli.Context) (*node.Node, XDCConfig) {
 		XDCX:      XDCx.DefaultConfig,
 		Node:      defaultNodeConfig(),
 		Metrics:   metrics.DefaultConfig,
-		StakeEnable: true,
 		Verbosity: 3,
 		NAT:       "",
 	}
@@ -147,7 +145,7 @@ func makeConfigNode(ctx *cli.Context) (*node.Node, XDCConfig) {
 		}
 	}
 	if ctx.IsSet(utils.MiningEnabledFlag.Name) {
-		cfg.StakeEnable = ctx.Bool(utils.MiningEnabledFlag.Name)
+		log.Warn("The flag --mine is deprecated and will be removed")
 	}
 	// if !ctx.IsSet(debug.VerbosityFlag.Name) {
 	// 	debug.Verbosity(log.Lvl(cfg.Verbosity))

cmd/utils/flags.go

@@ -334,11 +334,6 @@ var (
 	}
 
 	// Miner settings
-	MiningEnabledFlag = &cli.BoolFlag{
-		Name:     "mine",
-		Usage:    "Enable mining",
-		Category: flags.MinerCategory,
-	}
 	MinerThreadsFlag = &cli.IntFlag{
 		Name:     "miner-threads",
 		Aliases:  []string{"minerthreads"},

cmd/utils/flags_legacy.go

@@ -37,6 +37,7 @@ var DeprecatedFlags = []cli.Flag{
 	NoUSBFlag,
 	LogBacktraceAtFlag,
 	LogDebugFlag,
+	MiningEnabledFlag,
 }
 
 var (
@@ -74,6 +75,12 @@ var (
 		Usage:    "Enable expensive metrics collection and reporting (deprecated)",
 		Category: flags.DeprecatedCategory,
 	}
+	// Deprecated February 2025
+	MiningEnabledFlag = &cli.BoolFlag{
+		Name:     "mine",
+		Usage:    "Enable mining (deprecated)",
+		Category: flags.DeprecatedCategory,
+	}
 )
 
 // showDeprecated displays deprecated flags that will be soon removed from the codebase.