updated default txArrivalWait value to 500ms. updated commented lines to indicate the new default value. updated tx_fetcher_test to test using the new default value

cmd/utils/flags.go

@@ -757,7 +757,7 @@ var (
 	// fetcher flag to set arrival timeout
 	TxArrivalWaitFlag = cli.IntFlag{
 		Name:  "txarrivalwait",
-		Usage: "Maximum number of milliseconds to wait for a transaction before requesting it (defaults to 100ms)",
+		Usage: "Maximum number of milliseconds to wait for a transaction before requesting it (defaults to 500ms)",
 		Value: node.DefaultConfig.P2P.TxArrivalWait,
 	}
 

docs/cli/server.md

@@ -146,7 +146,7 @@ The ```bor server``` command runs the Bor client.
 
 - ```v5disc```: Enables the experimental RLPx V5 (Topic Discovery) mechanism (default: false)
 
-- ```txarrivalwait```: Maximum number of milliseconds to wait before requesting an announced transaction (default: 100)
+- ```txarrivalwait```: Maximum number of milliseconds to wait before requesting an announced transaction (default: 500)
 
 ### Sealer Options
 

eth/fetcher/tx_fetcher_test.go

@@ -39,7 +39,7 @@ var (
 	}
 	// testTxsHashes is the hashes of the test transactions above
 	testTxsHashes     = []common.Hash{testTxs[0].Hash(), testTxs[1].Hash(), testTxs[2].Hash(), testTxs[3].Hash()}
-	testTxArrivalWait = 100 * time.Millisecond
+	testTxArrivalWait = 500 * time.Millisecond
 )
 
 type doTxNotify struct {

internal/cli/server/config.go

@@ -458,7 +458,7 @@ func DefaultConfig() *Config {
 			Port:          30303,
 			NoDiscover:    false,
 			NAT:           "any",
-			TxArrivalWait: 100,
+			TxArrivalWait: 500,
 			Discovery: &P2PDiscovery{
 				V5Enabled:    false,
 				Bootnodes:    []string{},

internal/cli/server/flags.go

@@ -550,7 +550,7 @@ func (c *Command) Flags() *flagset.Flagset {
 	})
 	f.Uint64Flag(&flagset.Uint64Flag{
 		Name:    "txarrivalwait",
-		Usage:   "Maximum number of milliseconds to wait for a transaction before requesting it (defaults to 100ms)",
+		Usage:   "Maximum number of milliseconds to wait for a transaction before requesting it (defaults to 500ms)",
 		Value:   &c.cliConfig.P2P.TxArrivalWait,
 		Default: c.cliConfig.P2P.TxArrivalWait,
 		Group:   "P2P",

node/defaults.go

@@ -63,7 +63,7 @@ var DefaultConfig = Config{
 		ListenAddr:    ":30303",
 		MaxPeers:      50,
 		NAT:           nat.Any(),
-		TxArrivalWait: 100,
+		TxArrivalWait: 500,
 	},
 }