fix: add a error log when author not found for the block that will be emitted to ethstats (#427)

Co-authored-by: wjrjerome <wjrjerome@babylonchain.io>
This commit is contained in:
Banana-J 2024-02-11 20:31:48 +11:00 committed by GitHub
parent 54b254e25c
commit b739db6a52
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -94,13 +94,14 @@ type Service struct {
// websocket.
//
// From Gorilla websocket docs:
// Connections support one concurrent reader and one concurrent writer.
// Applications are responsible for ensuring that no more than one goroutine calls the write methods
// - NextWriter, SetWriteDeadline, WriteMessage, WriteJSON, EnableWriteCompression, SetCompressionLevel
// concurrently and that no more than one goroutine calls the read methods
// - NextReader, SetReadDeadline, ReadMessage, ReadJSON, SetPongHandler, SetPingHandler
// concurrently.
// The Close and WriteControl methods can be called concurrently with all other methods.
//
// Connections support one concurrent reader and one concurrent writer.
// Applications are responsible for ensuring that no more than one goroutine calls the write methods
// - NextWriter, SetWriteDeadline, WriteMessage, WriteJSON, EnableWriteCompression, SetCompressionLevel
// concurrently and that no more than one goroutine calls the read methods
// - NextReader, SetReadDeadline, ReadMessage, ReadJSON, SetPongHandler, SetPingHandler
// concurrently.
// The Close and WriteControl methods can be called concurrently with all other methods.
type connWrapper struct {
conn *websocket.Conn
@ -674,7 +675,10 @@ func (s *Service) assembleBlockStats(block *types.Block) *blockStats {
txs = []txStats{}
}
// Assemble and return the block stats
author, _ := s.engine.Author(header)
author, err := s.engine.Author(header)
if err != nil {
log.Error("Failed to retrieve block author", "err", err, "number", header.Number, "hash", header.Hash())
}
return &blockStats{
Number: header.Number,