forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-21 20:26:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

check tx sender is valid

Browse source
This commit is contained in:
Ethan Buchman 2015-01-26 10:57:23 -08:00
parent 48083608b5
commit b765e2d19c
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/transaction_pool.go
View file

@ -65,6 +65,11 @@ func (pool *TxPool) ValidateTransaction(tx *types.Transaction) error {
return fmt.Errorf("tx.v != (28 || 27) => %v", v) return fmt.Errorf("tx.v != (28 || 27) => %v", v)
} }
senderAddr := tx.From()
if senderAddr == nil || len(senderAddr) != 20 {
return fmt.Errorf("invalid sender")
}
/* XXX this kind of validation needs to happen elsewhere in the gui when sending txs. /* XXX this kind of validation needs to happen elsewhere in the gui when sending txs.
Other clients should do their own validation. Value transfer could throw error Other clients should do their own validation. Value transfer could throw error
but doesn't necessarily invalidate the tx. Gas can still be payed for and miner but doesn't necessarily invalidate the tx. Gas can still be payed for and miner