From ba61cfa2e1ab49f1507009380a7dd243c9603c44 Mon Sep 17 00:00:00 2001 From: marcello33 Date: Wed, 21 Jun 2023 10:54:47 +0200 Subject: [PATCH] dev: fix: t.Parallel called multiple times --- core/txpool/txpool_test.go | 1 - eth/handler_eth_test.go | 2 +- eth/protocols/eth/handler_test.go | 1 - node/node_auth_test.go | 2 -- 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/core/txpool/txpool_test.go b/core/txpool/txpool_test.go index 9aa1f59266..ff8dfb9348 100644 --- a/core/txpool/txpool_test.go +++ b/core/txpool/txpool_test.go @@ -2653,7 +2653,6 @@ func TestJournalingNoLocals(t *testing.T) { func testJournaling(t *testing.T, nolocals bool) { t.Helper() - t.Parallel() // Create a temporary file for the journal file, err := os.CreateTemp("", "") diff --git a/eth/handler_eth_test.go b/eth/handler_eth_test.go index 1f9cc0b8f6..83d5d14291 100644 --- a/eth/handler_eth_test.go +++ b/eth/handler_eth_test.go @@ -339,7 +339,7 @@ func TestSendTransactions68(t *testing.T) { } func testSendTransactions(t *testing.T, protocol uint) { - t.Parallel() + t.Helper() // Create a message handler and fill the pool with big transactions handler := newTestHandler() diff --git a/eth/protocols/eth/handler_test.go b/eth/protocols/eth/handler_test.go index b8fa856daf..a921bd673a 100644 --- a/eth/protocols/eth/handler_test.go +++ b/eth/protocols/eth/handler_test.go @@ -478,7 +478,6 @@ func TestGetNodeData68(t *testing.T) { func testGetNodeData(t *testing.T, protocol uint, drop bool) { t.Helper() - t.Parallel() // Define three accounts to simulate transactions with acc1Key, _ := crypto.HexToECDSA("8a1f9a8f95be41cd7ccb6168179afb4504aefe388d1e14474d32c45c72ce7b7a") diff --git a/node/node_auth_test.go b/node/node_auth_test.go index 92eb7988a1..1fc75b8e06 100644 --- a/node/node_auth_test.go +++ b/node/node_auth_test.go @@ -102,8 +102,6 @@ func (at *authTest) Run(t *testing.T) { // nolint: tparallel, paralleltest func TestAuthEndpoints(t *testing.T) { - t.Parallel() - var secret [32]byte if _, err := crand.Read(secret[:]); err != nil { t.Fatalf("failed to create jwt secret: %v", err)