forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 18:32:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

swarm/swap: address @justelad's PR comments

Browse source
This commit is contained in:
Fabio Barone 2018-11-14 09:48:26 -05:00
parent 0a7b7bd942
commit bacb6a4635
3 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
swarm/network/stream/stream.go
View file

@ -734,7 +734,7 @@ func (c *clientParams) clientCreated() {
close(c.clientCreatedC) close(c.clientCreatedC)
} }
//Return the streamer spec to callers //GetSpec returns the streamer spec to callers
//This used to be a global variable but for simulations with //This used to be a global variable but for simulations with
//multiple nodes its fields (notably the Hook) would be overwritten //multiple nodes its fields (notably the Hook) would be overwritten
func (r *Registry) GetSpec() *protocols.Spec { func (r *Registry) GetSpec() *protocols.Spec {
@ -742,11 +742,10 @@ func (r *Registry) GetSpec() *protocols.Spec {
} }
func (r *Registry) createSpec() { func (r *Registry) createSpec() {
// Spec is the spec of the streamer protocol // Spec is the spec of the streamer protocol
var spec = &protocols.Spec{ var spec = &protocols.Spec{
Name: "stream", Name: "stream",
Version: 7, Version: 8,
MaxMsgSize: 10 * 1024 * 1024, MaxMsgSize: 10 * 1024 * 1024,
Messages: []interface{}{ Messages: []interface{}{
UnsubscribeMsg{}, UnsubscribeMsg{},
@ -772,8 +771,6 @@ func (r *Registry) Protocols() []p2p.Protocol {
Version: r.spec.Version, Version: r.spec.Version,
Length: r.spec.Length(), Length: r.spec.Length(),
Run: r.runProtocol, Run: r.runProtocol,
// NodeInfo: ,
// PeerInfo: ,
}, },
} }
} }

2
swarm/swap/swap.go
View file

@ -69,7 +69,7 @@ func (s *Swap) Add(amount int64, peer *protocols.Peer) (err error) {
return err return err
} }
//Get a peer's balance //GetPeerBalance returns the balance for a given peer
func (swap *Swap) GetPeerBalance(peer enode.ID) (int64, error) { func (swap *Swap) GetPeerBalance(peer enode.ID) (int64, error) {
swap.lock.RLock() swap.lock.RLock()
defer swap.lock.RUnlock() defer swap.lock.RUnlock()

2
swarm/swap/swap_test.go
View file

@ -1,4 +1,4 @@
// Copyreeeeight 2018 The go-ethereum Authors // Copyright 2018 The go-ethereum Authors
// This file is part of the go-ethereum library. // This file is part of the go-ethereum library.
// //
// The go-ethereum library is free software: you can redistribute it and/or modify // The go-ethereum library is free software: you can redistribute it and/or modify